ci: Bump `TIDY_LLVM

hebasto commented at 10:48 am on March 15, 2024: member

This PR switches to the latest IWYU 0.22, which is compatible with Clang 18.

DrahtBot commented at 10:48 am on March 15, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Stale ACK	maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#28710 (Remove the legacy wallet and BDB dependency by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Tests on Mar 15, 2024

maflcko commented at 10:54 am on March 15, 2024: member

Please remove the unused src/script/signingprovider.cpp: // NOLINTNEXTLINE(modernize-use-emplace)

fanquake commented at 10:57 am on March 15, 2024: member

This PR switches to the latest IWYU 0.22

~~Where is this change?~~ Forgot we turned this into a one-liner.

hebasto force-pushed on Mar 15, 2024

maflcko commented at 11:01 am on March 15, 2024: member

Thanks!

lgtm ACK af2cd8e64d90308f71007198c63a51be6a5937dc

hebasto commented at 11:02 am on March 15, 2024: member

This PR switches to the latest IWYU 0.22

Where is this change?

The IWYU branch being built is clang_"${TIDY_LLVM_V}": https://github.com/bitcoin/bitcoin/blob/af2cd8e64d90308f71007198c63a51be6a5937dc/ci/test/01_base_install.sh#L70

fanquake commented at 11:30 am on March 15, 2024: member

CI is failing:

 0clang-tidy-18 -p=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/script/miniscript.cpp
 1./script/interpreter.h:28:1: error: enum '(unnamed enum at ./script/interpreter.h:28:1)' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
 2   28 | enum
 3      | ^
 4./script/interpreter.h:190:12: error: enum 'SigVersion' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
 5  190 | enum class SigVersion
 6      |            ^
 7./script/interpreter.h:274:12: error: enum 'MissingDataBehavior' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
 8  274 | enum class MissingDataBehavior
 9      |            ^
10./script/miniscript.h:194:12: error: enum 'Fragment' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
11  194 | enum class Fragment {
12      |            ^
13./script/miniscript.h:228:12: error: enum 'Availability' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
14  228 | enum class Availability {
15      |            ^
16./script/miniscript.h:234:12: error: enum 'MiniscriptContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
17  234 | enum class MiniscriptContext {
18      |            ^
19./script/miniscript.h:1663:12: error: enum 'ParseContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
20 1663 | enum class ParseContext {
21      |            ^
22./script/miniscript.h:2152:12: error: enum 'DecodeContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
23 2152 | enum class DecodeContext {
24      |            ^
25./script/script.h:72:6: error: enum 'opcodetype' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
26   72 | enum opcodetype
27      |      ^
28./script/script_error.h:11:14: error: enum 'ScriptError_t' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
29   11 | typedef enum ScriptError_t
30      |              ^
31./script/solver.h:22:12: error: enum 'TxoutType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
32   22 | enum class TxoutType {

DrahtBot added the label CI failed on Mar 15, 2024

ci: Bump `TIDY_LLVM_V`

This change switches to the latest IWYU 0.22, which is compatible with
Clang 18.

636c9862cf

hebasto force-pushed on Mar 15, 2024

DrahtBot removed the label CI failed on Mar 15, 2024

fanquake approved

fanquake commented at 3:10 pm on March 18, 2024: member

ACK 636c9862cfc8b3facc84eb62b51e18877f2022a9

DrahtBot requested review from maflcko on Mar 18, 2024

fanquake merged this on Mar 18, 2024

fanquake closed this on Mar 18, 2024

hebasto deleted the branch on Mar 18, 2024

ci: Bump TIDY_LLVM_V #29659

Code Coverage

Reviews

Conflicts

ci: Bump `TIDY_LLVM_V` #29659