This PR switches to the latest IWYU 0.22, which is compatible with Clang 18.
ci: Bump `TIDY_LLVM_V` #29659
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240315-llvm changing 3 files +2 −3-
hebasto commented at 10:48 AM on March 15, 2024: member
-
DrahtBot commented at 10:48 AM on March 15, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28710 (Remove the legacy wallet and BDB dependency by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Tests on Mar 15, 2024
-
maflcko commented at 10:54 AM on March 15, 2024: member
Please remove the unused
src/script/signingprovider.cpp: // NOLINTNEXTLINE(modernize-use-emplace) -
- hebasto force-pushed on Mar 15, 2024
-
maflcko commented at 11:01 AM on March 15, 2024: member
Thanks!
lgtm ACK af2cd8e64d90308f71007198c63a51be6a5937dc
-
hebasto commented at 11:02 AM on March 15, 2024: member
This PR switches to the latest IWYU 0.22
Where is this change?
The IWYU branch being built is
clang_"${TIDY_LLVM_V}": https://github.com/bitcoin/bitcoin/blob/af2cd8e64d90308f71007198c63a51be6a5937dc/ci/test/01_base_install.sh#L70 -
fanquake commented at 11:30 AM on March 15, 2024: member
CI is failing:
clang-tidy-18 -p=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/script/miniscript.cpp ./script/interpreter.h:28:1: error: enum '(unnamed enum at ./script/interpreter.h:28:1)' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 28 | enum | ^ ./script/interpreter.h:190:12: error: enum 'SigVersion' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 190 | enum class SigVersion | ^ ./script/interpreter.h:274:12: error: enum 'MissingDataBehavior' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 274 | enum class MissingDataBehavior | ^ ./script/miniscript.h:194:12: error: enum 'Fragment' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 194 | enum class Fragment { | ^ ./script/miniscript.h:228:12: error: enum 'Availability' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 228 | enum class Availability { | ^ ./script/miniscript.h:234:12: error: enum 'MiniscriptContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 234 | enum class MiniscriptContext { | ^ ./script/miniscript.h:1663:12: error: enum 'ParseContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 1663 | enum class ParseContext { | ^ ./script/miniscript.h:2152:12: error: enum 'DecodeContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 2152 | enum class DecodeContext { | ^ ./script/script.h:72:6: error: enum 'opcodetype' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 72 | enum opcodetype | ^ ./script/script_error.h:11:14: error: enum 'ScriptError_t' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 11 | typedef enum ScriptError_t | ^ ./script/solver.h:22:12: error: enum 'TxoutType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors] 22 | enum class TxoutType { - DrahtBot added the label CI failed on Mar 15, 2024
-
636c9862cf
ci: Bump `TIDY_LLVM_V`
This change switches to the latest IWYU 0.22, which is compatible with Clang 18.
- hebasto force-pushed on Mar 15, 2024
- DrahtBot removed the label CI failed on Mar 15, 2024
- fanquake approved
-
fanquake commented at 3:10 PM on March 18, 2024: member
ACK 636c9862cfc8b3facc84eb62b51e18877f2022a9
- DrahtBot requested review from maflcko on Mar 18, 2024
- fanquake merged this on Mar 18, 2024
- fanquake closed this on Mar 18, 2024
- hebasto deleted the branch on Mar 18, 2024
- bitcoin locked this on Mar 18, 2025
