This option has ceased to exist since #28349.
ci: Drop `--enable-c++20` option #29669
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240317-ci changing 1 files +1 −1-
hebasto commented at 4:55 PM on March 17, 2024: member
-
64722e4359
ci: Drop `--enable-c++20` option
This option has ceased to exist since https://github.com/bitcoin/bitcoin/pull/28349.
- hebasto added the label Tests on Mar 17, 2024
-
DrahtBot commented at 4:55 PM on March 17, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28710 (Remove the legacy wallet and BDB dependency by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
maflcko commented at 7:37 AM on March 18, 2024: member
I kept it, so that it can be turned into an c++23 option once there is cmake, but it is fine to remove the no-op in the meantime.
ACK 64722e4359bc101682d73e5a1a04ef2c68716d4c
-
fanquake commented at 4:28 PM on March 18, 2024: member
This will all have to be rewritten in any case, so fine to dump it.
- fanquake merged this on Mar 18, 2024
- fanquake closed this on Mar 18, 2024
- hebasto deleted the branch on Mar 18, 2024
- bitcoin locked this on Mar 18, 2025