Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us #29691

1. 
   luke-jr commented at 3:34 pm on March 21, 2024: member

   To avoid issues with DNS blacklisting, I’ve setup a separate domain for my DNS seed.

   (This time, without a potentially alarming name)

2. Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us

   To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.

   4f273ab436
3. 
   DrahtBot commented at 3:34 pm on March 21, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	petertodd, mzumsande, fanquake
   Concept ACK	Sjors, kevkevinpal

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   Sjors commented at 4:46 pm on March 21, 2024: member

   Concept ACK, seems like a fine name. Haven’t tested yet.
5. 
   kevkevinpal commented at 1:26 am on March 27, 2024: contributor

   Concept ACK 4f273ab, name looks good to me
6. 
   petertodd commented at 5:54 pm on April 3, 2024: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/29691/commits/4f273ab4360c9aa72c2feb78787e1811ab58dc16

   DNS seems to resolve just fine for me, and returns IP addresses with a fair bit of overlap with the ones my DNS seed has.

7. DrahtBot requested review from Sjors on Apr 3, 2024
8. 
   Sjors commented at 8:30 am on April 5, 2024: member

   @luke-jr can you GPG sign this commit?

   Someone, possibly you, should also make a PR to update it here: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/check-dnsseeds.py (better still if it just parses src/kernel/chainparams.cpp).

   I ran the above script locally and it’s happy.

9. 
   mzumsande commented at 5:56 pm on April 6, 2024: contributor

   ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

   I did a quick check that it returns valid addresses under the new domain.

10. fanquake approved
11. 
    fanquake commented at 7:31 pm on April 6, 2024: member

    ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

    Someone, possibly you, should also make a PR to update it here:

    I don’t see why the person making the PR there matters; it’s only copying what is in kernel/chainparams. Opened one for recent changes: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/160

12. fanquake merged this on Apr 8, 2024
13. fanquake closed this on Apr 8, 2024

    ---

14. fanquake referenced this in commit c4bef9164c on Apr 9, 2024
15. fanquake referenced this in commit 20e6e8dc80 on Apr 16, 2024
16. 
    fanquake commented at 8:00 am on April 17, 2024: member

    Backported to 27.x in #29888.
17. glozow referenced this in commit d39ea519c7 on Apr 17, 2024

Contributors
luke-jr DrahtBot Sjors kevkevinpal petertodd mzumsande fanquake

Review Requested
Sjors