Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us #29691

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:dnsseed_dashjr_2024 changing 1 files +1 −1

luke-jr commented at 3:34 PM on March 21, 2024: member

To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.

(This time, without a potentially alarming name)

Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us

To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.

4f273ab436

DrahtBot commented at 3:34 PM on March 21, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK petertodd, mzumsande, fanquake

Concept ACK Sjors, kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Sjors commented at 4:46 PM on March 21, 2024: member

Concept ACK, seems like a fine name. Haven't tested yet.
kevkevinpal commented at 1:26 AM on March 27, 2024: contributor

Concept ACK 4f273ab, name looks good to me
petertodd commented at 5:54 PM on April 3, 2024: contributor

ACK https://github.com/bitcoin/bitcoin/pull/29691/commits/4f273ab4360c9aa72c2feb78787e1811ab58dc16

DNS seems to resolve just fine for me, and returns IP addresses with a fair bit of overlap with the ones my DNS seed has.
DrahtBot requested review from Sjors on Apr 3, 2024
Sjors commented at 8:30 AM on April 5, 2024: member

@luke-jr can you GPG sign this commit?

Someone, possibly you, should also make a PR to update it here: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/check-dnsseeds.py (better still if it just parses src/kernel/chainparams.cpp).

I ran the above script locally and it's happy.
mzumsande commented at 5:56 PM on April 6, 2024: contributor

ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

I did a quick check that it returns valid addresses under the new domain.
fanquake approved
fanquake commented at 7:31 PM on April 6, 2024: member

ACK 4f273ab4360c9aa72c2feb78787e1811ab58dc16

Someone, possibly you, should also make a PR to update it here:

I don't see why the person making the PR there matters; it's only copying what is in kernel/chainparams. Opened one for recent changes: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/160
fanquake merged this on Apr 8, 2024
fanquake closed this on Apr 8, 2024
fanquake referenced this in commit c4bef9164c on Apr 9, 2024
fanquake referenced this in commit 20e6e8dc80 on Apr 16, 2024
fanquake commented at 8:00 AM on April 17, 2024: member

Backported to 27.x in #29888.
glozow referenced this in commit d39ea519c7 on Apr 17, 2024
fanquake referenced this in commit c7885ecd77 on May 13, 2024
glozow referenced this in commit 6d7a1e3670 on May 24, 2024
itme-brain referenced this in commit 0e33cd786a on Dec 23, 2024
bitcoin locked this on Apr 20, 2025