[27.x] More backports and finalize

fanquake commented at 2:06 pm on April 1, 2024: member

Currently backports:

Pulls release notes: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/27.0-Release-Notes-Draft. Finalizes v27.0.

doc: Suggest installing dev packages for debian/ubuntu qt5 build

Pretty much all library packages were renamed in the 64-bit time_t
migration to add `t64` (even on 64-bit platforms).

Instead of complicating the doc with conditional package names, suggest
installing the `-dev` packages which still have the same name, and
besides that, are the right way to go about it as they contain the
"user facing" C++ headers needed to build against Qt5.

For Fedora, devel packages are already suggested.

This affects Ubuntu 24.04 and Debian Testing.

Github-Pull: #29764
Rebased-From: a3c6a13cb23999fa70c428f1229acbf1b3883f11

c4da61b323

ci: Pull in qtbase5-dev instead of seperate low-level libraries

Fix CI build for t64 migration.

Github-Pull: #29764
Rebased-From: 6c2990416e2dabd845f5ec50ec6ff138136c9b08

753c68dc0f

fanquake added this to the milestone 27.0 on Apr 1, 2024

DrahtBot commented at 2:06 pm on April 1, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	stickies-v, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Backport on Apr 1, 2024

DrahtBot added the label CI failed on Apr 1, 2024

ci: Print tsan errors to stderr

Github-Pull: #29740
Rebased-From: fa22a438fa8f1c9cd4b4c44ff45cefd178bf5999

bde54b7627

Update the developer mailing list address.

The developer mailing list was migrated to Google Groups in February 2024
as announced in https://groups.google.com/g/bitcoindev/c/aewBuV6k-LI.

The archives maintained by the Linux Foundation stopped updating in December
2024. Thus, we point to the new archive maintained by gnusha.org.

The codebase refers to old discussions linked to the Linux Foundation archives.
Since all links are still active to this date, we keep them as they are.

See #29782.

Github-Pull: #29782
Rebased-From: 0ead466a0c72bef0a8622749b84e9c7c5c37144f

fe51aceeca

fanquake force-pushed on Apr 4, 2024

DrahtBot removed the label CI failed on Apr 5, 2024

fanquake force-pushed on Apr 9, 2024

fanquake marked this as ready for review on Apr 9, 2024

fanquake requested review from stickies-v on Apr 9, 2024

fanquake renamed this:
~~[27.x] More backports (and maybe finalize)~~
[27.x] More backports and finalize
on Apr 9, 2024

darosior commented at 2:28 pm on April 11, 2024: member

Reminder it’s probably worth backporting #29853 to avoid hitting it in the fuzzer.

in doc/release-notes.md:58 in 4681f554bc outdated

54+  blocks. (#29189)
55+
56+mempool.dat compatibility
57+-------------------------
58+
59+- The `mempool.dat` file created by -persistmempool or the savemempool RPC will

vostrnad commented at 7:43 pm on April 13, 2024:

0- The `mempool.dat` file created by `-persistmempool` or the savemempool RPC will

in doc/release-notes.md:84 in 4681f554bc outdated

80+  fall out of consensus with the network. (#28956)
81+
82+Mempool Policy Changes
83+----------------------
84+
85+- Opt in Topologically Restricted Until Confirmation (TRUC) Transactions policy

vostrnad commented at 7:43 pm on April 13, 2024:

0- Opt-in Topologically Restricted Until Confirmation (TRUC) Transactions policy

in doc/release-notes.md:86 in 4681f554bc outdated

82+Mempool Policy Changes
83+----------------------
84+
85+- Opt in Topologically Restricted Until Confirmation (TRUC) Transactions policy
86+  (aka v3 transaction policy) is available for use on test networks only with
87+  `-acceptnonstdtxn=1`. By setting the transaction version number to 3, TRUC transactions

vostrnad commented at 7:43 pm on April 13, 2024:

0  (aka v3 transaction policy) is available for use on test networks when
1  `-acceptnonstdtxn=1` is set. By setting the transaction version number to 3, TRUC transactions

in doc/release-notes.md:104 in 4681f554bc outdated

100+  library. (#28967)
101+
102+Updated RPCs
103+------------
104+
105+- The addnode RPC now follows the -v2transport option (now on by default, see above) for making connections.

vostrnad commented at 7:43 pm on April 13, 2024:

0- The addnode RPC now follows the `-v2transport` option (now on by default, see above) for making connections.

in doc/release-notes.md:133 in 4681f554bc outdated

129+
130+Pruning
131+-------
132+
133+- When pruning during initial block download, more blocks will be pruned at each
134+  flush in order to speed up the syncing of such nodes.

vostrnad commented at 7:43 pm on April 13, 2024:

0  flush in order to speed up the syncing of such nodes. (#20827)

in doc/release-notes.md:140 in 4681f554bc outdated

136+Init
137+----
138+
139+- Various fixes to prevent issues where subsequent instances of Bitcoin Core would
140+  result in deletion of files in use by an existing instance. (#28784, #28946)
141+- Improved handling of empty settings.json files (#28920)

vostrnad commented at 7:43 pm on April 13, 2024:

0- Improved handling of empty `settings.json` files. (#28920)

stickies-v commented at 8:38 pm on April 14, 2024:

Incorrect pull number

0- Improved handling of empty settings.json files (#29144)

vostrnad commented at 7:45 pm on April 13, 2024: none

Reviewed the release notes. A few style nits/suggestions, one entry is missing its PR number.

okorye approved

bitcoin deleted a comment on Apr 14, 2024

in doc/release-notes.md:61 in 4681f554bc outdated

57+-------------------------
58+
59+- The `mempool.dat` file created by -persistmempool or the savemempool RPC will
60+  be written in a new format, which can not be read by previous software
61+  releases. To allow for a downgrade, a temporary setting `-persistmempoolv1` has
62+  been added to fall back to the legacy format. This new format includes the XOR'ing

stickies-v commented at 8:20 pm on April 14, 2024:

“This new format” right after talking about the legacy format is consusing imo.

Suggested rewrite 1)first explains the new format, 2) then describes how to fall back, 3) adds the PR number:

0- The `mempool.dat` file created by -persistmempool or the savemempool RPC will
1  be written in a new format. This new format includes the XOR'ing of transaction
2  contents to mitigate issues where external programs (such as anti-virus) attempt
3  to interpret and potentially modify the file.
4
5  This new format can not be read by previous software releases. To allow for a
6  downgrade, a temporary setting `-persistmempoolv1` has been added to fall back
7  to the legacy format. (#28207)

in doc/release-notes.md:92 in 4681f554bc outdated

88+  request the application of limits on spending of their unconfirmed outputs. These
89+  restrictions simplify the assessment of incentive compatibility of accepting or
90+  replacing TRUC transactions, thus ensuring any replacements are more profitable for
91+  the node and making fee-bumping more reliable. TRUC transactions are currently
92+  nonstandard and can only be used on test networks where the standardness rules are
93+  relaxed or disabled (e.g. with `-acceptnonstdtxn=1`).

stickies-v commented at 8:26 pm on April 14, 2024:

0  relaxed or disabled (e.g. with `-acceptnonstdtxn=1`). (#28948)

stickies-v commented at 8:55 pm on April 14, 2024: contributor

LGTM 4681f554bc6eb6f603512575de19bc52d08813e9 with a few release note nits

backports mostly clean, 753c68dc0f02644f223d407b33000dce7a763056 being the exception because of LLVM version bump
release notes look good and correspond with devwiki, quickly went through merges since v26.0 and couldn’t see any major omissions
i’m getting the same manpages output

doc: import release notes from devwiki

https://github.com/bitcoin-core/bitcoin-devwiki/wiki/27.0-Release-Notes-Draft.

9442ea82da

build: bump version to v27.0 final 2d2a0a369e

doc: update manual pages for v27.0 910e3e8728

fanquake force-pushed on Apr 15, 2024

fanquake commented at 8:49 am on April 15, 2024: member

@vostrnad @stickies-v thanks, combined suggestions.

stickies-v approved

stickies-v commented at 8:56 am on April 15, 2024: contributor

ACK 910e3e8728b258a38d38f8f9ddf6b23406e8d5ce - no changes except addressing nits

DrahtBot added the label CI failed on Apr 15, 2024

achow101 commented at 3:52 pm on April 15, 2024: member

ACK 910e3e8728b258a38d38f8f9ddf6b23406e8d5ce

fanquake merged this on Apr 15, 2024

fanquake closed this on Apr 15, 2024

fanquake deleted the branch on Apr 15, 2024

[27.x] More backports and finalize #29780

Code Coverage

Reviews