ci: disable `_FORTIFY_SOURCE` with MSAN #29837

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:msan_no_foritfy_source changing 2 files +4 −2

fanquake commented at 2:59 PM on April 9, 2024: member

By undefining _FORTIFY_SOURCE we can drop--disable-hardening.
ci: disable _FORTIFY_SOURCE with MSAN 08ff17d142
DrahtBot commented at 2:59 PM on April 9, 2024: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hernanmarino, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #29790 ([DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Tests on Apr 9, 2024
hernanmarino approved
hernanmarino commented at 7:32 PM on April 9, 2024: contributor

utACK 08ff17d1420a3d1c14c6b1a5436678fbb1dd9cbc . Relevant CI test seems to be working OK.
fanquake commented at 9:41 AM on April 10, 2024: member

Tested this over all 4 jobs. OSS-Fuzz PR is here: https://github.com/google/oss-fuzz/pull/11792.
DonggeLiu referenced this in commit c179c66e21 on Apr 18, 2024
maflcko commented at 1:51 PM on April 24, 2024: member

lgtm ACK 08ff17d1420a3d1c14c6b1a5436678fbb1dd9cbc
fanquake merged this on Apr 24, 2024
fanquake closed this on Apr 24, 2024
fanquake deleted the branch on Apr 24, 2024
bitcoin locked this on Apr 24, 2025

Type	Reviewers
ACK	hernanmarino, maflcko

Contributors

Labels

ci: disable `_FORTIFY_SOURCE` with MSAN #29837

Code Coverage

Reviews

Conflicts