psbt: Check non witness utxo outpoint early #29855

1. 
   achow101 commented at 3:00 pm on April 11, 2024: member

   A common issue that our fuzzers keep finding is that outpoints don’t exist in the non witness utxos. Instead of trying to track this down and checking in various individual places, do the check early during deserialization. This also unifies the error message returned for this class of problems.
2. psbt: Check non witness utxo outpoint early

   A common issue that our fuzzers keep finding is that outpoints don't
   exist in the non witness utxos. Instead of trying to track this down and
   checking in various individual places, do the check early during
   deserialization.

   9e13ccc50e
3. 
   DrahtBot commented at 3:00 pm on April 11, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, dergoegge, S3RK

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30212 (rename TransactionErrors: MISSING_INPUTS and ALREADY_IN_CHAIN by willcl-ark)
   • #21283 (Implement BIP 370 PSBTv2 by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label PSBT on Apr 11, 2024
5. 
   maflcko commented at 2:41 pm on April 12, 2024: member

   lgtm ACK 9e13ccc50eec9d2efe0f472e6d50dc822df70d84
6. DrahtBot added the label CI failed on Apr 18, 2024
7. DrahtBot removed the label CI failed on Apr 23, 2024
8. luke-jr referenced this in commit 5204a1a601 on Apr 24, 2024
9. maflcko added this to the milestone 28.0 on Jul 3, 2024
10. 
    maflcko commented at 10:15 am on July 3, 2024: member

    It would be nice to have this in 28.x
11. maflcko requested review from S3RK on Jul 3, 2024
12. dergoegge approved
13. 
    dergoegge commented at 5:54 pm on July 5, 2024: member

    utACK 9e13ccc50eec9d2efe0f472e6d50dc822df70d84
14. 
    S3RK commented at 7:55 am on July 8, 2024: contributor

    tACK 9e13ccc50eec9d2efe0f472e6d50dc822df70d84

    Reviewed code and verified new test vectors. Reproduced a crash on an older version with the new test vector.

15. ryanofsky merged this on Jul 8, 2024
16. ryanofsky closed this on Jul 8, 2024

    ---

17. fanquake referenced this in commit fa90989503 on Jul 17, 2024
18. 
    fanquake commented at 10:32 am on July 17, 2024: member

    Backported to 27.x in #30467.

Contributors
achow101 DrahtBot maflcko dergoegge S3RK fanquake

Review Requested
S3RK

Labels
PSBT

Milestone
28.0