rpc: Reword SighashFromStr error message #29870

1. 
   maflcko commented at 8:07 am on April 15, 2024: member

   Put quotes around the parameter. In theory, std::quoted should be used, but that seems overkill.

   This should avoid error messages such as A valid sighash parameter is not a valid sighash parameter. (code -8).

   Also, it should fix fuzz false positives when searching for internal bugs in the rpc fuzz target. For example, ZGVzY3JpcHRvcnByb2Nlc3Nwc2J0XP9ce1tdXOVJbnRlcm5hbCBidWcgZGV0ZWN0ZWQAXQ0AHfcAXQ1p7TJv.

2. rpc: Reword SighashFromStr error message fa6ab0d020
3. 
   DrahtBot commented at 8:07 am on April 15, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, brunoerg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label RPC/REST/ZMQ on Apr 15, 2024
5. 
   maflcko commented at 8:43 am on April 15, 2024: member

   cc @dergoegge
6. dergoegge approved
7. 
   dergoegge commented at 8:56 am on April 15, 2024: member

   ACK fa6ab0d020d0b1492203f7eb2ccb8051812de086
8. fanquake added the label Needs backport (27.x) on Apr 16, 2024
9. maflcko added the label Docs on Apr 16, 2024
10. 
    maflcko commented at 8:16 am on April 18, 2024: member

    Anything left to be done here?
11. brunoerg approved
12. 
    brunoerg commented at 8:07 pm on April 22, 2024: contributor

    utACK fa6ab0d020d0b1492203f7eb2ccb8051812de086
13. fanquake merged this on Apr 24, 2024
14. fanquake closed this on Apr 24, 2024

    ---

15. fanquake referenced this in commit a6a59cfebc on Apr 24, 2024
16. 
    fanquake commented at 12:59 pm on April 24, 2024: member

    Backported in #29888.
17. maflcko deleted the branch on Apr 24, 2024
18. maflcko removed the label Needs backport (27.x) on Apr 24, 2024
19. dasibcryptoidology approved
20. fanquake referenced this in commit c7885ecd77 on May 13, 2024
21. glozow referenced this in commit 2c62974cc0 on May 14, 2024
22. glozow referenced this in commit 96d0e818c5 on May 23, 2024
23. glozow referenced this in commit 6d7a1e3670 on May 24, 2024
24. 
    DCMTOKEN commented at 3:12 am on August 23, 2024: none

    Please approve my request for changes
25. 
    DCMTOKEN commented at 3:24 am on August 23, 2024: none

    Please approve changes so I can run a test and see if there’s any issues
26. bitcoin deleted a comment on Aug 23, 2024
27. bitcoin locked this on Aug 23, 2025

Contributors
maflcko DrahtBot dergoegge brunoerg fanquake dasibcryptoidology DCMTOKEN

Labels
Docs RPC/REST/ZMQ