Add a check for 32-byte (256-bit) and 64-byte (512-bit) aligned AVX memory accesses (vmova instructions), which cause issues combined with a GCC stack alignment bug on Windows. This check is added to the existing symbol-check.py.
Makes use of the capstone disassembler library.
Also add a test to test the behavior of the check on a series of assembly instructions against the expected output.
Closes #28413.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process. A summary of reviews will appear here.
Add a check for 32-byte (256 bit) and 64-byte (512 bit) aligned AVX
memory accesses (vmova instructions), which cause issues combined with a
GCC stack alignment bug on Windows. This check is added to the existing
symbol-check.py.
Makes use of the capstone disassembler library.
Also add a test to test the behavior of the check on a series of
assembly instructions against the expected output.
Closes #28413.
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
python-capstone at least exists in Guix already: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/engineering.scm#n1820.
Looks like python-capstone at least exists in Guix already: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/engineering.scm#n1820.
That’s good to know! i’m not that surprised, it’s a very popular library for doing binary analysis and reverse engineering kind of things. i’ll have a look at integrating it.
🐙 This pull request conflicts with the target branch and needs rebase.