depends: build expat with CMake #29878

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:depends_expat_use_cmake changing 1 files +9 −8

fanquake commented at 1:24 pm on April 15, 2024: member
Bumps expat from 2.4.8 -> 2.6.2
- Switches to downloading the source code, rather than a bootstrapped tarball.
- Source changes currently unreviewed, but done for now, given the amount of CMake related fixes listed in the changelog.
Switch to building Expat with CMake, instead of Autotools.
DrahtBot commented at 1:24 pm on April 15, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #29923 (depends: Remove Qt build-time dependencies by laanwj)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Build system on Apr 15, 2024
maflcko added the label DrahtBot Guix build requested on Apr 15, 2024
fanquake commented at 3:22 pm on April 15, 2024: member
Looks like there could be issues with expat, CMake and 32-bit builds:
- https://cirrus-ci.com/task/6695396838211584
- https://cirrus-ci.com/task/5850971908079616
DrahtBot added the label CI failed on Apr 15, 2024

DrahtBot commented at 4:56 am on April 16, 2024: contributor

Guix builds (on x86_64)

File	commit 07720b1cdd77399f32124641dbe1dd267eb0cf8b(master)	commit 6531a10097100f4b32801fc4b7e1a8b1a2f98230(master and this pull)
SHA256SUMS.part	`0f592e2a4dd1a72c...`
*-aarch64-linux-gnu-debug.tar.gz	`950b785908a964e9...`
*-aarch64-linux-gnu.tar.gz	`a79beb29c3cf15fc...`
*-arm-linux-gnueabihf-debug.tar.gz	`f53bfd09ff2c3449...`
*-arm-linux-gnueabihf.tar.gz	`4085f43478898128...`
*-arm64-apple-darwin-unsigned.tar.gz	`2312bc4f6987ce91...`
*-arm64-apple-darwin-unsigned.zip	`ed306c20047de31a...`
*-arm64-apple-darwin.tar.gz	`3e16b326765dedf9...`
*-powerpc64-linux-gnu-debug.tar.gz	`18243000b23c1660...`
*-powerpc64-linux-gnu.tar.gz	`efef0490f676adbc...`
*-riscv64-linux-gnu-debug.tar.gz	`16656dd37f2be4c0...`
*-riscv64-linux-gnu.tar.gz	`004af01b9c027530...`
*-x86_64-apple-darwin-unsigned.tar.gz	`937e2be89036f0c5...`
*-x86_64-apple-darwin-unsigned.zip	`42bde44f6715a089...`
*-x86_64-apple-darwin.tar.gz	`a24116ec51ffc113...`
*-x86_64-linux-gnu-debug.tar.gz	`3ae204424646236a...`
*-x86_64-linux-gnu.tar.gz	`91654c6f24f022a1...`
*.tar.gz	`64e1ce578ca601ac...`
guix_build.log	`3525746f599ef84b...`	`5e76f8f5f3323ce3...`
guix_build.log.diff		`245fae1f5e15ccac...`

DrahtBot removed the label DrahtBot Guix build requested on Apr 16, 2024
fanquake force-pushed on Apr 16, 2024
tobtoht commented at 1:28 pm on April 17, 2024: none
(Testing a script I’m developing on this PR)
- This package was signed with a GPG key that was used to sign a previous release: 3176EF7DB2367F1FCA4F306B1F9B0E909AF37285
- All files in common with the git repository have matching hashes.
- 26 files present in the tarball are not present in the git repository for a total of 57709 lines: https://paste.debian.net/plainh/ba0edfca
- After removal of the files above, this package contains no binaries, no archives and 4 generated scripts: https://paste.debian.net/plainh/ed6bbbc7
fanquake force-pushed on Apr 17, 2024
fanquake commented at 1:44 pm on April 17, 2024: member

26 files present in the tarball are not present in the git repository for a total of 57709 lines: https://paste.debian.net/plainh/ba0edfca After removal of the files above, this package contains no binaries, no archives and 4 generated scripts: https://paste.debian.net/plainh/ed6bbbc7

I’ve pushed a change that switches to downloading the unbootstraped source tarball. Want to re-run your script?
tobtoht commented at 2:06 pm on April 17, 2024: none
Want to re-run your script?
- No signature file found, however git tag R_2_6_2 is signed with a GPG key that was used to sign a previous release: 3176EF7DB2367F1FCA4F306B1F9B0E909AF37285
- All files in common with the git repository have matching hashes.
- Tarball does not contain any files that are not present in the git repository.
- This package contains no binaries, no archives and 4 generated scripts: https://paste.debian.net/plainh/beafa9aa
Those generated scripts are short and look harmless, btw.

I’ve pushed a change that switches to downloading the unbootstraped source tarball.

GitHub generated source archives may not have stable hashes: https://github.blog/2023-02-21-update-on-the-future-stability-of-source-code-archives-and-hashes/

I’m not sure if depends currently supports this, but falling back to the mirror on a hash mismatch may be sensible.
laanwj commented at 8:12 am on April 22, 2024: member

FWIW #29923 removes the need to deal with expat in any way (as it’s a dependency of a Qt dependency).
fanquake force-pushed on May 10, 2024
fanquake force-pushed on May 14, 2024
depends: expat 2.6.2 ea187ec73a
depends: switch to building expat with CMake ef85ac037c
fanquake force-pushed on May 21, 2024

Contributors
fanquake DrahtBot tobtoht laanwj

Labels
Build system CI failed

depends: build expat with CMake #29878

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64)