Switch to building Expat with CMake, instead of Autotools.
depends: build expat with CMake #29878
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends_expat_use_cmake changing 2 files +24 −5-
fanquake commented at 1:24 PM on April 15, 2024: member
-
DrahtBot commented at 1:24 PM on April 15, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- DrahtBot added the label Build system on Apr 15, 2024
- maflcko added the label DrahtBot Guix build requested on Apr 15, 2024
-
fanquake commented at 3:22 PM on April 15, 2024: member
Looks like there could be issues with expat, CMake and 32-bit builds:
- DrahtBot added the label CI failed on Apr 15, 2024
-
DrahtBot commented at 4:56 AM on April 16, 2024: contributor
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds (on x86_64)
File commit 07720b1cdd77399f32124641dbe1dd267eb0cf8b<br>(master) commit 6531a10097100f4b32801fc4b7e1a8b1a2f98230<br>(master and this pull) SHA256SUMS.part 0f592e2a4dd1a72c...*-aarch64-linux-gnu-debug.tar.gz 950b785908a964e9...*-aarch64-linux-gnu.tar.gz a79beb29c3cf15fc...*-arm-linux-gnueabihf-debug.tar.gz f53bfd09ff2c3449...*-arm-linux-gnueabihf.tar.gz 4085f43478898128...*-arm64-apple-darwin-unsigned.tar.gz 2312bc4f6987ce91...*-arm64-apple-darwin-unsigned.zip ed306c20047de31a...*-arm64-apple-darwin.tar.gz 3e16b326765dedf9...*-powerpc64-linux-gnu-debug.tar.gz 18243000b23c1660...*-powerpc64-linux-gnu.tar.gz efef0490f676adbc...*-riscv64-linux-gnu-debug.tar.gz 16656dd37f2be4c0...*-riscv64-linux-gnu.tar.gz 004af01b9c027530...*-x86_64-apple-darwin-unsigned.tar.gz 937e2be89036f0c5...*-x86_64-apple-darwin-unsigned.zip 42bde44f6715a089...*-x86_64-apple-darwin.tar.gz a24116ec51ffc113...*-x86_64-linux-gnu-debug.tar.gz 3ae204424646236a...*-x86_64-linux-gnu.tar.gz 91654c6f24f022a1...*.tar.gz 64e1ce578ca601ac...guix_build.log 3525746f599ef84b...5e76f8f5f3323ce3...guix_build.log.diff 245fae1f5e15ccac... - DrahtBot removed the label DrahtBot Guix build requested on Apr 16, 2024
- fanquake force-pushed on Apr 16, 2024
-
tobtoht commented at 1:28 PM on April 17, 2024: none
(Testing a script I'm developing on this PR)
- This package was signed with a GPG key that was used to sign a previous release:
3176EF7DB2367F1FCA4F306B1F9B0E909AF37285 - All files in common with the git repository have matching hashes.
- 26 files present in the tarball are not present in the git repository for a total of 57709 lines: https://paste.debian.net/plainh/ba0edfca
- After removal of the files above, this package contains no binaries, no archives and 4 generated scripts: https://paste.debian.net/plainh/ed6bbbc7
- This package was signed with a GPG key that was used to sign a previous release:
- fanquake force-pushed on Apr 17, 2024
-
fanquake commented at 1:44 PM on April 17, 2024: member
26 files present in the tarball are not present in the git repository for a total of 57709 lines: https://paste.debian.net/plainh/ba0edfca After removal of the files above, this package contains no binaries, no archives and 4 generated scripts: https://paste.debian.net/plainh/ed6bbbc7
I've pushed a change that switches to downloading the unbootstraped source tarball. Want to re-run your script?
-
tobtoht commented at 2:06 PM on April 17, 2024: none
Want to re-run your script?
- No signature file found, however git tag
R_2_6_2is signed with a GPG key that was used to sign a previous release:3176EF7DB2367F1FCA4F306B1F9B0E909AF37285 - All files in common with the git repository have matching hashes.
- Tarball does not contain any files that are not present in the git repository.
- This package contains no binaries, no archives and 4 generated scripts: https://paste.debian.net/plainh/beafa9aa
Those generated scripts are short and look harmless, btw.
I've pushed a change that switches to downloading the unbootstraped source tarball.
GitHub generated source archives may not have stable hashes: https://github.blog/2023-02-21-update-on-the-future-stability-of-source-code-archives-and-hashes/
I'm not sure if
dependscurrently supports this, but falling back to the mirror on a hash mismatch may be sensible. - No signature file found, however git tag
- fanquake force-pushed on May 10, 2024
- fanquake force-pushed on May 14, 2024
- fanquake force-pushed on May 21, 2024
- fanquake force-pushed on Jul 18, 2024
- fanquake force-pushed on Jul 18, 2024
- fanquake force-pushed on Jul 19, 2024
- fanquake force-pushed on Jul 19, 2024
-
fanquake commented at 10:00 AM on July 19, 2024: member
Rebased on master. 32-bit builds should also be fixed. No longer a version bump, just a Autotools -> CMake switch.
- fanquake marked this as ready for review on Jul 19, 2024
- DrahtBot removed the label CI failed on Jul 19, 2024
-
fanquake commented at 12:03 PM on July 19, 2024: member
Guix Build (x86_64, aarch64):
cd661a8196c71db10430898b78555489f2fb5a1b1e35bb633c18a5d21692bc3d guix-build-6ccf95586047/output/aarch64-linux-gnu/SHA256SUMS.part 8c340c73ed52b60db257032f18cc39db2ffee35f78c67f8fe4dc67557f33ebb7 guix-build-6ccf95586047/output/aarch64-linux-gnu/bitcoin-6ccf95586047-aarch64-linux-gnu-debug.tar.gz f77bf0c350d58b9a8755e1fab3c560e5aa1e5202181ddab0c098d3f9da96863f guix-build-6ccf95586047/output/aarch64-linux-gnu/bitcoin-6ccf95586047-aarch64-linux-gnu.tar.gz 16980ad25d964d83ef728a44f47fdc85a863da611ad0b7c8429fdd1ff3a9cbce guix-build-6ccf95586047/output/arm-linux-gnueabihf/SHA256SUMS.part d34eb0c7a905165586bf094066e6514088c8fdec3570296cdaf156028dbe2434 guix-build-6ccf95586047/output/arm-linux-gnueabihf/bitcoin-6ccf95586047-arm-linux-gnueabihf-debug.tar.gz 458c337e086b99753a55b56f9cb14c022c7a883fdf9ebe98fcfd53e472e621ea guix-build-6ccf95586047/output/arm-linux-gnueabihf/bitcoin-6ccf95586047-arm-linux-gnueabihf.tar.gz 59aca12ddb9265622abf6e1a63d011ea056b7e84a45d2824afa8b494df0e1c34 guix-build-6ccf95586047/output/arm64-apple-darwin/SHA256SUMS.part bc9f6f664f3f57993890b21a7ace8631dda2b4d8cd59a171a6f42a76c65b0baa guix-build-6ccf95586047/output/arm64-apple-darwin/bitcoin-6ccf95586047-arm64-apple-darwin-unsigned.tar.gz 23e9e94e6c472552175a124ce24bcb587d109abe1fa634567e257d99f97b4450 guix-build-6ccf95586047/output/arm64-apple-darwin/bitcoin-6ccf95586047-arm64-apple-darwin-unsigned.zip 3680fb7a35d0c96b4f57c834c2ec64c7509b052c9c5870caf10b88514cc8fa9a guix-build-6ccf95586047/output/arm64-apple-darwin/bitcoin-6ccf95586047-arm64-apple-darwin.tar.gz 59bd07c2d44da31c84eb212ffe222e8231af2fe4cf27442c2eeaeedba619b7eb guix-build-6ccf95586047/output/dist-archive/bitcoin-6ccf95586047.tar.gz 2c191c87284ca97102bd2ef75ae603d47139fcd7232d2f00dad0cda4895e25f2 guix-build-6ccf95586047/output/powerpc64-linux-gnu/SHA256SUMS.part ccc61296748f43b77ced8cbeaed535ca4c1cac03877e7bcb59fef0e965b78bb3 guix-build-6ccf95586047/output/powerpc64-linux-gnu/bitcoin-6ccf95586047-powerpc64-linux-gnu-debug.tar.gz 74c9840fb229751a0492dc40891671d675028460d9270058c346bbdafd8088f0 guix-build-6ccf95586047/output/powerpc64-linux-gnu/bitcoin-6ccf95586047-powerpc64-linux-gnu.tar.gz 48744eecfea3f69ed37bcb2bd61c78a1cb5f1604cfcafc6008542198202f904e guix-build-6ccf95586047/output/riscv64-linux-gnu/SHA256SUMS.part 154d3b870030f2f3ab131eaeb480301680c8605e2ed9bcfa21f7ab538d201144 guix-build-6ccf95586047/output/riscv64-linux-gnu/bitcoin-6ccf95586047-riscv64-linux-gnu-debug.tar.gz 82230a2fbcc70fd19b4e81b520edb0f9b17e985a8b0bb12ce9811cb6f0fd4cbf guix-build-6ccf95586047/output/riscv64-linux-gnu/bitcoin-6ccf95586047-riscv64-linux-gnu.tar.gz 08b058fbaac04b15eb86b9fa85385de28f3edf5dd4cbeb5b2bc759e0c08fae1f guix-build-6ccf95586047/output/x86_64-apple-darwin/SHA256SUMS.part 323b852b1f2070ad361aa4bcca331874d722e3c36ca8fb4918c7eac56143c3e7 guix-build-6ccf95586047/output/x86_64-apple-darwin/bitcoin-6ccf95586047-x86_64-apple-darwin-unsigned.tar.gz c6bcd22144bd1214523463d034decd9e3bf719d6e98a7fb8d297be3873c0292c guix-build-6ccf95586047/output/x86_64-apple-darwin/bitcoin-6ccf95586047-x86_64-apple-darwin-unsigned.zip 0a9a15d42e846eca13633d2dbeff083a497cde0457cf99922eeddb71d6d04e32 guix-build-6ccf95586047/output/x86_64-apple-darwin/bitcoin-6ccf95586047-x86_64-apple-darwin.tar.gz 9317f7c1c93674997ef1a7b80913a8820a42c611984eb923dd940793fb91f52c guix-build-6ccf95586047/output/x86_64-linux-gnu/SHA256SUMS.part 6d8ce4f5a669c73f9d0a4205debd6154fe55b69297ca5cd6d84cc5b03298b910 guix-build-6ccf95586047/output/x86_64-linux-gnu/bitcoin-6ccf95586047-x86_64-linux-gnu-debug.tar.gz 9a5937b0afe3cf08af74e7933916b0bfb7c19ba01c84a4bb4bf7b93f9d1c298c guix-build-6ccf95586047/output/x86_64-linux-gnu/bitcoin-6ccf95586047-x86_64-linux-gnu.tar.gz eae638dd409caf81ad286a20ce6a07bcebed3fd97fa0116f4f5ca62e51289c1c guix-build-6ccf95586047/output/x86_64-w64-mingw32/SHA256SUMS.part 452911441ef112df74a37e2c4d6802a723a8b456398fe02b556b4beb576a04e9 guix-build-6ccf95586047/output/x86_64-w64-mingw32/bitcoin-6ccf95586047-win64-debug.zip 67bebf7fd0695829e381fc5ca144248b517c656ee1ef9a2ea0b4a463d3de94bf guix-build-6ccf95586047/output/x86_64-w64-mingw32/bitcoin-6ccf95586047-win64-setup-unsigned.exe a24800d5c2ae63b5c25ce07f9a1974bc863526b39e292717335d4c27576b9064 guix-build-6ccf95586047/output/x86_64-w64-mingw32/bitcoin-6ccf95586047-win64-unsigned.tar.gz 78db9fd78a188cbb85fc82862976ed177625a5ad3388a33ab5cebebcc57be311 guix-build-6ccf95586047/output/x86_64-w64-mingw32/bitcoin-6ccf95586047-win64.zip - fanquake added the label DrahtBot Guix build requested on Jul 19, 2024
-
DrahtBot commented at 9:47 PM on July 19, 2024: contributor
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]
File commit ed739d14b58b5e772a65b85bb421703963b06852<br>(master) commit 555d0b9d318f6e8f9394021a103ebff9cf6b3b24<br>(master and this pull) SHA256SUMS.part 78b68bd96871cab5...b98706f28d79cf73...*-aarch64-linux-gnu-debug.tar.gz 4ab6ded094c6e3ac...07974a5e61915f12...*-aarch64-linux-gnu.tar.gz e3640ae8dd5ce887...6835bb1dadc9e06d...*-arm-linux-gnueabihf-debug.tar.gz ef973d61b826a6bf...d87c579a2a7d4a1d...*-arm-linux-gnueabihf.tar.gz 73761e7a0c5da636...f9b2ce8426061e1f...*-arm64-apple-darwin-unsigned.tar.gz 741f327766eafda7...fb014a0e6bbcbb01...*-arm64-apple-darwin-unsigned.zip c6a54ff993806187...1a1b889e1c441064...*-arm64-apple-darwin.tar.gz db9f98908e128085...732e8565ff3d642f...*-powerpc64-linux-gnu-debug.tar.gz 6aa0511d8b9a4998...97ebcccefd181c2c...*-powerpc64-linux-gnu.tar.gz d23b19e8b92efd0e...944951e9784a4765...*-riscv64-linux-gnu-debug.tar.gz 4fbd6e40b23688d4...0ea3d30a248e0c77...*-riscv64-linux-gnu.tar.gz eed7862e5cddd79d...af72ea6c7d0c033b...*-x86_64-apple-darwin-unsigned.tar.gz bd854422c154f80b...a668a3b0e8232df1...*-x86_64-apple-darwin-unsigned.zip 9588a9fd5951c260...7f2840e559483644...*-x86_64-apple-darwin.tar.gz d19c2d0866bccab7...5fbc119d6942422f...*-x86_64-linux-gnu-debug.tar.gz f1f89080491d1254...033b218259e914b4...*-x86_64-linux-gnu.tar.gz 7670d0d23ef251fd...dbb359ff75d6663f...*.tar.gz e01340258f66d98c...ca6260b2e445e109...guix_build.log 47cc3fac8ad2653a...6a0ac6001539f62b...guix_build.log.diff f26334bab0e4ca4a... - DrahtBot removed the label DrahtBot Guix build requested on Jul 19, 2024
-
hebasto commented at 1:25 PM on July 22, 2024: member
Tested 6ccf95586047ad520af15a8451154ae519e272f9.
Autotools compiles with
-fexceptions, but CMake doesn't. Considering that this option is disabled for C by default, should we mirror this behaviour?Should we bump the CMake minimum required version:
cmake_minimum_required(VERSION 3.1.3)?
- fanquake force-pushed on Jul 23, 2024
-
fanquake commented at 9:05 AM on July 23, 2024: member
should we mirror this behaviour?
Which behaviour? If this is missing from one build system, that could be a bug that should be reported upstream. Given that these are stubs compiled just so Qt can compile, I don't think it matters too much.
Should we bump the CMake minimum required version
Sure. Added a patch.
-
fanquake commented at 10:33 AM on July 23, 2024: member
Guix Build (aarch64):
4ed36603100265640e4e9e73fa8f04c2b10a581c0a68f37cb636f1cbff71469c guix-build-cf46c6b8f2ff/output/aarch64-linux-gnu/SHA256SUMS.part 70b0f40dec0646cc7378c17bb569c8aa292ceba93e9b7233e7a0067fde04a24c guix-build-cf46c6b8f2ff/output/aarch64-linux-gnu/bitcoin-cf46c6b8f2ff-aarch64-linux-gnu-debug.tar.gz e778fdbf6dcf74a8cfeac8d3b353f877809f96a6f4759e497d939b001874a357 guix-build-cf46c6b8f2ff/output/aarch64-linux-gnu/bitcoin-cf46c6b8f2ff-aarch64-linux-gnu.tar.gz c99a80fbee8f43dff0519d7dd76e41145dc9f4f1a593138fc19c147956092e7d guix-build-cf46c6b8f2ff/output/arm-linux-gnueabihf/SHA256SUMS.part eb6a3972d15e0f027cf2664c860e2b15228983db5d5b33f61b78f6602570f72e guix-build-cf46c6b8f2ff/output/arm-linux-gnueabihf/bitcoin-cf46c6b8f2ff-arm-linux-gnueabihf-debug.tar.gz d66b3386d3996a446fa54214f4e21f6aa2797808b16430f46af6a26d07ff661b guix-build-cf46c6b8f2ff/output/arm-linux-gnueabihf/bitcoin-cf46c6b8f2ff-arm-linux-gnueabihf.tar.gz 01d22496ecd504b6b9759b033c93d46719db7f3de90a2ccab014b80683186b2f guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/SHA256SUMS.part 3715a0f1b6fe1c0e557061adfffdf56fd54b9068cee463b2d22df22932d3a7e9 guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/bitcoin-cf46c6b8f2ff-arm64-apple-darwin-unsigned.tar.gz e6e5e2f8daba83c5c3145a043f42670997a81ea93b65642ec89ff4935e0c8a54 guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/bitcoin-cf46c6b8f2ff-arm64-apple-darwin-unsigned.zip d904963e5a27c3f7afda205dbe73a2a903c104a76bc20ba275fe9d96c48d37cf guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/bitcoin-cf46c6b8f2ff-arm64-apple-darwin.tar.gz 1276ee1ed31845f7656c2e120635f8dbe90b7d8e564eacd2c9065d162b3b4f07 guix-build-cf46c6b8f2ff/output/dist-archive/bitcoin-cf46c6b8f2ff.tar.gz 55a7f4a459d65d2bf2ec605f5c0e00ddae50a33eacb68525a2d08e3fbfcf87ff guix-build-cf46c6b8f2ff/output/powerpc64-linux-gnu/SHA256SUMS.part 04e4f6c6574070b30d4405b04f3d13c57356b127d06fa93eab6ade93c182fedc guix-build-cf46c6b8f2ff/output/powerpc64-linux-gnu/bitcoin-cf46c6b8f2ff-powerpc64-linux-gnu-debug.tar.gz 019f386d8debd534034fbc2ee448079ec742ccac2bff4487cd14fbfa3d99542d guix-build-cf46c6b8f2ff/output/powerpc64-linux-gnu/bitcoin-cf46c6b8f2ff-powerpc64-linux-gnu.tar.gz 497cda9eadb42f1612816efee54750d955593b598ca4543a80fa2ee429619f0e guix-build-cf46c6b8f2ff/output/riscv64-linux-gnu/SHA256SUMS.part 59fd779017a33673f3ee102d7fe33d59857a765ec42a768a622b3b8f5fbb573a guix-build-cf46c6b8f2ff/output/riscv64-linux-gnu/bitcoin-cf46c6b8f2ff-riscv64-linux-gnu-debug.tar.gz 99be98072747cd2b6decb9df417b02def8c9f0008ac75420c4d58220acd3fdfb guix-build-cf46c6b8f2ff/output/riscv64-linux-gnu/bitcoin-cf46c6b8f2ff-riscv64-linux-gnu.tar.gz 480972d8f878b720e044f5b0fd8d62df60bd3bbc4916801c175fb24a68165caa guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/SHA256SUMS.part 9441f7a2f1536349fa3dcab2807baa155fab720c388e46589fbbcb3082521626 guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/bitcoin-cf46c6b8f2ff-x86_64-apple-darwin-unsigned.tar.gz d249b182dfe0383d6a54d498d23e79b996ca66b88e5af66430da63dfe09e2e23 guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/bitcoin-cf46c6b8f2ff-x86_64-apple-darwin-unsigned.zip ddcc614b2f8a412426d0463401f0a265a99a09b69bb6b2831577669607ad4fe1 guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/bitcoin-cf46c6b8f2ff-x86_64-apple-darwin.tar.gz ab9b987f9e8c19e614ffc7e774b5e5eceb014a6420c07e19108fe5c815e1c321 guix-build-cf46c6b8f2ff/output/x86_64-linux-gnu/SHA256SUMS.part f6c2e2972a773aec557d88af8cfd97642b467b0d6b767d9be634d614d9ff8660 guix-build-cf46c6b8f2ff/output/x86_64-linux-gnu/bitcoin-cf46c6b8f2ff-x86_64-linux-gnu-debug.tar.gz bbd1be6ef572ee8e294b2f39c5196e821716a3dfd2fd19ba0fde93b49d5af495 guix-build-cf46c6b8f2ff/output/x86_64-linux-gnu/bitcoin-cf46c6b8f2ff-x86_64-linux-gnu.tar.gz e5e1bad1398f92e72e4f9a3160f8e364913c920abb55a894d287cd1c98ec7995 guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/SHA256SUMS.part e1a9a0af02ca80ace6362268346e5b77f7583443e64b2e08bd4d2bca5300b6da guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64-debug.zip ab1e958ae83e458f4cf7baac4a757f5f89a27f1a2f3b6c7d8259f0e2398b64ec guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64-setup-unsigned.exe 4337edce1e0c99d788d9522aae2224db161035181a13f294cba07b9407dcaa87 guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64-unsigned.tar.gz 5eefec2926a4d81c59d011e6cfdc3a460299ab524310cc3f546aeb977a904961 guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64.zip - hebasto approved
-
hebasto commented at 2:32 PM on July 23, 2024: member
ACK cf46c6b8f2ffc88e4d7299e952fae55d3ae56ef5.
*.lafiles are no longer created. Hence, there is no need to remove them:--- a/depends/packages/expat.mk +++ b/depends/packages/expat.mk @@ -33,5 +33,5 @@ define $(package)_stage_cmds endef define $(package)_postprocess_cmds - rm -rf share lib/cmake lib/*.la + rm -rf share lib/cmake endef(similar to #30506)
-
hebasto commented at 2:33 PM on July 23, 2024: member
My Guix build:
x86_64 4ed36603100265640e4e9e73fa8f04c2b10a581c0a68f37cb636f1cbff71469c guix-build-cf46c6b8f2ff/output/aarch64-linux-gnu/SHA256SUMS.part 70b0f40dec0646cc7378c17bb569c8aa292ceba93e9b7233e7a0067fde04a24c guix-build-cf46c6b8f2ff/output/aarch64-linux-gnu/bitcoin-cf46c6b8f2ff-aarch64-linux-gnu-debug.tar.gz e778fdbf6dcf74a8cfeac8d3b353f877809f96a6f4759e497d939b001874a357 guix-build-cf46c6b8f2ff/output/aarch64-linux-gnu/bitcoin-cf46c6b8f2ff-aarch64-linux-gnu.tar.gz c99a80fbee8f43dff0519d7dd76e41145dc9f4f1a593138fc19c147956092e7d guix-build-cf46c6b8f2ff/output/arm-linux-gnueabihf/SHA256SUMS.part eb6a3972d15e0f027cf2664c860e2b15228983db5d5b33f61b78f6602570f72e guix-build-cf46c6b8f2ff/output/arm-linux-gnueabihf/bitcoin-cf46c6b8f2ff-arm-linux-gnueabihf-debug.tar.gz d66b3386d3996a446fa54214f4e21f6aa2797808b16430f46af6a26d07ff661b guix-build-cf46c6b8f2ff/output/arm-linux-gnueabihf/bitcoin-cf46c6b8f2ff-arm-linux-gnueabihf.tar.gz 01d22496ecd504b6b9759b033c93d46719db7f3de90a2ccab014b80683186b2f guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/SHA256SUMS.part 3715a0f1b6fe1c0e557061adfffdf56fd54b9068cee463b2d22df22932d3a7e9 guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/bitcoin-cf46c6b8f2ff-arm64-apple-darwin-unsigned.tar.gz e6e5e2f8daba83c5c3145a043f42670997a81ea93b65642ec89ff4935e0c8a54 guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/bitcoin-cf46c6b8f2ff-arm64-apple-darwin-unsigned.zip d904963e5a27c3f7afda205dbe73a2a903c104a76bc20ba275fe9d96c48d37cf guix-build-cf46c6b8f2ff/output/arm64-apple-darwin/bitcoin-cf46c6b8f2ff-arm64-apple-darwin.tar.gz 1276ee1ed31845f7656c2e120635f8dbe90b7d8e564eacd2c9065d162b3b4f07 guix-build-cf46c6b8f2ff/output/dist-archive/bitcoin-cf46c6b8f2ff.tar.gz 55a7f4a459d65d2bf2ec605f5c0e00ddae50a33eacb68525a2d08e3fbfcf87ff guix-build-cf46c6b8f2ff/output/powerpc64-linux-gnu/SHA256SUMS.part 04e4f6c6574070b30d4405b04f3d13c57356b127d06fa93eab6ade93c182fedc guix-build-cf46c6b8f2ff/output/powerpc64-linux-gnu/bitcoin-cf46c6b8f2ff-powerpc64-linux-gnu-debug.tar.gz 019f386d8debd534034fbc2ee448079ec742ccac2bff4487cd14fbfa3d99542d guix-build-cf46c6b8f2ff/output/powerpc64-linux-gnu/bitcoin-cf46c6b8f2ff-powerpc64-linux-gnu.tar.gz 497cda9eadb42f1612816efee54750d955593b598ca4543a80fa2ee429619f0e guix-build-cf46c6b8f2ff/output/riscv64-linux-gnu/SHA256SUMS.part 59fd779017a33673f3ee102d7fe33d59857a765ec42a768a622b3b8f5fbb573a guix-build-cf46c6b8f2ff/output/riscv64-linux-gnu/bitcoin-cf46c6b8f2ff-riscv64-linux-gnu-debug.tar.gz 99be98072747cd2b6decb9df417b02def8c9f0008ac75420c4d58220acd3fdfb guix-build-cf46c6b8f2ff/output/riscv64-linux-gnu/bitcoin-cf46c6b8f2ff-riscv64-linux-gnu.tar.gz 480972d8f878b720e044f5b0fd8d62df60bd3bbc4916801c175fb24a68165caa guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/SHA256SUMS.part 9441f7a2f1536349fa3dcab2807baa155fab720c388e46589fbbcb3082521626 guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/bitcoin-cf46c6b8f2ff-x86_64-apple-darwin-unsigned.tar.gz d249b182dfe0383d6a54d498d23e79b996ca66b88e5af66430da63dfe09e2e23 guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/bitcoin-cf46c6b8f2ff-x86_64-apple-darwin-unsigned.zip ddcc614b2f8a412426d0463401f0a265a99a09b69bb6b2831577669607ad4fe1 guix-build-cf46c6b8f2ff/output/x86_64-apple-darwin/bitcoin-cf46c6b8f2ff-x86_64-apple-darwin.tar.gz ab9b987f9e8c19e614ffc7e774b5e5eceb014a6420c07e19108fe5c815e1c321 guix-build-cf46c6b8f2ff/output/x86_64-linux-gnu/SHA256SUMS.part f6c2e2972a773aec557d88af8cfd97642b467b0d6b767d9be634d614d9ff8660 guix-build-cf46c6b8f2ff/output/x86_64-linux-gnu/bitcoin-cf46c6b8f2ff-x86_64-linux-gnu-debug.tar.gz bbd1be6ef572ee8e294b2f39c5196e821716a3dfd2fd19ba0fde93b49d5af495 guix-build-cf46c6b8f2ff/output/x86_64-linux-gnu/bitcoin-cf46c6b8f2ff-x86_64-linux-gnu.tar.gz e5e1bad1398f92e72e4f9a3160f8e364913c920abb55a894d287cd1c98ec7995 guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/SHA256SUMS.part e1a9a0af02ca80ace6362268346e5b77f7583443e64b2e08bd4d2bca5300b6da guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64-debug.zip ab1e958ae83e458f4cf7baac4a757f5f89a27f1a2f3b6c7d8259f0e2398b64ec guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64-setup-unsigned.exe 4337edce1e0c99d788d9522aae2224db161035181a13f294cba07b9407dcaa87 guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64-unsigned.tar.gz 5eefec2926a4d81c59d011e6cfdc3a460299ab524310cc3f546aeb977a904961 guix-build-cf46c6b8f2ff/output/x86_64-w64-mingw32/bitcoin-cf46c6b8f2ff-win64.zip -
a517029646
depends: switch to building expat with CMake
Add a patch to set the minimum CMake to 3.16.
- fanquake force-pushed on Jul 23, 2024
- hebasto approved
-
hebasto commented at 2:55 PM on July 23, 2024: member
re-ACK a517029646ac86f9d72fcea204ff45db41702e37.
- fanquake merged this on Jul 24, 2024
- fanquake closed this on Jul 24, 2024
- fanquake deleted the branch on Jul 24, 2024
- PastaPastaPasta referenced this in commit 0e42cc39da on Sep 28, 2024
- PastaPastaPasta referenced this in commit cf8f4c99d9 on Oct 25, 2024
- PastaPastaPasta referenced this in commit e016ffada1 on Oct 27, 2024
- PastaPastaPasta referenced this in commit 565f2db930 on Oct 27, 2024
- bitcoin locked this on Jul 24, 2025