doc: Bash is needed in gen_id and is not installed on FreeBSD by default #29953

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240424-freebsd-bash changing 1 files +4 −0

hebasto commented at 2:29 PM on April 24, 2024: member

On FreeBSD 14.0, in the depends directory:

without bash:

$ gmake print-bdb_build_id_long
env: bash: No such file or directory
env: bash: No such file or directory
bdb_build_id_long=bdb-4.8.30-4b0c6f8e95251b9c6731844fc34111c04b75fd9f15c671d6e34f2a4d014ec1be-release  
$ gmake print-final_build_id
env: bash: No such file or directory
env: bash: No such file or directory
final_build_id=722b2d3e264

with bash:

$ gmake print-bdb_build_id_long 
bdb_build_id_long=bdb-4.8.30-4b0c6f8e95251b9c6731844fc34111c04b75fd9f15c671d6e34f2a4d014ec1be-release  1ed47cefe468014c79dedb275cf921f44ab28d91dd56bf94712409b81326d765
$ gmake print-final_build_id
final_build_id=7b4f9aaa683

DrahtBot commented at 2:29 PM on April 24, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK vasild, kristapsk, alfonsoromanz

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Docs on Apr 24, 2024
hebasto commented at 2:29 PM on April 24, 2024: member

cc @vasild @fanquake
fanquake commented at 2:31 PM on April 24, 2024: member

This should be added to the depends docs.
hebasto force-pushed on Apr 24, 2024
hebasto commented at 2:36 PM on April 24, 2024: member

This should be added to the depends docs.

Thanks! Added.

Type	Reviewers
ACK	vasild, kristapsk, alfonsoromanz

in doc/build-freebsd.md:45 in ec4568ff0e outdated

  41 | @@ -42,6 +42,7 @@ It is required to use Berkeley DB 4.8. You **cannot** use the BerkeleyDB library
  42 |  from ports. However, you can build DB 4.8 yourself [using depends](/depends).
  43 |  
  44 |  ```
  45 | +pkg install bash

fanquake commented at 2:38 PM on April 24, 2024:

So now it can be removed here.

hebasto commented at 2:40 PM on April 24, 2024:

Sure. Removed.

doc: Bash is needed in gen_id and is not installed on FreeBSD by default 9381052194
hebasto force-pushed on Apr 24, 2024
vasild approved
vasild commented at 4:42 PM on April 24, 2024: contributor

ACK 9381052194a78024b3994cc6ad906858c477b88f
kristapsk approved
kristapsk commented at 9:02 PM on April 24, 2024: contributor

ACK 9381052194a78024b3994cc6ad906858c477b88f
alfonsoromanz approved
alfonsoromanz commented at 12:47 PM on April 25, 2024: contributor

ACK 9381052194a78024b3994cc6ad906858c477b88f
fanquake merged this on Apr 25, 2024
fanquake closed this on Apr 25, 2024
hebasto deleted the branch on Apr 25, 2024
PastaPastaPasta referenced this in commit 263faed49d on Oct 25, 2024
PastaPastaPasta referenced this in commit 3df1ca102b on Oct 26, 2024
PastaPastaPasta referenced this in commit f211bb9289 on Oct 27, 2024
bitcoin locked this on Apr 25, 2025

Contributors

Labels

doc: Bash is needed in gen_id and is not installed on FreeBSD by default #29953

Code Coverage

Reviews