depends: pass verbose through to cmake based makefiles #29960

pull m3dwards wants to merge 1 commits into bitcoin:master from m3dwards:depends-cm-verbose changing 1 files +1 −0

m3dwards commented at 1:11 PM on April 25, 2024: contributor
While testing #29708 I was not able to enable verbose output to check which flags were being given to the compiler.

With this PR, running depends with V=1 will enable verbose output from makefiles generated by cmake.

How to test:
```
make -C depends libnatpmp V=1
```

depends: pass verbose through to cmake based make

When running depends with V=1 this will now enable verbose output from makefiles generated by cmake.

7c69baf227

DrahtBot commented at 1:11 PM on April 25, 2024: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto, fanquake

Concept ACK alfonsoromanz, theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #29962 (RFC: depends: add release type to CMake builds by theuni)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Build system on Apr 25, 2024
fanquake commented at 1:21 PM on April 25, 2024: member

Concept ACK
hebasto approved
hebasto commented at 1:30 PM on April 25, 2024: member
ACK 7c69baf227252511455bc06e315f6a3c7fc5a398. Tested using the folowing command:
```
make -C depends native_capnp_built MULTIPROCESS=1 V=1
```
DrahtBot requested review from fanquake on Apr 25, 2024
maflcko added the label DrahtBot Guix build requested on Apr 25, 2024
alfonsoromanz commented at 2:22 PM on April 25, 2024: contributor

Concept ACK
theuni commented at 5:02 PM on April 25, 2024: member

Concept ACK. I just ran into this locally. I solved it using V=1 VERBOSE=1, but this makes sense too.

Type	Reviewers
ACK	hebasto, fanquake
Concept ACK	alfonsoromanz, theuni

DrahtBot commented at 5:40 AM on April 26, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 0e2e7d1a355ab6d4c483e192a2f881a5beef2381<br>(master)	commit deda98e28ed50ca5d6f34eaeddae8a4d299a5dd2<br>(master and this pull)
SHA256SUMS.part	`cb61aee9f80ec1ba...`	`282e9656781e74a4...`
*-aarch64-linux-gnu-debug.tar.gz	`aee07f71c47fe4ce...`	`ccdd5f7e47b97d02...`
*-aarch64-linux-gnu.tar.gz	`ba2365bd11aa0d2e...`	`117cddbc843a018d...`
*-arm-linux-gnueabihf-debug.tar.gz	`5b8e0c3177a93ff7...`	`dfc4e820992cefae...`
*-arm-linux-gnueabihf.tar.gz	`80dd4d3fa9886900...`	`917321b8590b705e...`
*-arm64-apple-darwin-unsigned.tar.gz	`a05f1e80bb8368cf...`	`aa726a78c0fa8c76...`
*-arm64-apple-darwin-unsigned.zip	`d7fddc2fd63564b5...`	`65f0651e4fd98030...`
*-arm64-apple-darwin.tar.gz	`9cf49289529c199a...`	`a4a55c7282396678...`
*-powerpc64-linux-gnu-debug.tar.gz	`1ff0e9a500866b2f...`	`fba27becd65ea815...`
*-powerpc64-linux-gnu.tar.gz	`0c57fe0ca2060225...`	`f11dc31b379c36ba...`
*-riscv64-linux-gnu-debug.tar.gz	`f297c7785b048f1e...`	`eeb5c2f91de78d60...`
*-riscv64-linux-gnu.tar.gz	`ba8df476a4f5795d...`	`759a78fd93c9db17...`
*-x86_64-apple-darwin-unsigned.tar.gz	`f050edb765f1e320...`	`52adb8622d5af022...`
*-x86_64-apple-darwin-unsigned.zip	`37262b66a3c5729c...`	`c010af8b9e5e3b2e...`
*-x86_64-apple-darwin.tar.gz	`9a234f1b809e0f06...`	`3c8e03397f1d39f0...`
*-x86_64-linux-gnu-debug.tar.gz	`2934441057abec67...`	`0772ee06f2351958...`
*-x86_64-linux-gnu.tar.gz	`a6a70305a97536a8...`	`eabda4adc7456089...`
*.tar.gz	`380e07ef0f352d9b...`	`3b91e23e5c5728c4...`
guix_build.log	`3d2cadabdeb0586f...`	`37c3f193a47f42b1...`
guix_build.log.diff		`a51541c09914dfc5...`

DrahtBot removed the label DrahtBot Guix build requested on Apr 26, 2024
m3dwards commented at 4:46 PM on April 27, 2024: contributor

I have tried to look for an alternative variable that will enable verbose output regardless of build system but I couldn't find one. I thought this looked promising https://cmake.org/cmake/help/latest/envvar/VERBOSE.html but it didn't work for me.
fanquake approved
fanquake commented at 1:46 AM on May 6, 2024: member

ACK 7c69baf227252511455bc06e315f6a3c7fc5a398
DrahtBot requested review from theuni on May 6, 2024
fanquake merged this on May 6, 2024
fanquake closed this on May 6, 2024
PastaPastaPasta referenced this in commit 8bcf2eae9d on Oct 25, 2024
PastaPastaPasta referenced this in commit daa6eeed5f on Oct 26, 2024
PastaPastaPasta referenced this in commit f211bb9289 on Oct 27, 2024
bitcoin locked this on May 6, 2025