refactor: convert string formatting to F-strings #29969

All instances of string formatting have been converted to F-strings for increased readability and performance. Before that some of strings use .format and others use f-strings.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage

For detailed information about the code coverage, see the test coverage report.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #29971 (refactor: refactored platform assignment into get_platform function by iw4p)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

If this is just a refactor, why the fix: on the commit message (8c600f7f78d5aaf3577f6257b648727d72e32a06)?

If this is just a refactor, why the fix: on the commit message (8c600f7)?

Usually the most prefixes are fix and feat, but sometimes some repos and projects use other keywords like chore, ref, etc. reference. By the way I modified the commit message prefix.

You should read our developer notes for an overview of what is relevant to our project. ref doesn't mean anything here. You could probably use refactor:.

Sorry, I'm a newbie. I read this and only saw this tagging for PR title. Now I changed it to refactor.

Concept NACK. Thank you for looking into this, and I support increased f-string usage, but imo this should be done organically whenever these lines are touched for other reasons (or with a scripted-diff across the code base, and enforcing it with linter, should there be support to do that). In its current form, this is not worth the review time imo.

Hi, Thank you. I touched this file to optimize it like using built-in python request library instead of curl and decreasing the request numbers, and one more PR. That's why I decided to go for converting strings to f-string.

Thanks for your interest in contributing! CONTRIBUTING.md and developer-notes.md contain good resources for beginners. As we have 300+ pulls open right now, closing this test refactor to focus review attention on the others (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring)