build, msvc: Drop duplicated common\url.cpp source file #29976

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240426-msvc-url changing 1 files +0 −1
  1. hebasto commented at 9:56 pm on April 26, 2024: member

    After #29904, the common\url.cpp source file is included into the SOURCE_FILES by the msvc-autogen.py script.

    Removes a compiler warning:

    0url.obj : warning LNK4006: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl UrlDecode(class std::basic_string_view<char,struct std::char_traits<char> >)" (?UrlDecode@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$basic_string_view@DU?$char_traits@D@std@@@2@@Z) already defined in common_url.obj; second definition ignored [D:\a\bitcoin\bitcoin\build_msvc\libbitcoin_common\libbitcoin_common.vcxproj]
    
  2. build, msvc: Drop duplicated `common\url.cpp` source file
    It has been a part of SOURCE_FILES since https://github.com/bitcoin/bitcoin/pull/29904
    97a4ad5713
  3. hebasto added the label Windows on Apr 26, 2024
  4. hebasto added the label Build system on Apr 26, 2024
  5. DrahtBot commented at 9:56 pm on April 26, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  6. fanquake approved
  7. fanquake commented at 6:48 am on April 27, 2024: member
    ACK 97a4ad5713853f51c729cced73f133fafa735ba2
  8. fanquake merged this on Apr 27, 2024
  9. fanquake closed this on Apr 27, 2024

  10. hebasto deleted the branch on Apr 27, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me