msvc: Compile test\fuzz\bitdeque.cpp #29983

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:240428-msvc-fuzz-bitdeque changing 2 files +6 −7
  1. hebasto commented at 6:14 am on April 28, 2024: member

    This PR resolves one point from the #29774 (comment):

    What is the issue with the bitdeque… ?

  2. refactor: Fix "error C2248: cannot access private member" on MSVC 85f50a46c5
  3. build, msvc: Compile `test\fuzz\bitdeque.cpp` 774359b4a9
  4. DrahtBot commented at 6:14 am on April 28, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, dergoegge, sipa, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. hebasto renamed this:
    build, msvc: Compile `test\fuzz\bitdeque.cpp`
    msvc: Compile `test\fuzz\bitdeque.cpp`
    on Apr 28, 2024
  6. hebasto commented at 7:02 am on April 28, 2024: member
    cc @sipa
  7. laanwj added the label Windows on Apr 28, 2024
  8. laanwj added the label Build system on Apr 28, 2024
  9. maflcko commented at 10:46 am on April 29, 2024: member
    lgtm ACK 774359b4a96d2724dc70f900cb71e084a77164da
  10. dergoegge approved
  11. dergoegge commented at 2:16 pm on April 30, 2024: member
    utACK 774359b4a96d2724dc70f900cb71e084a77164da
  12. sipa commented at 4:48 pm on April 30, 2024: member
    utACK 774359b4a96d2724dc70f900cb71e084a77164da
  13. achow101 commented at 0:13 am on May 1, 2024: member

    ACK 774359b4a96d2724dc70f900cb71e084a77164da

    Tested on windows, the bitdeque fuzz target is indeed now available.

  14. achow101 merged this on May 1, 2024
  15. achow101 closed this on May 1, 2024

  16. hebasto deleted the branch on May 1, 2024
  17. hebasto added the label Needs CMake port on May 1, 2024
  18. hebasto commented at 2:25 pm on May 1, 2024: member
    Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/182.
  19. hebasto removed the label Needs CMake port on May 1, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me