Update contrib/debian: proper desktop category and update changelog #2999

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:master changing 2 files +25 −1

TheBlueMatt commented at 6:13 PM on September 15, 2013: member

No description provided.
TheBlueMatt commented at 6:15 PM on September 15, 2013: member

(Note that this only works for the 0.8.X branch, the build files need rewritten for autotools, but Ill do that when 0.9 is released/rc'd)
TheBlueMatt commented at 6:22 PM on September 15, 2013: member

Oh, and threw in commit to remove the annoying "warning: typedef ‘Char_type’ locally defined but not used [-Wunused-local-typedefs]" warnings while I was at it
prusnak commented at 6:38 PM on September 15, 2013: contributor
+1. I carry the same desktop file patch for openSUSE packages.

Also don't use absolute paths in executable/icon file and no file extension for icon. (If these are in standard paths - and they are - the desktop environment will find them).
```
-Exec=/usr/bin/bitcoin-qt %u
+Exec=bitcoin-qt %u
-Icon=/usr/share/pixmaps/bitcoin128.png
+Icon=bitcoin128
```
sipa commented at 9:22 PM on September 17, 2013: member

@TheBlueMatt The typedef remove is being bikeshedded in #2980, so please don't duplicate it here.

Also, if this only works on 0.8.5, why is this being pullrequested into master?
Update contrib/debian: proper desktop category and update changelog 9085c8c7c3
TheBlueMatt commented at 2:43 AM on September 18, 2013: member

Heh, can I vote for red? I prefer red bikesheds over all other colors. Because contrib/debian is always out-of-sync and I usually update it on here after upload when something other than version numbers change. The 0.9 update will probably come after 0.9 releases when i get a chance to code it up.
BitcoinPullTester commented at 3:46 AM on September 18, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9085c8c7c3e1223349151281130f92dc7df8bd62 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
prusnak commented at 9:30 AM on September 18, 2013: contributor

@TheBlueMatt please also include suggested changes from my comment above (icon+executable in desktop file).
sipa commented at 2:01 PM on September 29, 2013: member

I'm not very familiar with this, but @prusnak's request seems reasonable.
gavinandresen referenced this in commit d922c85716 on Oct 4, 2013
gavinandresen merged this on Oct 4, 2013
gavinandresen closed this on Oct 4, 2013
TheBlueMatt commented at 6:10 AM on December 28, 2013: member

@prusnak Fixed the paths with the 0.8.6 upload, pull req of the new changes at #3468
Bushstar referenced this in commit dff2c851d5 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors