depends: fix Qt to not use `-q` with `ar` #30004

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:more_standard_ar changing 3 files +17 −2

fanquake commented at 11:16 am on April 30, 2024: member

BusyBox ar doesn’t implement q, so replace the Qt usage of ar cqs with ar cs, which should work properly everywhere. Played around with making this work a different way, but couldn’t seem to make it work properly. Open to other working suggestions (our other AR substitution still works correctly, it’s just this single qmake bootstrap build invocation that is an issue.
DrahtBot commented at 11:16 am on April 30, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Build system on Apr 30, 2024
fanquake removed the label Build system on Apr 30, 2024
fanquake added the label DrahtBot Guix build requested on Apr 30, 2024
DrahtBot added the label CI failed on Apr 30, 2024
fanquake marked this as a draft on Apr 30, 2024
depends: fix Qt to not use -q with ar
This means we can properly use BusyBox
00393da37a
ci: remove workaround for BusyBox ar
No-longer required after the previous commit.
4d41dbb480
fanquake force-pushed on Apr 30, 2024
fanquake closed this on Apr 30, 2024

DrahtBot commented at 8:50 pm on April 30, 2024: contributor

File	commit 15f696b454047f5dafc3c95e36fcd677c1901de9(master)	commit a12092c2922295bc3511634d5c7dde41f20c6455(master and this pull)
SHA256SUMS.part	`d6f9b6e7f1456046...`	`e282ca14bd3208a7...`
*-aarch64-linux-gnu-debug.tar.gz	`51b13650a88800de...`	`e64eb577eaab6a96...`
*-aarch64-linux-gnu.tar.gz	`27f11450376e4415...`	`ea2c16b06c8a1ca4...`
*-arm-linux-gnueabihf-debug.tar.gz	`6078944ea2e49473...`	`33e80327d18ffbc5...`
*-arm-linux-gnueabihf.tar.gz	`626b46773c22b62a...`	`34ef2a5bf9332f2b...`
*-arm64-apple-darwin-unsigned.tar.gz	`576ee3ecc0fff924...`
*-arm64-apple-darwin-unsigned.zip	`ea6c140c4828dfde...`
*-arm64-apple-darwin.tar.gz	`1e83f7d707627262...`
*-powerpc64-linux-gnu-debug.tar.gz	`caa312db1c78817d...`	`71c7f4b6e9236cac...`
*-powerpc64-linux-gnu.tar.gz	`a8bc08fb3bfb2a8f...`	`368d454abe0d5446...`
*-riscv64-linux-gnu-debug.tar.gz	`c726d11210f6cd58...`	`1d9e839f9df2bd54...`
*-riscv64-linux-gnu.tar.gz	`02159eb4a52633a5...`	`d78a1ddd05d8e946...`
*-x86_64-apple-darwin-unsigned.tar.gz	`5da5bc4332d8220a...`
*-x86_64-apple-darwin-unsigned.zip	`a5d3fe80418adda0...`
*-x86_64-apple-darwin.tar.gz	`9b5d48531af829db...`
*-x86_64-linux-gnu-debug.tar.gz	`042a22b90aa6261f...`	`9f607c20017caf8b...`
*-x86_64-linux-gnu.tar.gz	`e713f30040024e7a...`	`f0ffc0072646c65b...`
*.tar.gz	`87be91e4ea0a97f5...`	`b9884d74f11a6a85...`
guix_build.log	`90f1ba404d24a0cb...`	`8056cff218457396...`
guix_build.log.diff		`31a1e95267872996...`

depends: fix Qt to not use -q with ar #30004