refactor, test: Always initialize pointer #30026

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240502-msvc-c4703 changing 2 files +4 −8
  1. hebasto commented at 10:11 pm on May 2, 2024: member

    This change fixes MSVC warning C4703.

    All DisableSpecificWarnings dropped from test_bitcoin.vcxproj as all remained are inherited from common.init.vcxproj.

    Required to simplify warning suppression porting to the CMake-based build system.

  2. refactor, test: Always initialize pointer
    This change fixes MSVC warning C4703.
    See: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4703
    
    All `DisableSpecificWarnings` dropped from `test_bitcoin.vcxproj` as all
    remained are inherited from `common.init.vcxproj`.
    bd2de7ac59
  3. DrahtBot commented at 10:11 pm on May 2, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, sipsorcery, ryanofsky

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. hebasto commented at 10:14 pm on May 2, 2024: member
    cc @jamesob as a test author
  5. hebasto added the label Tests on May 2, 2024
  6. maflcko commented at 6:58 am on May 3, 2024: member
    utACK bd2de7ac591d7704b79304089ad1fb57e085da8b
  7. hebasto commented at 7:17 am on May 3, 2024: member
  8. sipsorcery commented at 8:12 am on May 3, 2024: member
    utACK bd2de7ac591d7704b79304089ad1fb57e085da8b.
  9. ryanofsky approved
  10. ryanofsky commented at 1:54 pm on May 3, 2024: contributor
    Code review ACK bd2de7ac591d7704b79304089ad1fb57e085da8b
  11. ryanofsky merged this on May 3, 2024
  12. ryanofsky closed this on May 3, 2024

  13. hebasto deleted the branch on May 3, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me