This change fixes MSVC warning C4703.
All DisableSpecificWarnings dropped from test_bitcoin.vcxproj as all remained are inherited from common.init.vcxproj.
Required to simplify warning suppression porting to the CMake-based build system.
refactor, test: Always initialize pointer #30026
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240502-msvc-c4703 changing 2 files +4 −8-
hebasto commented at 10:11 PM on May 2, 2024: member
-
bd2de7ac59
refactor, test: Always initialize pointer
This change fixes MSVC warning C4703. See: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4703 All `DisableSpecificWarnings` dropped from `test_bitcoin.vcxproj` as all remained are inherited from `common.init.vcxproj`.
-
DrahtBot commented at 10:11 PM on May 2, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko, sipsorcery, ryanofsky If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
- hebasto added the label Tests on May 2, 2024
-
maflcko commented at 6:58 AM on May 3, 2024: member
utACK bd2de7ac591d7704b79304089ad1fb57e085da8b
-
hebasto commented at 7:17 AM on May 3, 2024: member
cc @sipsorcery
-
sipsorcery commented at 8:12 AM on May 3, 2024: contributor
utACK bd2de7ac591d7704b79304089ad1fb57e085da8b.
- ryanofsky approved
-
ryanofsky commented at 1:54 PM on May 3, 2024: contributor
Code review ACK bd2de7ac591d7704b79304089ad1fb57e085da8b
- ryanofsky merged this on May 3, 2024
- ryanofsky closed this on May 3, 2024
- hebasto deleted the branch on May 3, 2024
- hebasto referenced this in commit 0be9840c1e on May 4, 2024
- bitcoin locked this on May 3, 2025
