jonatack
commented at 4:46 am on May 11, 2024:
member
Addnode peers connected to us via the cjdns network are currently not detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false. This causes the following issues:
RPC getaddednodeinfo incorrectly shows them as not connected
CConnman::ThreadOpenAddedConnections() continually retries to connect them
Fix the issue and add a unit regression test. Extracted from #28248. Suggest running the test with:
p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo()
Addnode (manual) peers connected to us via the cjdns network are currently not
detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false.
This causes the following issues:
- RPC `getaddednodeinfo` incorrectly shows them as not connected
- CConnman::ThreadOpenAddedConnections() continually retries to connect them
684da97070
test: add GetAddedNodeInfo() CJDNS regression unit testd0b047494c
DrahtBot
commented at 4:46 am on May 11, 2024:
contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
mzumsande
commented at 9:41 pm on May 14, 2024:
contributor
utACKd0b047494c28381942c09d0cca45baa323bfcffc
brunoerg approved
brunoerg
commented at 9:34 am on May 15, 2024:
contributor
crACKd0b047494c28381942c09d0cca45baa323bfcffc
pinheadmz approved
pinheadmz
commented at 6:05 pm on May 15, 2024:
member
ACKd0b047494c28381942c09d0cca45baa323bfcffc
Built and tested on arm/macOS. It’s a simple fix to recognize CJDNS addresses in GetAddedNodeInfo(). Otherwise CService::IsValid() will fail because the CJDNS prefix is in a reserved range. Confirmed the test fails on master and passes with the branch.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-12-11 06:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me