[27.x] Backports and rc1

fanquake commented at 4:22 am on May 13, 2024: member

Backports:

Bump to 27.1rc1.

gui: fix create unsigned transaction fee bump

Github-Pull: https://github.com/bitcoin-core/gui/pull/812
Rebased-From: 671b7a32516d62e1e79393ded4b45910bd08010a

d1289a1300

gui: don't permit port in proxy IP option

Fixes: #809

Previously it was possible through the GUI to enter an IP address:port
into the "Proxy IP" configuration box. After the node was restarted the
errant setting would prevent the node starting back up until manually
removed from settings.json.

Github-Pull: https://github.com/bitcoin-core/gui/pull/813
Rebased-From: 10c5275ba4532fb1bf54057d2f61fc35b51f1e85

dedf319b08

fanquake added this to the milestone 27.1 on May 13, 2024

DrahtBot commented at 4:23 am on May 13, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	stickies-v, willcl-ark, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Backport on May 13, 2024

DrahtBot added the label CI failed on May 13, 2024

rpc: move UniValue in blockToJSON

Without explicitly declaring the move, these UniValues get copied,
causing increased memory usage. Fix this by explicitly moving the
UniValue objects.

Used by `rest_block` and `getblock` RPC.

Github-Pull: #30094
Rebased-From: b77bad309e92f176f340598eec056eb7bff86f5f

0ba11cf908

fanquake force-pushed on May 14, 2024

DrahtBot removed the label CI failed on May 14, 2024

hebasto approved

hebasto commented at 10:13 am on May 14, 2024: member

ACK 9867e72b995e4a838c8e8e0feb159a9bdee8b76f, I have reproduced backporting locally.

jonatack commented at 9:41 pm on May 14, 2024: contributor

Propose #30085 if merged in time.

crypto: disable asan for sha256_sse4 with clang and -O0

Clang is unable to compile the Transform function for that combination of
options.

Github-Pull: #30097
Rebased-From: 141df0a28810470e53fdbc6d32d3cb4020fe3ca1

3c26058da2

fanquake force-pushed on May 16, 2024

p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo()

Addnode (manual) peers connected to us via the cjdns network are currently not
detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false.

This causes the following issues:

- RPC `getaddednodeinfo` incorrectly shows them as not connected

- CConnman::ThreadOpenAddedConnections() continually retries to connect them

Github-Pull: #30085
Rebased-From: 684da9707040ce25d95b2954eda50b811136d92c

9cdb9edfb8

fanquake force-pushed on May 22, 2024

fanquake marked this as ready for review on May 22, 2024

fanquake renamed this:
~~[27.x] Backports and probably finalize~~
[27.x] Backports and rc1
on May 22, 2024

test: add GetAddedNodeInfo() CJDNS regression unit test

Github-Pull: #30085
Rebased-From: d0b047494c28381942c09d0cca45baa323bfcffc

31adcfa171

depends: Fetch miniupnpc sources from an alternative website

The https://miniupnp.tuxfamily.org website is unavailable now.

Github-Pull: #30151
Rebased-From: 21b8a14d37c19ce292d5529597e0d52338db48a9

77b2321ca0

fanquake force-pushed on May 23, 2024

windeploy: Renew certificate

Github-Pull: #30149
Rebased-From: 9f4ff1e9659597307f62510f1885ad8da3a1d9a3

423bd6dc68

fanquake force-pushed on May 23, 2024

fanquake requested review from stickies-v on May 24, 2024

fanquake requested review from willcl-ark on May 24, 2024

willcl-ark approved

willcl-ark commented at 11:52 am on May 24, 2024: member

ACK cb6def3855427b613357696ba16a431c7964dbcc

Reviewed that all backports were unmodified, and that associated PR #’s match.

Lightly reviewed release notes and manpage and they look good to me.

DrahtBot requested review from hebasto on May 24, 2024

in doc/release-notes.md:6 in cb6def3855 outdated

0@@ -1,6 +1,9 @@
1-Bitcoin Core version 27.x is now available from:
2+27.1rc1 Release Notes
3+=====================
4 
5-  <https://bitcoincore.org/bin/bitcoin-core-27.x/>
6+Bitcoin Core version 27.1 is now available from:
7+
8+  <https://bitcoincore.org/bin/bitcoin-core-27.1/>

stickies-v commented at 1:17 pm on May 24, 2024:

0Bitcoin Core version 27.1rc1 is now available from:
1
2  <https://bitcoincore.org/bin/bitcoin-core-27.1/test.rc1/>

stickies-v commented at 10:30 am on May 28, 2024:

nit but text is not updated to “271.rc1” in latest force push (link is fine now)

stickies-v commented at 1:24 pm on May 24, 2024: contributor

ACK cb6def3855427b613357696ba16a431c7964dbcc modulo small release notes fix

All backport commits are clean, except for:

77b2321ca03dcbd5f77060510dc8a19e7f4fdfa2 backported from 21b8a14d37c19ce292d5529597e0d52338db48a9: version bumped in https://github.com/bitcoin/bitcoin/pull/29707/ - LGTM

No diff with my local manpage generation.

hebasto approved

hebasto commented at 11:43 am on May 27, 2024: member

ACK cb6def3855427b613357696ba16a431c7964dbcc.

Feel free to update translations with python3 ../bitcoin-maintainer-tools/update-translations.py or cherry-pick the https://github.com/hebasto/bitcoin/commit/c9c42cc5e9f5740c4700b18a28d809db53880db2 commit.

qt: 27.1rc1 translations update 80032d6917

fanquake force-pushed on May 28, 2024

hebasto approved

hebasto commented at 9:44 am on May 28, 2024: member

re-ACK f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4,

DrahtBot requested review from stickies-v on May 28, 2024

DrahtBot requested review from willcl-ark on May 28, 2024

willcl-ark approved

willcl-ark commented at 10:18 am on May 28, 2024: member

reACK f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4

Didn’t review the newly-added individual translations, but apart from that changes LGTM.

stickies-v approved

stickies-v commented at 10:33 am on May 28, 2024: contributor

re-ACK f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4, I’m getting the same translation update results as in 80032d691702f1e5eccb27571066bfc9b2415742

doc: update release-notes.md for 27.1 9b4640c4be

build: bump version to 27.1rc1 9e919072bd

doc: update manual pages for 27.1rc1 22701a4346

fanquake force-pushed on May 28, 2024

stickies-v commented at 5:47 pm on May 28, 2024: contributor

re-ACK 22701a43464ab27ea83c8b49e2732ee647909a10

DrahtBot requested review from hebasto on May 28, 2024

DrahtBot requested review from willcl-ark on May 28, 2024

willcl-ark commented at 7:52 am on May 29, 2024: member

reACK 22701a43464ab27ea83c8b49e2732ee647909a10

on range-diff https://github.com/bitcoin/bitcoin/compare/f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4..22701a43464ab27ea83c8b49e2732ee647909a10

hebasto approved

hebasto commented at 7:54 am on May 29, 2024: member

re-ACK 22701a43464ab27ea83c8b49e2732ee647909a10.

fanquake merged this on May 29, 2024

fanquake closed this on May 29, 2024

fanquake deleted the branch on May 29, 2024

[27.x] Backports and rc1 #30092

Code Coverage

Reviews