refactor: Use type-safe time in txorphanage #30170

1. 
   maflcko commented at 12:27 PM on May 24, 2024: member

   This allows to remove manual conversions like multiplication by 60, and uses a type-safe type instead of a raw int64_t.

2. refactor: Use type-safe time in txorphanage fa6d4891c7
3. 
   DrahtBot commented at 12:27 PM on May 24, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	epiccurious, dergoegge, brunoerg
   Concept ACK	stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30186 (fuzz: increase txorphan harness stability by marcofleon)
   • #29641 (scripted-diff: Use LogInfo/LogDebug over LogPrintf/LogPrint by maflcko)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Refactoring on May 24, 2024
5. 
   stickies-v commented at 1:28 PM on May 24, 2024: contributor

   Concept ACK

6. 
   epiccurious commented at 5:24 PM on May 24, 2024: contributor

   utACK fa6d4891c7815025ab1cd58d0906466af31bb648.

7. DrahtBot requested review from stickies-v on May 24, 2024
8. in src/txorphanage.cpp:122 in fa6d4891c7

    118 | @@ -118,12 +119,12 @@ void TxOrphanage::LimitOrphans(unsigned int max_orphans, FastRandomContext& rng)
    119 |      LOCK(m_mutex);
    120 |  
    121 |      unsigned int nEvicted = 0;
    122 | -    static int64_t nNextSweep;
    123 | -    int64_t nNow = GetTime();
    124 | +    static NodeSeconds nNextSweep;
   

   ---

   ---

   

   dergoegge commented at 8:49 AM on May 28, 2024:

   Out of scope for this PR but this global is probably the source of instability in the txorphan harness.

9. dergoegge approved
10. 
    dergoegge commented at 8:51 AM on May 28, 2024: member

    Code review ACK fa6d4891c7815025ab1cd58d0906466af31bb648

11. brunoerg approved
12. 
    brunoerg commented at 5:46 PM on May 28, 2024: contributor

    utACK fa6d4891c7815025ab1cd58d0906466af31bb648

13. fanquake merged this on May 29, 2024
14. fanquake closed this on May 29, 2024

    ---

15. maflcko deleted the branch on May 29, 2024
16. Fabcien referenced this in commit a53da93764 on Jul 19, 2024
17. roqqit referenced this in commit e0c985c777 on Aug 1, 2024
18. bitcoin locked this on May 29, 2025

Review Requested
stickies-v