Fix typos in 36 files | Almost only documentation #30188

1. 
   Sajjon commented at 8:03 am on May 29, 2024: none

   Fix typos in 36 files
2. Fix typos in 36 files. aa135553c0
3. 
   DrahtBot commented at 8:03 am on May 29, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. in contrib/tracing/p2p_monitor.py:173 in aa135553c0

   169@@ -170,7 +170,7 @@ def loop(screen, bpf, peers):
   170     info_panel = panel.new_panel(win)
   171     info_panel.hide()
   172 
   173-    ROWS_AVALIABLE_FOR_LIST = curses.LINES - 5
   174+    ROWS_AVAILABLE_FOR_LIST = curses.LINES - 5
   

   ---

   ---

   

   Sajjon commented at 8:04 am on May 29, 2024:

   rg "ROWS_AVALIABLE_FOR_LIST" shows empty, so all relevant references have been renamed.
5. in doc/Doxyfile.in:1488 in aa135553c0

   1484@@ -1485,7 +1485,7 @@ EXT_LINKS_IN_WINDOW    = NO
   1485 
   1486 FORMULA_FONTSIZE       = 10
   1487 
   1488-# Use the FORMULA_TRANPARENT tag to determine whether or not the images
   1489+# Use the FORMULA_TRANSPARENT tag to determine whether or not the images
   

   ---

   ---

   

   Sajjon commented at 8:05 am on May 29, 2024:

   The config is named FORMULA_TRANSPARENT so this is purely a typo correction, no logic effect.
6. in src/qt/clientmodel.cpp:263 in aa135553c0

   259@@ -260,7 +260,7 @@ void ClientModel::subscribeToCoreSignals()
   260         }));
   261     m_event_handlers.emplace_back(m_node.handleBannedListChanged(
   262         [this]() {
   263-            qDebug() << "ClienModel: Requesting update for peer banlist";
   264+            qDebug() << "ClientModel: Requesting update for peer banlist";
   

   ---

   ---

   

   Sajjon commented at 8:06 am on May 29, 2024:

   Seems to only be a debug print, so should be ok?
7. in test/functional/wallet_backup.py:119 in aa135553c0

   115@@ -116,7 +116,7 @@ def erase_three(self):
   116     def restore_invalid_wallet(self):
   117         node = self.nodes[3]
   118         invalid_wallet_file = self.nodes[0].datadir_path / 'invalid_wallet_file.bak'
   119-        open(invalid_wallet_file, 'a', encoding="utf8").write('invald wallet')
   120+        open(invalid_wallet_file, 'a', encoding="utf8").write('invalid wallet')
   

   ---

   ---

   

   Sajjon commented at 8:07 am on May 29, 2024:

   This is just a test, so should be OK to correct typo in the written contents to file test file?
8. 
   fanquake commented at 8:07 am on May 29, 2024: member

   Thanks, however most of these are in upstream code (subtrees, macros, Doxygen config), or code we aren’t going to change (like the release notes). You’ll need to remove all of those changes, and then also write a proper commit message.
9. 
   Sajjon commented at 8:09 am on May 29, 2024: none

   Thanks, however most of these are in upstream code (subtrees, macros, Doxygen config), or code we aren’t going to change (like the release notes). You’ll need to remove all of those changes, and then also write a proper commit message.

   👍 thx! Will give it another go later tonight. Any suggestion on what a “proper commit message” would be?

10. 
    fanquake commented at 8:12 am on May 29, 2024: member

    Any suggestion on what a “proper commit message” would be?

    https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md.

11. fanquake marked this as a draft on May 29, 2024
12. 
    glozow commented at 8:22 am on May 29, 2024: member

    Thanks for your interest in contributing. Maybe take a look at https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#pull-request-philosophy.

    Fwiw I think editing archived release notes (especially changing the names of pull requests) just makes them inaccurate. I think this should be closed.

13. DrahtBot added the label Needs rebase on May 29, 2024
14. 
    DrahtBot commented at 9:41 am on May 29, 2024: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

15. DrahtBot added the label CI failed on May 29, 2024
16. 
    DrahtBot commented at 10:44 pm on May 29, 2024: contributor

    🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.

    Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    Leave a comment here, if you need help tracking down a confusing failure.

    Debug: https://github.com/bitcoin/bitcoin/runs/25540433882

17. 
    stickies-v commented at 3:08 pm on May 30, 2024: contributor

    I think this should be closed.

    Agreed. Concept NACK.

18. achow101 closed this on May 31, 2024

    ---

Contributors
Sajjon DrahtBot fanquake glozow stickies-v

Labels
Needs rebase CI failed