refactor: policy: Pass kernel::MemPoolOptions to IsStandard[Tx] rather than long list of individual options #30232

1. 
   luke-jr commented at 2:21 pm on June 5, 2024: member
2. refactor: policy: Pass kernel::MemPoolOptions to IsStandard[Tx] rather than long list of individual options d4c3c2e9ae
3. 
   DrahtBot commented at 2:21 pm on June 5, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30239 (Ephemeral Anchors, take 2 by instagibbs)
   • #29942 (Remove redundant -datacarrier option by vostrnad)
   • #29309 (Add a -permitbarepubkey option by vostrnad)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Refactoring on Jun 5, 2024
5. 
   luke-jr commented at 2:22 pm on June 5, 2024: member

   @kristapsk @jonatack @achow101
6. 
   fanquake commented at 3:16 pm on June 5, 2024: member

   https://github.com/bitcoin/bitcoin/pull/30232/checks?check_run_id=25845075037:

   0A new circular dependency in the form of "kernel/mempool_options -> policy/policy -> kernel/mempool_options" appears to have been introduced.
   

7. DrahtBot added the label CI failed on Jun 5, 2024
8. 
   DrahtBot commented at 4:27 pm on June 5, 2024: contributor

   🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.

   Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   Leave a comment here, if you need help tracking down a confusing failure.

   Debug: https://github.com/bitcoin/bitcoin/runs/25845075037

9. 
   luke-jr commented at 5:06 pm on June 5, 2024: member

   A new circular dependency in the form of “kernel/mempool_options -> policy/policy -> kernel/mempool_options” appears to have been introduced.

   How do you propose resolving this? It’s not really a circular dependency, just equivocated as such due to the CI test stripping file extensions, but maybe there’s a better approach that just fixing CI?

10. 
    glozow commented at 12:38 pm on June 6, 2024: member

    Mind providing some motivation for the refactor? PR description is empty
11. 
    luke-jr commented at 6:33 pm on June 12, 2024: member

    Besides making the code cleaner, I’m hoping to get to a point where it’s practical to fix the remaining vsize bugs.

Contributors
luke-jr DrahtBot fanquake glozow

Labels
Refactoring CI failed