Revert "contrib: macdeploy: monkey-patch gen-sdk to be deterministic" #30282

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_python_38_monkey_patching changing 1 files +0 −15
  1. fanquake commented at 1:02 PM on June 13, 2024: member

    This reverts commit ba30a5407e065e9d6dd037351e83f56a43f38f19.

    We no-longer support Python 3.8, so remove the monkey patching.

  2. Revert "contrib: macdeploy: monkey-patch gen-sdk to be deterministic"
    This reverts commit ba30a5407e065e9d6dd037351e83f56a43f38f19.
    b03a45b13e
  3. DrahtBot commented at 1:02 PM on June 13, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto
    Concept ACK prusnak

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. hebasto approved
  5. hebasto commented at 9:01 AM on June 16, 2024: member

    ACK b03a45b13e4e33b044cae6c97a6d608f6f3d43f3, I have reviewed the code and it looks OK.

  6. hebasto commented at 9:03 AM on June 16, 2024: member
  7. maflcko added the label DrahtBot Guix build requested on Jun 17, 2024
  8. DrahtBot commented at 6:38 PM on June 17, 2024: contributor

    <!--9cd9c72976c961c55c7acef8f6ba82cd-->

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit 2c79abc7ad4850e9e3ba32a04c530155cda7f980<br>(master) commit abe54eabf9e413f4eea7387e606d9fe6823a49ae<br>(master and this pull)
    SHA256SUMS.part 811c57372dd49ef8... 96fbadd70d5dca1a...
    *-aarch64-linux-gnu-debug.tar.gz 1cfca23c68ecc71c... ce17c6df903e47c4...
    *-aarch64-linux-gnu.tar.gz 3a8caca3dcca2f33... 99d5cf37a06a3982...
    *-arm-linux-gnueabihf-debug.tar.gz 545a4f176711f4e8... 4c6080cb3e718ada...
    *-arm-linux-gnueabihf.tar.gz f2750a12d8f07833... 46401811d87b4564...
    *-arm64-apple-darwin-unsigned.tar.gz 3aab2191eff27e89... b82078993b260212...
    *-arm64-apple-darwin-unsigned.zip b09fa25325db9379... 3e5227d283777621...
    *-arm64-apple-darwin.tar.gz ac66d81d652a97a4... f1f0eb8cd5a644f1...
    *-powerpc64-linux-gnu-debug.tar.gz 14321e974a67f46e... 6082f92fe9b25b04...
    *-powerpc64-linux-gnu.tar.gz 027c012c8725b54f... 0761b1d555006c91...
    *-riscv64-linux-gnu-debug.tar.gz a7523fc3a8e483a4... b94a8a0f5ce8316f...
    *-riscv64-linux-gnu.tar.gz 80fd906585bde575... f15cc21ff1d9fabd...
    *-x86_64-apple-darwin-unsigned.tar.gz 8454031bc1a57095... 990914aafd552340...
    *-x86_64-apple-darwin-unsigned.zip a50b10cc4eafd272... bc709aadacfa0ac8...
    *-x86_64-apple-darwin.tar.gz 3b621ad686289d6f... b158a2c95e082041...
    *-x86_64-linux-gnu-debug.tar.gz 88e7ecfd4e4d4d98... 36468ef62947473f...
    *-x86_64-linux-gnu.tar.gz 291588ed8f4c6393... 7583db38f12a1215...
    *.tar.gz d891cac17d192d37... f6388dd7313bff7d...
    guix_build.log 79ccd2faaead931d... d5a90472c463671f...
    guix_build.log.diff c1de52fac6bf2430...
  9. DrahtBot removed the label DrahtBot Guix build requested on Jun 17, 2024
  10. prusnak approved
  11. prusnak commented at 9:03 PM on June 17, 2024: contributor

    utACK

  12. fanquake merged this on Jun 18, 2024
  13. fanquake closed this on Jun 18, 2024

  14. fanquake deleted the branch on Jun 18, 2024
  15. PastaPastaPasta referenced this in commit 6c9dcd8d42 on Feb 17, 2025
  16. PastaPastaPasta referenced this in commit 2461a45c20 on Feb 19, 2025
  17. PastaPastaPasta referenced this in commit 3f2d388b01 on Feb 20, 2025
  18. PastaPastaPasta referenced this in commit da11d29986 on Feb 20, 2025
  19. PastaPastaPasta referenced this in commit 456add22c3 on Feb 21, 2025
  20. bitcoin locked this on Jun 18, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me