build: Drop redundant sys/sysctl.h header check #30327

1. 
   hebasto commented at 1:29 pm on June 24, 2024: member

   The AC_CHECK_HEADERS macro defines HAVE_SYS_SYSCTL_H if the sys/sysctl.h header is found. However, in the source code, this header is guarded by HAVE_SYSCTL and HAVE_SYSCTL_ARND macros, which have their own checks. Since HAVE_SYS_SYSCTL_H is not used, we can skip the AC_CHECK_HEADERS(... sys/sysctl.h ...) check.
2. build: Drop redundant `sys/sysctl.h` header check

   The `AC_CHECK_HEADERS` macro defines `HAVE_SYS_SYSCTL_H` if the
   `sys/sysctl.h` header is found. However, in the source code, this header
   is guarded by `HAVE_SYSCTL` and `HAVE_SYSCTL_ARND` macros, which have
   their own checks. Since `HAVE_SYS_SYSCTL_H` is not used, we can skip the
   `AC_CHECK_HEADERS(... sys/sysctl.h ...)` check.

   c0b5ea5901
3. hebasto added the label Build system on Jun 24, 2024
4. hebasto added the label Needs CMake port on Jun 24, 2024
5. 
   DrahtBot commented at 1:29 pm on June 24, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	laanwj, fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. 
   laanwj commented at 9:00 am on June 26, 2024: member

   ACK c0b5ea5901d0ed005bca345e5b2de8a502f6af75 verified there is no HAVE_SYS_SYSCTL_H in the code, nor ever was, while it was introduced at the same time as HAVE_SYSCTL
7. fanquake approved
8. 
   fanquake commented at 2:22 pm on June 26, 2024: member

   ACK c0b5ea5901d0ed005bca345e5b2de8a502f6af75 - we could got the other way, and add nested #defs, but that doesn’t seem worthwhile.
9. fanquake merged this on Jun 26, 2024
10. fanquake closed this on Jun 26, 2024

    ---

11. hebasto deleted the branch on Jun 26, 2024

Contributors
hebasto DrahtBot laanwj fanquake

Labels
Build system Needs CMake port