The AC_CHECK_HEADERS macro defines HAVE_SYS_SYSCTL_H if the sys/sysctl.h header is found. However, in the source code, this header is guarded by HAVE_SYSCTL and HAVE_SYSCTL_ARND macros, which have their own checks. Since HAVE_SYS_SYSCTL_H is not used, we can skip the AC_CHECK_HEADERS(... sys/sysctl.h ...) check.
build: Drop redundant `sys/sysctl.h` header check #30327
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240624-sysctl changing 1 files +1 −1-
hebasto commented at 1:29 PM on June 24, 2024: member
-
c0b5ea5901
build: Drop redundant `sys/sysctl.h` header check
The `AC_CHECK_HEADERS` macro defines `HAVE_SYS_SYSCTL_H` if the `sys/sysctl.h` header is found. However, in the source code, this header is guarded by `HAVE_SYSCTL` and `HAVE_SYSCTL_ARND` macros, which have their own checks. Since `HAVE_SYS_SYSCTL_H` is not used, we can skip the `AC_CHECK_HEADERS(... sys/sysctl.h ...)` check.
- hebasto added the label Build system on Jun 24, 2024
- hebasto added the label Needs CMake port on Jun 24, 2024
-
DrahtBot commented at 1:29 PM on June 24, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
laanwj commented at 9:00 AM on June 26, 2024: member
ACK c0b5ea5901d0ed005bca345e5b2de8a502f6af75 verified there is no
HAVE_SYS_SYSCTL_Hin the code, nor ever was, while it was introduced at the same time asHAVE_SYSCTL - fanquake approved
-
fanquake commented at 2:22 PM on June 26, 2024: member
ACK c0b5ea5901d0ed005bca345e5b2de8a502f6af75 - we could got the other way, and add nested #defs, but that doesn't seem worthwhile.
- fanquake merged this on Jun 26, 2024
- fanquake closed this on Jun 26, 2024
- hebasto deleted the branch on Jun 26, 2024
-
hebasto commented at 7:24 AM on July 14, 2024: member
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.
- hebasto removed the label Needs CMake port on Jul 14, 2024
- PastaPastaPasta referenced this in commit a9eb86f7ad on Apr 22, 2025
- PastaPastaPasta referenced this in commit e3c3a110b3 on Apr 22, 2025
- PastaPastaPasta referenced this in commit 4a6dc39d69 on Apr 23, 2025
- bitcoin locked this on Jul 14, 2025
Labels