Update libsecp256k1 subtree to latest master #30334

fanquake commented at 11:16 AM on June 25, 2024: member

Updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/f473c959f08edcb73669142f872d2189950bc54a. This includes a number of CMake related changes, including one that prevents CMake from segfaulting when we were configuring the subtree. A number of these changes have come from the review/discussion in https://github.com/hebasto/bitcoin/pull/192:

Also includes:

DrahtBot commented at 11:16 AM on June 25, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan, hebasto, real-or-random, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

fanquake commented at 11:17 AM on June 25, 2024: member

cc @real-or-random. Depending on whether https://github.com/bitcoin-core/secp256k1/pull/1535 goes in, we could also pull that, but just a cleanup.

hebasto approved

hebasto commented at 11:26 AM on June 25, 2024: member

ACK 4c67e14cacef1903800b4cf4e32a12922d36025f, I've got a zero diff with my local branch, which reproduces the subtree update.

hebasto added the label Needs CMake port on Jun 25, 2024

Squashed 'src/secp256k1/' changes from 06bff6dec8..4af241b320

4af241b320 Merge bitcoin-core/secp256k1#1535: build: Replace hardcoded "auto" value with default one
f473c959f0 Merge bitcoin-core/secp256k1#1543: cmake: Do not modify build types when integrating by downstream project
d403eea484 Merge bitcoin-core/secp256k1#1546: cmake: Rename `SECP256K1_LATE_CFLAGS` and switch to Bitcoin Core's approach
d7ae25ce6f Merge bitcoin-core/secp256k1#1550: fix: typos in secp256k1.c
0e2fadb20c fix: typos in secp256k1.c
69b2192ad4 Merge bitcoin-core/secp256k1#1545: cmake: Do not set `CTEST_TEST_TARGET_ALIAS`
5dd637f3cf Merge bitcoin-core/secp256k1#1548: README: mention ellswift module
7454a53736 README: mention ellswift module
4706be2cd0 cmake: Reimplement `SECP256K1_APPEND_CFLAGS` using Bitcoin Core approach
c2764dbb99 cmake: Rename `SECP256K1_LATE_CFLAGS` to `SECP256K1_APPEND_CFLAGS`
f87a3589f4 cmake: Do not set `CTEST_TEST_TARGET_ALIAS`
158f9e5eae cmake: Do not modify build types when integrating by downstream project
35c0fdc86b Merge bitcoin-core/secp256k1#1529: cmake: Fix cache issue when integrating by downstream project
4392f0f717 Merge bitcoin-core/secp256k1#1533: tests: refactor: tidy up util functions (#1491)
bedffd53d8 Merge bitcoin-core/secp256k1#1488: ci: Add native macOS arm64 job
4b8d5eeacf Merge bitcoin-core/secp256k1#1532: cmake: Disable eager MSan in ctime_tests
f55703ba49 autotools: Delete unneeded compiler test
396e885886 autotools: Align MSan checking code with CMake's implementation
abde59f52d cmake: Report more compiler details in summary
7abf979a43 cmake: Disable `ctime_tests` if build with `-fsanitize=memory`
4d9645bee0 cmake: Remove "AUTO" value of `SECP256K1_ECMULT_GEN_KB` option
a06805ee74 cmake: Remove "AUTO" value of `SECP256K1_ECMULT_WINDOW_SIZE` option
1791f6fce4 Merge bitcoin-core/secp256k1#1517: autotools: Disable eager MSan in ctime_tests
26b94ee92a autotools: Remove "auto" value of `--with-ecmult-gen-kb` option
122dbaeb37 autotools: Remove "auto" value of `--with-ecmult-window` option
e73f6f8fd9 tests: refactor: drop `secp256k1_` prefix from testrand.h functions
0ee7453a99 tests: refactor: add `testutil_` prefix to testutil.h functions
0c6bc76dcd tests: refactor: move `random_` helpers from tests.c to testutil.h
0fef8479be tests: refactor: rename `random_field_element_magnitude` -> `random_fe_magnitude`
59db007f0f tests: refactor: rename `random_group_element_...` -> `random_ge_...`
ebfb82ee2f ci: Add job with -fsanitize-memory-param-retval
e1bef0961c configure: Move "experimental" warning to bottom
55e5d975db autotools: Disable eager MSan in ctime_tests
ec4c002faa cmake: Simplify `PROJECT_IS_TOP_LEVEL` emulation
cae9a7ad14 cmake: Do not set emulated PROJECT_IS_TOP_LEVEL as cache variable
218f0cc93b ci: Add native macOS arm64 job

git-subtree-dir: src/secp256k1
git-subtree-split: 4af241b32099067464e015fa66daac5096206dea

1408944d2e

Update secp256k1 subtree to latest master cc58e958f3

fanquake force-pushed on Jun 25, 2024

fanquake commented at 2:27 PM on June 25, 2024: member

Depending on whether https://github.com/bitcoin-core/secp256k1/pull/1535 goes in, we could also pull that, but just a cleanup.

Incorporated.

TheCharlatan approved

TheCharlatan commented at 2:41 PM on June 25, 2024: contributor

ACK cc58e958f341d2759fbabe5c9d8cc557e17d587f

DrahtBot requested review from hebasto on Jun 25, 2024

real-or-random commented at 2:42 PM on June 25, 2024: contributor

Concept ACK -- this is a particularly harmless update as all changes are in the tests or in the build system or in comments

hebasto approved

hebasto commented at 9:26 PM on June 25, 2024: member

re-ACK cc58e958f341d2759fbabe5c9d8cc557e17d587f.

DrahtBot requested review from real-or-random on Jun 25, 2024

real-or-random approved

real-or-random commented at 9:38 AM on June 26, 2024: contributor

utACK cc58e958f341d2759fbabe5c9d8cc557e17d587f

achow101 commented at 4:25 PM on June 26, 2024: member

ACK cc58e958f341d2759fbabe5c9d8cc557e17d587f

Verified that there is no diff between the subtree and secp master.

achow101 merged this on Jun 26, 2024

achow101 closed this on Jun 26, 2024

fanquake deleted the branch on Jun 26, 2024

hebasto commented at 7:25 AM on July 14, 2024: member

There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

hebasto removed the label Needs CMake port on Jul 14, 2024

bitcoin locked this on Jul 14, 2025