assumeutxo: Remove translated strings added in 30267 #30417

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/nota changing 2 files +13 −13
  1. ryanofsky commented at 4:51 PM on July 9, 2024: contributor

    maflcko pointed out in #30267#pullrequestreview-2155603386 that some error strings were being translated unneccessarily and incorrectly in #30267.

    Switch them to untranslated for now. In the future if we add a GUI feature for loading snapshots, and it seems like it could be possible to trigger some of the errors, they could be translated at that point.

    Also remove a newline in a thrown RPC exception.

  2. assumeutxo: Remove translated strings added in 30267
    MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> pointed out in
    https://github.com/bitcoin/bitcoin/pull/30267#pullrequestreview-2155603386 that
    some error strings were being translated unneccessarily and incorrectly in
    #30267.
    
    Switch them to untranslated for now. In the future if we add a GUI feature for
    loading snapshots, and it seems like it could be possible to trigger some of
    the errors, they could be translated at that point.
    
    Also remove a newline in a thrown RPC exception.
    740b4424a5
  3. DrahtBot commented at 4:51 PM on July 9, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. fanquake commented at 4:51 PM on July 9, 2024: member

    This is also done in #30395.

  5. ryanofsky commented at 6:08 PM on July 9, 2024: contributor

    This is also done in #30395.

    Oh, thanks I missed that. Closing.

  6. ryanofsky closed this on Jul 9, 2024

  7. bitcoin locked this on Jul 9, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me