ci: failure in p2p_v2_misbehaving.py #30419

1. 
   fanquake commented at 8:35 am on July 10, 2024: member

   https://github.com/bitcoin/bitcoin/actions/runs/9864841219/job/27240616054?pr=30410#step:7:5422

    0  node0 2024-07-09T23:09:39.685000Z [net] [net.cpp:1814] [CreateNodeFromAcceptedSocket] [net] connection from 127.0.0.1:53666 accepted 
    1 test  2024-07-09T23:09:39.691000Z TestFramework (INFO): Sending remaining ellswift and garbage which are different from V1_PREFIX. Since a response is 
    2 test  2024-07-09T23:09:39.691000Z TestFramework (INFO): expected now, our custom data_received() function wouldn't result in assertion failure 
    3 test  2024-07-09T23:09:39.691000Z TestFramework (ERROR): Unexpected exception caught during testing 
    4                                   Traceback (most recent call last):
    5                                     File "/home/runner/work/_temp/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
    6                                       self.run_test()
    7                                     File "/home/runner/work/_temp/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_v2_misbehaving.py", line 132, in run_test
    8                                       self.test_earlykeyresponse()
    9                                     File "/home/runner/work/_temp/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_v2_misbehaving.py", line 146, in test_earlykeyresponse
   10                                       peer1.send_raw_message(peer1.v2_state.ellswift_ours[4:] + peer1.v2_state.sent_garbage)
   11                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^
   12                                   TypeError: 'NoneType' object is not subscriptable
   13 test  2024-07-09T23:09:39.694000Z TestFramework (DEBUG): Closing down network thread 
   14 test  2024-07-09T23:09:39.693000Z TestFramework.p2p (DEBUG): sending 2849 bytes of garbage data 
   15 test  2024-07-09T23:09:39.744000Z TestFramework (INFO): Stopping nodes 
   16 test  2024-07-09T23:09:39.744000Z TestFramework.node0 (DEBUG): Stopping node 
   

   Also happened here (#29431 merge): https://github.com/bitcoin/bitcoin/actions/runs/9863848733/job/27237501327#step:7:5424.

2. 
   stratospher commented at 9:43 am on July 10, 2024: contributor

   oh a race condition happened because initiate_v2_handshake() code in p2p_v2_misbehaving.py was simplified. i think a simple wait_until() should fix it. will open a PR.

   EDIT: done in #30420

3. willcl-ark added the label Tests on Jul 10, 2024
4. willcl-ark added the label CI failed on Jul 10, 2024
5. fanquake closed this on Jul 16, 2024

   ---

6. fanquake referenced this in commit d41f4a69e7 on Jul 16, 2024
7. bitcoin locked this on Jul 16, 2025

Contributors
fanquake stratospher

Labels
Tests CI failed