test, refactor: Fix MSVC warning C4101 “unreferenced local variable” #30464

1. 
   hebasto commented at 9:48 pm on July 16, 2024: member

   This PR is split from #30454 and addresses MSVC warning C4101 “unreferenced local variable”. The current MSVC build system in the master branch skips building univalue tests, so it is not affected.

   No behaviour changes.

2. univalue, refactor: Convert indentation tabs to spaces 5d25a82b9a
3. test: Fix MSVC warning C4101 "unreferenced local variable" 44f08786f4
4. 
   DrahtBot commented at 9:48 pm on July 16, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theuni, kevkevinpal, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30454 (build: Introduce CMake-based buid system by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. hebasto added the label Refactoring on Jul 16, 2024
6. hebasto added the label Tests on Jul 16, 2024
7. 
   hebasto commented at 9:51 pm on July 16, 2024: member

   It is a part of upfront PR’ed commits from #30454, as suggested by @fanquake offline.
8. theuni approved
9. 
   theuni commented at 9:57 pm on July 16, 2024: member

   trivial ACK 44f08786f435ed4284d39dc604c2a5fcbde9e602.

   Seems weird to be catching a non-const ref, but it really doesn’t matter here :)

10. 
    kevkevinpal commented at 0:14 am on July 17, 2024: contributor

    utACK 44f0878

    lgtm! seems pretty straight forward

11. 
    maflcko commented at 11:32 am on July 18, 2024: member

    ACK 44f08786f435ed4284d39dc604c2a5fcbde9e602
12. fanquake merged this on Jul 18, 2024
13. fanquake closed this on Jul 18, 2024

    ---

14. hebasto deleted the branch on Jul 18, 2024

Contributors
hebasto DrahtBot theuni kevkevinpal maflcko

Labels
Refactoring Tests