This PR is split from #30454 and addresses MSVC warning C4101 "unreferenced local variable". The current MSVC build system in the master branch skips building univalue tests, so it is not affected.
No behaviour changes.
test, refactor: Fix MSVC warning C4101 "unreferenced local variable" #30464
pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:240716-univalue changing 1 files +7 −7-
hebasto commented at 9:48 PM on July 16, 2024: member
-
univalue, refactor: Convert indentation tabs to spaces 5d25a82b9a
-
test: Fix MSVC warning C4101 "unreferenced local variable" 44f08786f4
-
DrahtBot commented at 9:48 PM on July 16, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK theuni, kevkevinpal, maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #30454 (build: Introduce CMake-based buid system by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- hebasto added the label Refactoring on Jul 16, 2024
- hebasto added the label Tests on Jul 16, 2024
-
- theuni approved
-
theuni commented at 9:57 PM on July 16, 2024: member
trivial ACK 44f08786f435ed4284d39dc604c2a5fcbde9e602.
Seems weird to be catching a non-const ref, but it really doesn't matter here :)
-
kevkevinpal commented at 12:14 AM on July 17, 2024: contributor
utACK 44f0878
lgtm! seems pretty straight forward
-
maflcko commented at 11:32 AM on July 18, 2024: member
ACK 44f08786f435ed4284d39dc604c2a5fcbde9e602
- fanquake merged this on Jul 18, 2024
- fanquake closed this on Jul 18, 2024
- hebasto deleted the branch on Jul 18, 2024
- PastaPastaPasta referenced this in commit b6043d6e50 on Sep 27, 2024
- PastaPastaPasta referenced this in commit d36534d800 on Sep 27, 2024
- PastaPastaPasta referenced this in commit a204616446 on Sep 27, 2024
- PastaPastaPasta referenced this in commit 9612287e91 on Oct 1, 2024
- kwvg referenced this in commit 1456afaf89 on May 27, 2025
- bitcoin locked this on Jul 18, 2025
Contributors
Labels