refactor: Make m_last_notified_header private #30466

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2407-priv-last-header changing 2 files +17 −15
  1. maflcko commented at 7:14 am on July 17, 2024: member

    Seems brittle to expose mutable fields public.

    Fix it by making it private.

    Fixes #30425 (review)

  2. refactor: Make m_last_notified_header private fa927055dd
  3. DrahtBot commented at 7:14 am on July 17, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Refactoring on Jul 17, 2024
  5. TheCharlatan approved
  6. TheCharlatan commented at 7:34 am on July 17, 2024: contributor
    lgtm fa927055dd43dda945396574273a210186beec9f
  7. dergoegge approved
  8. dergoegge commented at 8:30 am on July 17, 2024: member
    utACK fa927055dd43dda945396574273a210186beec9f
  9. fanquake merged this on Jul 17, 2024
  10. fanquake closed this on Jul 17, 2024

  11. maflcko deleted the branch on Jul 17, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me