Seems brittle to expose mutable fields public.
Fix it by making it private.
Fixes #30425 (review)
refactor: Make m_last_notified_header private #30466
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2407-priv-last-header changing 2 files +17 −15-
maflcko commented at 7:14 AM on July 17, 2024: member
-
refactor: Make m_last_notified_header private fa927055dd
-
DrahtBot commented at 7:14 AM on July 17, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK dergoegge If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Refactoring on Jul 17, 2024
- TheCharlatan approved
-
TheCharlatan commented at 7:34 AM on July 17, 2024: contributor
lgtm fa927055dd43dda945396574273a210186beec9f
- dergoegge approved
-
dergoegge commented at 8:30 AM on July 17, 2024: member
utACK fa927055dd43dda945396574273a210186beec9f
- fanquake merged this on Jul 17, 2024
- fanquake closed this on Jul 17, 2024
- maflcko deleted the branch on Jul 17, 2024
- bitcoin locked this on Jul 18, 2025
Contributors
Labels