guix: move bison from global scope, to Linux #30534

fanquake commented at 5:16 PM on July 26, 2024: member

This is only needed for the Qt build (libxkbcommon), on Linux, so does not need to be built/present for the macOS or Windows builds.

guix: move bison from global scope, to Linux

This is only needed for the Qt build, on Linux, so does not need to be
built/present for the macOS or Windows builds.

e6df3485ed

DrahtBot commented at 5:16 PM on July 26, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#29881 (guix: use GCC 13 to builds releases by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on Jul 26, 2024

fanquake removed the label Build system on Jul 26, 2024

fanquake added the label DrahtBot Guix build requested on Jul 26, 2024

DrahtBot commented at 9:36 AM on July 27, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 30cef53707fb62ab1c9e73c2b5bc8b006e0613d3<br>(master)	commit 9684ddaba636f3b20205b189c6875114489587a2<br>(master and this pull)
SHA256SUMS.part	`3b7aa66925c7c6e0...`	`4eb566d831b3599f...`
*-aarch64-linux-gnu-debug.tar.gz	`fdcdbc3178cffd81...`	`70e8b742748e952f...`
*-aarch64-linux-gnu.tar.gz	`edbb79a426e98131...`	`f4105d3b4e2b903d...`
*-arm-linux-gnueabihf-debug.tar.gz	`43a58a2645f8e6f3...`	`1233dff6aa5ecc50...`
*-arm-linux-gnueabihf.tar.gz	`40e8ee61dac18c3d...`	`59281eacccd9afcf...`
*-arm64-apple-darwin-unsigned.tar.gz	`26bbfcfa3c8f7bcf...`	`c6cb80fe5958d7b5...`
*-arm64-apple-darwin-unsigned.zip	`ddb3523ffb957d3a...`	`55edd74fa514de47...`
*-arm64-apple-darwin.tar.gz	`b97b9d52433df4de...`	`96c06788f6a3f14c...`
*-powerpc64-linux-gnu-debug.tar.gz	`18446ab91b313186...`	`f2d2b8d64ca14b9e...`
*-powerpc64-linux-gnu.tar.gz	`c54fe925a919da8d...`	`ca71a428d5c7a22f...`
*-riscv64-linux-gnu-debug.tar.gz	`c8ade565eb8726ad...`	`6fbd7503fe2f5c4c...`
*-riscv64-linux-gnu.tar.gz	`166707abeacc1933...`	`672676c9bfa6abe2...`
*-x86_64-apple-darwin-unsigned.tar.gz	`9fd4489a1a49cfd1...`	`b796c363105f2b0a...`
*-x86_64-apple-darwin-unsigned.zip	`908f998b3349ce0f...`	`faa6e3dd2d3eb681...`
*-x86_64-apple-darwin.tar.gz	`99fd5e3555368829...`	`bd36ae6468714eb7...`
*-x86_64-linux-gnu-debug.tar.gz	`355f4c2fd5c0fcc4...`	`2ee17b6dd035a556...`
*-x86_64-linux-gnu.tar.gz	`c43e72c23d4534f6...`	`9b93c6ed95d040bc...`
*.tar.gz	`549fe1a1814c7ead...`	`42c75c7cfeeb924d...`
guix_build.log	`b1b04278e25d75c2...`	`c92d420394d3364e...`
guix_build.log.diff		`ad0e0b78472c8e62...`

DrahtBot removed the label DrahtBot Guix build requested on Jul 27, 2024

DrahtBot added the label Build system on Jul 27, 2024

TheCharlatan commented at 1:08 PM on July 27, 2024: contributor

Guix build (aarch64):

e06b7ed42cf35c58bce65af5802a50c16b8eb570c1f39b32538dffa9c37d57f8  guix-build-e6df3485ed23/output/aarch64-linux-gnu/SHA256SUMS.part
aaae74d5c922a550d377c0de76fd54799df88b6efc53482c641e09bdee77362b  guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu-debug.tar.gz
050b5409cd77dd3636deb37f4f9524fc34ea1a957f86b96fc427a65d067097be  guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu.tar.gz
41d31c52e482379da1a3ea587abc6dd06d2fabe9a9d0146b02e98e1953ed81ae  guix-build-e6df3485ed23/output/arm-linux-gnueabihf/SHA256SUMS.part
a3c8f1c98674ae46bd858bf9c9738f27e0e3bf7f88c6b8fe4666ba053b8950c2  guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf-debug.tar.gz
db2a25d235584e6f2743452ae48c7041565d8f4b08404f07e66e713f76f169ef  guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf.tar.gz
6588b240103223af496c76bf722481fdad4d088a4ce94963276440424422eaa1  guix-build-e6df3485ed23/output/arm64-apple-darwin/SHA256SUMS.part
530e18cb3c44f84f2595ff9ac1961b6f786b0946e715330111671ae46f54dca3  guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.tar.gz
93938f04beffa2df56d2b3f2fce64e1349decd41072caa211b6714bd303642c4  guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.zip
f2592968ef02cf0e500ddc5b2c9a8bae170522d20356fd5ff895b8bfb24f7c62  guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin.tar.gz
98618f026a7e211761a09fe8c97fc9e13d18726204e020f1cea4340ab4615f2b  guix-build-e6df3485ed23/output/dist-archive/bitcoin-e6df3485ed23.tar.gz
283f7b254b2e489fd51501b93318ee1ec90f1b0a63ab3f5607b3ac0b567ab438  guix-build-e6df3485ed23/output/powerpc64-linux-gnu/SHA256SUMS.part
9d0621b42f195783eb56c0bc2f2a99f8e4bf34cdbcecfe2b86078c1ebfa1830b  guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu-debug.tar.gz
7ef162d8353ba0a8856ffb2e3cecb783d973c408d213ea72de5c51d9dde7da28  guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu.tar.gz
a5a777a32d49be5e9f5f2ea68f52470bb5ff4ca8cf1bd7f863b5cac5180a7787  guix-build-e6df3485ed23/output/riscv64-linux-gnu/SHA256SUMS.part
461a32589cf96945447da8d66263c203439903802c245713de15d88d48eb0f0b  guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu-debug.tar.gz
0045b425d04ea03158e300b7b5b47523589ac730861f3632d9e394261aaf69cf  guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu.tar.gz
8c51307bfdb3ae66db70ce6dd21fdccc5ebcd7425482e8f68165670b81ccea97  guix-build-e6df3485ed23/output/x86_64-apple-darwin/SHA256SUMS.part
fd2c32ba1a8d87651e86f632fab9b8eba72cd43c8faf7ec20eb766d5d05cb432  guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.tar.gz
35b7caa4c62cd72eb12d13807380fba9dcfdf62f30a28e848c886986900f032d  guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.zip
41ca0b7476e9a91f08d60c36ad3dbeb0538a42c3eca40e15e0d286c64c6faaab  guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin.tar.gz
6b5d315e6985c466b0153c36baf9500767a4b4e6b55ec1e9380e79b1c288837f  guix-build-e6df3485ed23/output/x86_64-linux-gnu/SHA256SUMS.part
87aefa71731cf735fba8ee21b172139d65953c138fbc75f5f1dd238d53c1d32d  guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu-debug.tar.gz
3a6ccde6608fa8b19642b9b7623146c9b37871da16ae2d8801e31ebbf8251340  guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu.tar.gz
2bca8dd25e7b15869c889d1dfa3514d7dfd2cb89f35bf918a03bc01651df73e1  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/SHA256SUMS.part
067591caa19d972061fe4a0565f4bcae304afa02f70b23bc0dff65249be3f985  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-debug.zip
678ace84ce348af8b48ec39448faafbe259b8464d62b6a2eaf07c2b3ad065655  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-setup-unsigned.exe
fa8d04c1e48af8ba4dbaf4ab5d274c09f57f713312917712737255f19622ccdf  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-unsigned.tar.gz
f745e3dcfa3ce7f00bb4e5181c06518349511ff4e2985f543e98eff341b4e036  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64.zip

hebasto approved

hebasto commented at 7:21 AM on July 28, 2024: member

My Guix build:

x86_64
e06b7ed42cf35c58bce65af5802a50c16b8eb570c1f39b32538dffa9c37d57f8  guix-build-e6df3485ed23/output/aarch64-linux-gnu/SHA256SUMS.part
aaae74d5c922a550d377c0de76fd54799df88b6efc53482c641e09bdee77362b  guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu-debug.tar.gz
050b5409cd77dd3636deb37f4f9524fc34ea1a957f86b96fc427a65d067097be  guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu.tar.gz
41d31c52e482379da1a3ea587abc6dd06d2fabe9a9d0146b02e98e1953ed81ae  guix-build-e6df3485ed23/output/arm-linux-gnueabihf/SHA256SUMS.part
a3c8f1c98674ae46bd858bf9c9738f27e0e3bf7f88c6b8fe4666ba053b8950c2  guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf-debug.tar.gz
db2a25d235584e6f2743452ae48c7041565d8f4b08404f07e66e713f76f169ef  guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf.tar.gz
6588b240103223af496c76bf722481fdad4d088a4ce94963276440424422eaa1  guix-build-e6df3485ed23/output/arm64-apple-darwin/SHA256SUMS.part
530e18cb3c44f84f2595ff9ac1961b6f786b0946e715330111671ae46f54dca3  guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.tar.gz
93938f04beffa2df56d2b3f2fce64e1349decd41072caa211b6714bd303642c4  guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.zip
f2592968ef02cf0e500ddc5b2c9a8bae170522d20356fd5ff895b8bfb24f7c62  guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin.tar.gz
98618f026a7e211761a09fe8c97fc9e13d18726204e020f1cea4340ab4615f2b  guix-build-e6df3485ed23/output/dist-archive/bitcoin-e6df3485ed23.tar.gz
283f7b254b2e489fd51501b93318ee1ec90f1b0a63ab3f5607b3ac0b567ab438  guix-build-e6df3485ed23/output/powerpc64-linux-gnu/SHA256SUMS.part
9d0621b42f195783eb56c0bc2f2a99f8e4bf34cdbcecfe2b86078c1ebfa1830b  guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu-debug.tar.gz
7ef162d8353ba0a8856ffb2e3cecb783d973c408d213ea72de5c51d9dde7da28  guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu.tar.gz
a5a777a32d49be5e9f5f2ea68f52470bb5ff4ca8cf1bd7f863b5cac5180a7787  guix-build-e6df3485ed23/output/riscv64-linux-gnu/SHA256SUMS.part
461a32589cf96945447da8d66263c203439903802c245713de15d88d48eb0f0b  guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu-debug.tar.gz
0045b425d04ea03158e300b7b5b47523589ac730861f3632d9e394261aaf69cf  guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu.tar.gz
8c51307bfdb3ae66db70ce6dd21fdccc5ebcd7425482e8f68165670b81ccea97  guix-build-e6df3485ed23/output/x86_64-apple-darwin/SHA256SUMS.part
fd2c32ba1a8d87651e86f632fab9b8eba72cd43c8faf7ec20eb766d5d05cb432  guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.tar.gz
35b7caa4c62cd72eb12d13807380fba9dcfdf62f30a28e848c886986900f032d  guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.zip
41ca0b7476e9a91f08d60c36ad3dbeb0538a42c3eca40e15e0d286c64c6faaab  guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin.tar.gz
6b5d315e6985c466b0153c36baf9500767a4b4e6b55ec1e9380e79b1c288837f  guix-build-e6df3485ed23/output/x86_64-linux-gnu/SHA256SUMS.part
87aefa71731cf735fba8ee21b172139d65953c138fbc75f5f1dd238d53c1d32d  guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu-debug.tar.gz
3a6ccde6608fa8b19642b9b7623146c9b37871da16ae2d8801e31ebbf8251340  guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu.tar.gz
2bca8dd25e7b15869c889d1dfa3514d7dfd2cb89f35bf918a03bc01651df73e1  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/SHA256SUMS.part
067591caa19d972061fe4a0565f4bcae304afa02f70b23bc0dff65249be3f985  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-debug.zip
678ace84ce348af8b48ec39448faafbe259b8464d62b6a2eaf07c2b3ad065655  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-setup-unsigned.exe
fa8d04c1e48af8ba4dbaf4ab5d274c09f57f713312917712737255f19622ccdf  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-unsigned.tar.gz
f745e3dcfa3ce7f00bb4e5181c06518349511ff4e2985f543e98eff341b4e036  guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64.zip

hebasto approved

hebasto commented at 7:23 AM on July 28, 2024: member

ACK e6df3485ed2302712b7cf03bdb7e76aea197a1ea.

TheCharlatan approved

TheCharlatan commented at 7:28 AM on July 28, 2024: contributor

ACK e6df3485ed2302712b7cf03bdb7e76aea197a1ea

fanquake merged this on Jul 29, 2024

fanquake closed this on Jul 29, 2024

fanquake deleted the branch on Jul 29, 2024

luke-jr referenced this in commit 39e09b6769 on Aug 1, 2024

PastaPastaPasta referenced this in commit bec8ad71b7 on Feb 17, 2025

PastaPastaPasta referenced this in commit 12f3b563ec on Feb 19, 2025

PastaPastaPasta referenced this in commit 9a93a653c3 on Feb 20, 2025

PastaPastaPasta referenced this in commit c34e7ab534 on Feb 20, 2025

PastaPastaPasta referenced this in commit 456add22c3 on Feb 21, 2025

bitcoin locked this on Jul 29, 2025