Doc: add a comment referencing past vulnerability next to where it was fixed #30538
pull darosior wants to merge 6 commits into bitcoin:master from darosior:2407_doc_reference_past_vulns changing 5 files +20 −0-
darosior commented at 9:11 am on July 28, 2024: memberIt is useful when reading code to have context about why it is written or behaves the way it does. Some instances in this PR may seem obvious but i think nonetheless offer important context to anyone willing to change (or review a change to) this code.
-
doc: validation: add a reference to historical header spam vulnerability d6b46d8d5e
-
doc: net_proc: reference past defect regarding invalid GETDATA types 7b44f0741f
-
doc: net_proc: reference past DoS vulnerability in orphan processing 382f67d39a
-
doc: txrequest: point to past censorship vulnerability in tx re-request handling f57f621638
-
doc: net: mention past vulnerability as rationale to limit incoming message size 70992f59de
-
doc: banman: reference past vuln due to unbounded banlist 7fea8eeeb9
-
DrahtBot commented at 9:11 am on July 28, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #30110 (refactor: TxDownloadManager + fuzzing by glozow)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
DrahtBot added the label Docs on Jul 28, 2024
-
tdb3 approved
-
tdb3 commented at 1:30 pm on July 28, 2024: contributorACK 7fea8eeeb9984ff6f3ed661f3970b1aaa68548de Great idea Tested links (worked)
-
eval-exec approved
-
mjdietzx commented at 4:52 pm on July 29, 2024: contributorACK 7fea8eeeb9984ff6f3ed661f3970b1aaa68548de
-
glozow requested review from dergoegge on Jul 31, 2024
-
achow101 commented at 11:15 pm on September 17, 2024: member
~0
I’m not sure that having a comment that references code that no longer exists is all that useful.
-
DrahtBot added the label CI failed on Oct 13, 2024
-
DrahtBot removed the label CI failed on Oct 19, 2024
-
DrahtBot added the label Needs rebase on Oct 29, 2024
-
DrahtBot commented at 8:05 pm on October 29, 2024: contributor
🐙 This pull request conflicts with the target branch and needs rebase.
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 21:12 UTC
More mirrored repositories can be found on mirror.b10c.me