Update libsecp256k1 subtree to latest master #30573

pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:secp_0_5_1 changing 19 files +218 −57

fanquake commented at 10:41 AM on August 2, 2024: member
Updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/642c885b6102725e25623738529895a95addc4f4 (which is the tag for the v0.5.1 release). Includes a handful of changes:
Reverts a057869aa3c42457570765966cb66accb2375b13 given secps default has changed (https://github.com/bitcoin-core/secp256k1/pull/1563):

As a rule of thumb, the default values for configuration options should target standard desktop machines and align with Bitcoin Core's defaults, and the tests should mostly exercise the default configuration (see #1549).

Squashed 'src/secp256k1/' changes from 4af241b320..642c885b61

642c885b61 Merge bitcoin-core/secp256k1#1575: release: prepare for 0.5.1
cdf08c1a2b Merge bitcoin-core/secp256k1#1576: doc: mention `needs-changelog` github label in release process
40d87b8e45 release: prepare for 0.5.1
5770226176 changelog: clarify CMake option
759bd4bbc8 doc: mention `needs-changelog` github label in release process
fded437c4c Merge bitcoin-core/secp256k1#1574: Fix compilation when extrakeys module isn't enabled
763d938cf0 ci: only enable extrakeys module when schnorrsig is enabled
af551ab9db tests: do not use functions from extrakeys module
0055b86780 Merge bitcoin-core/secp256k1#1551: Add ellswift usage example
ea2d5f0f17 Merge bitcoin-core/secp256k1#1563: doc: Add convention for defaults
ca06e58b2c Merge bitcoin-core/secp256k1#1564: build, ci: Adjust the default size of the precomputed table for signing
e2af491263 ci: Switch to the new default value of the precomputed table for signing
d94a9273f8 build: Adjust the default size of the precomputed table for signing
fcc5d7381b Merge bitcoin-core/secp256k1#1565: cmake: Bump CMake minimum required version up to 3.16
9420eece24 cmake: Bump CMake minimum required version up to 3.16
16685649d2 doc: Add convention for defaults
a5269373fa Merge bitcoin-core/secp256k1#1555: Fixed O3 replacement
b8fe33332b cmake: Fixed O3 replacement
31f84595c4 Add ellswift usage example
fe4fbaa7f3 examples: fix case typos in secret clearing paragraphs (s/, Or/, or/)

git-subtree-dir: src/secp256k1
git-subtree-split: 642c885b6102725e25623738529895a95addc4f4

41797f8ab9

Update secp256k1 subtree to latest master 183e2fd6b5
Revert "build: pass --with-ecmult-gen-kb=86 to secp256k1"
This reverts commit a057869aa3c42457570765966cb66accb2375b13.
9ec776adff
DrahtBot commented at 10:42 AM on August 2, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
hebasto added the label Needs CMake port on Aug 2, 2024
hebasto approved
hebasto commented at 12:44 PM on August 2, 2024: member

ACK 9ec776adff90f1d4cbb3c4decaf281bb391e5e1e, I've reproduced the subtree update locally with the zero diff with this PR branch.
fanquake merged this on Aug 6, 2024
fanquake closed this on Aug 6, 2024
fanquake deleted the branch on Aug 6, 2024
hebasto commented at 11:17 AM on August 6, 2024: member

Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/305.
hebasto removed the label Needs CMake port on Aug 6, 2024
hebasto referenced this in commit 8d963bf3dc on Aug 6, 2024
bitcoin locked this on Aug 6, 2025

Type	Reviewers
ACK	hebasto

Contributors

fanquake

DrahtBot

hebasto

Linked (view graph)

#1549 Addnode optimization and addnode access via RPC

Update libsecp256k1 subtree to latest master #30573

Code Coverage

Reviews