This PR stems from a requirement for the g++
minimum supported version being >= 11:
doc: Add note about distro’s g++-mingw-w64-x86-64-posix
version
#30580
pull
hebasto
wants to merge
1
commits into
bitcoin:master
from
hebasto:240803-mingw-docs
changing
1
files
+3 −0
-
hebasto commented at 10:29 am on August 3, 2024: member
-
hebasto added the label Docs on Aug 3, 2024
-
hebasto added the label Windows on Aug 3, 2024
-
hebasto added this to the milestone 28.0 on Aug 3, 2024
-
DrahtBot commented at 10:29 am on August 3, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
fanquake commented at 10:58 am on August 3, 2024: member~0. I think it’s easier to document nothing here. Listing 2 distros out of the many others where this works/is supported seems arbitrary, and the change is also not really correct correct in any case, i.e building on earlier versions (23.10) works fine (regardless of if “support” has ended). The compiler is the requirement, not the distro.
-
in doc/build-windows.md:16 in f237d9b885 outdated
12@@ -13,6 +13,8 @@ Other options which may work, but which have not been extensively tested are (pl 13 14 * On Windows, using a POSIX compatibility layer application such as [cygwin](https://www.cygwin.com/) or [msys2](https://www.msys2.org/). 15 16+Currently only building on Ubuntu 24.04 or later and Debian 12 or later is supported.
maflcko commented at 11:26 am on August 3, 2024:Maybe just “The instructions below work on Ubuntu and Debian. Make sure the distribution’sg++-mingw-w64-x86-64-posix
package meets the minimum required G++ version specified in [doc/dep.md]”?
hebasto commented at 11:55 am on August 3, 2024:Thanks! Reworked using your suggestion.doc: Add note about distro's g++-mingw-w64-x86-64-posix version
This stems from a requirement for the g++ minimum supported version being >= 11.
hebasto force-pushed on Aug 3, 2024hebasto renamed this:
doc: Specify minimum distro versions for MinGW builds
doc: Add note about distro's `g++-mingw-w64-x86-64-posix` version
on Aug 3, 2024fanquake removed this from the milestone 28.0 on Aug 5, 2024m3dwards commented at 8:49 pm on August 5, 2024: contributorI was testing a different PR and wanted to compile on WSL so I ran the default wsl –install which by default install Ubuntu 22.04 (confusingly just called ubuntu - no version) which has ming32 gcc 10 and therefore is no good.
The original version of the PR with explicit distribution recommendations would have been extremely easy to guide me in the right direction but I can see that the amended version suggesting to compare mingw against
dependencies.md
would be less maintenance burden.ACK ed83974bb411ab5ebe3eef28f0ac995ce07936cd
maflcko commented at 9:22 am on August 7, 2024: memberreview-only ACK ed83974bb411ab5ebe3eef28f0ac995ce07936cdfanquake merged this on Aug 12, 2024fanquake closed this on Aug 12, 2024
hebasto deleted the branch on Aug 12, 2024
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 09:12 UTC
More mirrored repositories can be found on mirror.b10c.me