depends: Make default `host` and `build` comparable #30584

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240804-cross changing 1 files +7 −7
  1. hebasto commented at 10:29 PM on August 4, 2024: member

    To detect cross-compiling, the host and build platforms are compared. The build variable is always an output of config.sub, but the host is not. This can lead to false results. For example, on OpenBSD:

    • host=amd64-unknown-openbsd7.5
    • build=x86_64-unknown-openbsd7.5

    This PR sets the default value of the host variable to the value of build, ensuring cross-compiling won't be triggered when the HOST variable is not set.

    This PR fixes needless triggering of cross-compiling for CMake-built packages in depends on OpenBSD due to this code:https://github.com/bitcoin/bitcoin/blob/eb85cacd2969caaea682104f498f6b2e6cfb80f8/depends/funcs.mk#L193-L197

    No changes in Guix build.

  2. hebasto added the label Build system on Aug 4, 2024
  3. DrahtBot commented at 10:29 PM on August 4, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/30584.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK laanwj, theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30994 (depends: fix for llvm-ranlib (etc): 'No such file or directory' macOS 15.0 by itornaza)
    • #29963 (depends: Use CC_FOR_BUILD for config.guess by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. hebasto force-pushed on Aug 4, 2024
  5. hebasto marked this as ready for review on Aug 4, 2024
  6. hebasto commented at 10:58 PM on August 4, 2024: member

    cc @theStack

  7. hebasto commented at 7:26 AM on August 5, 2024: member

    My Guix build:

    x86_64
0bc6e070faf31aae6b7b5260235fdce4791106d904f1654ace718a34462eccaa  guix-build-43ad9cf3d4f7/output/aarch64-linux-gnu/SHA256SUMS.part
b459847ead62ad6f8c19b9edfca257a392c76dd87781dc1170780476d9c1f83d  guix-build-43ad9cf3d4f7/output/aarch64-linux-gnu/bitcoin-43ad9cf3d4f7-aarch64-linux-gnu-debug.tar.gz
774353a147659f53e817638fd1172adca99beb026b2dc04434b018c326213e64  guix-build-43ad9cf3d4f7/output/aarch64-linux-gnu/bitcoin-43ad9cf3d4f7-aarch64-linux-gnu.tar.gz
d43155c02e1941b5256ba05a442bb78c36b9fc8733c613d4ff079fe3445f7918  guix-build-43ad9cf3d4f7/output/arm-linux-gnueabihf/SHA256SUMS.part
449f6df92b4141633c69964de7f039ccfd1ad39d9d26cb5b39df4ad143f8ef11  guix-build-43ad9cf3d4f7/output/arm-linux-gnueabihf/bitcoin-43ad9cf3d4f7-arm-linux-gnueabihf-debug.tar.gz
520cd7e3d7afa9b4a511dcd70f3aed09525602d08de1b94dbd3fc5640341c66e  guix-build-43ad9cf3d4f7/output/arm-linux-gnueabihf/bitcoin-43ad9cf3d4f7-arm-linux-gnueabihf.tar.gz
a4060e3bfffff6f9116915415717e7a5ef6d4a9fc469c23529d3b042aad6dc0c  guix-build-43ad9cf3d4f7/output/arm64-apple-darwin/SHA256SUMS.part
88627ae914949e434b118a6c7deb3c7b4b31b1b90941645a37d7f7edf2d628ca  guix-build-43ad9cf3d4f7/output/arm64-apple-darwin/bitcoin-43ad9cf3d4f7-arm64-apple-darwin-unsigned.tar.gz
64552032457ffddf73d5be9ad496fbb36c6c3a2885a821e3ee7084ae96236ebe  guix-build-43ad9cf3d4f7/output/arm64-apple-darwin/bitcoin-43ad9cf3d4f7-arm64-apple-darwin-unsigned.zip
d7fe5bd08e41533a7291a9cc1660d6af2be965a0818a12639aa8d8da6c24c7b3  guix-build-43ad9cf3d4f7/output/arm64-apple-darwin/bitcoin-43ad9cf3d4f7-arm64-apple-darwin.tar.gz
ca28f3ccb0581839520ad9f5b660c4a2a4a622aad68565efc41ad63c1fb859ca  guix-build-43ad9cf3d4f7/output/dist-archive/bitcoin-43ad9cf3d4f7.tar.gz
0f4f382d07927ff2c797c91f344946c1ac54555128b37cb6684633964a58515c  guix-build-43ad9cf3d4f7/output/powerpc64-linux-gnu/SHA256SUMS.part
6abed644ecca44397371dc74eff81f5834c1a9601fb65c33c069d2b936dcaf14  guix-build-43ad9cf3d4f7/output/powerpc64-linux-gnu/bitcoin-43ad9cf3d4f7-powerpc64-linux-gnu-debug.tar.gz
35b31c773fa00f94e8bbd4213860e6bda4f838d71ed16aacae592f0177429206  guix-build-43ad9cf3d4f7/output/powerpc64-linux-gnu/bitcoin-43ad9cf3d4f7-powerpc64-linux-gnu.tar.gz
7e57152c1da95b8016f1a65ca08d849de99e1a5c550fba909fd1f9b53c76705b  guix-build-43ad9cf3d4f7/output/riscv64-linux-gnu/SHA256SUMS.part
dc9e9f6e088f253bdf0a3fab5b6e388a101ff3e3b79eaf2ce680ec3236be10f0  guix-build-43ad9cf3d4f7/output/riscv64-linux-gnu/bitcoin-43ad9cf3d4f7-riscv64-linux-gnu-debug.tar.gz
ba63421db78859ae26eef4fa4750a96f7d6edc721e24c95d8a58f1b1462f5105  guix-build-43ad9cf3d4f7/output/riscv64-linux-gnu/bitcoin-43ad9cf3d4f7-riscv64-linux-gnu.tar.gz
c0a841632f0e457ce86be1bedd2f51a59fd3b8f39444c9fc300a7ac000a58be1  guix-build-43ad9cf3d4f7/output/x86_64-apple-darwin/SHA256SUMS.part
e3f0a541fb923043d5297324cc0e39a5d4e31a46057e75cc3d993d23c35546ba  guix-build-43ad9cf3d4f7/output/x86_64-apple-darwin/bitcoin-43ad9cf3d4f7-x86_64-apple-darwin-unsigned.tar.gz
a19e6a36b1a5e252682cfd06bcda0ea05612d5fddf7d80c878fe4030521f7271  guix-build-43ad9cf3d4f7/output/x86_64-apple-darwin/bitcoin-43ad9cf3d4f7-x86_64-apple-darwin-unsigned.zip
cb2d443b0d50eb945e7c7be84062e9bcfa585e9ec107d861f3babf5c8b0c7acd  guix-build-43ad9cf3d4f7/output/x86_64-apple-darwin/bitcoin-43ad9cf3d4f7-x86_64-apple-darwin.tar.gz
8f3c40b7b0ba96ac5a0148b45412fcf2fd06556a43ff1e79be90e22d326e9ce6  guix-build-43ad9cf3d4f7/output/x86_64-linux-gnu/SHA256SUMS.part
9b637a2f98c3494d79ffc573b5b350e65a583c0508a7b913c16f164bef7c9854  guix-build-43ad9cf3d4f7/output/x86_64-linux-gnu/bitcoin-43ad9cf3d4f7-x86_64-linux-gnu-debug.tar.gz
dcfa6519684232c8c8f93cc0aa4f8daa7da28b21761009e82232bdf91f9b9876  guix-build-43ad9cf3d4f7/output/x86_64-linux-gnu/bitcoin-43ad9cf3d4f7-x86_64-linux-gnu.tar.gz
e92fccc8a5f76e681a5059ccff64f34aee08bedece7064028cee02aac7201619  guix-build-43ad9cf3d4f7/output/x86_64-w64-mingw32/SHA256SUMS.part
653ede5c8d2ac32c167ace907c13226a94692bae2d4c9e7eeffd3c1ee675b0b4  guix-build-43ad9cf3d4f7/output/x86_64-w64-mingw32/bitcoin-43ad9cf3d4f7-win64-debug.zip
89f2681f624cd12d2c1fd2c02ae905a4d30ce77eba67abf40d44b7e2b80857b5  guix-build-43ad9cf3d4f7/output/x86_64-w64-mingw32/bitcoin-43ad9cf3d4f7-win64-setup-unsigned.exe
386c0753266258a596056f17711b1f2676178dc60eab691f59525d57929f35ac  guix-build-43ad9cf3d4f7/output/x86_64-w64-mingw32/bitcoin-43ad9cf3d4f7-win64-unsigned.tar.gz
a4d9547ca152d0e4e67bdda3e58055b9864f90863764786e6f15386751463ddc  guix-build-43ad9cf3d4f7/output/x86_64-w64-mingw32/bitcoin-43ad9cf3d4f7-win64.zip
  8. fanquake commented at 8:31 AM on August 5, 2024: member

    This can lead to false results. For example, on OpenBSD: host=amd64-unknown-openbsd7.5 build=x86_64-unknown-openbsd7.5

    What command to build depends are you running here?

  9. hebasto commented at 8:33 AM on August 5, 2024: member

    This can lead to false results. For example, on OpenBSD:

    host=amd64-unknown-openbsd7.5

    build=x86_64-unknown-openbsd7.5

    What command to build depends are you running here?

    gmake -C depends
  10. theStack commented at 12:05 AM on August 8, 2024: contributor

    @hebasto: Can you give a hint on how to test this? As far as I remember, I saw an output where "Cross compiling ....." was set to TRUE in the course of testing another PR on your cmake branch with a toolchain.cmake (probably https://github.com/hebasto/bitcoin/pull/292), but in this PR there is no toolchain.cmake yet and hence I don't know how to reproduce it.

  11. hebasto commented at 8:03 AM on August 8, 2024: member

    @theStack

    Can you give a hint on how to test this? As far as I remember, I saw an output where "Cross compiling ....." was set to TRUE in the course of testing another PR on your cmake branch with a toolchain.cmake (probably hebasto#292), but in this PR there is no toolchain.cmake yet and hence I don't know how to reproduce it.

    You could print variable values out:

    cd depends
gmake print-host
gmake print-build
cd ..

    By default, without explicitly specifying the HOST variable, both printed values should be the same.

  12. theStack commented at 1:00 PM on August 9, 2024: contributor

    @hebasto: Ok, I can confirm that with OpenBSD 7.5 on master, the host/build values differ:

    $ gmake print-host
host=amd64-unknown-openbsd7.5
$ gmake print-build
build=x86_64-unknown-openbsd7.5

    while on the PR branch they are equal :heavy_check_mark:

    $ gmake print-host
host=x86_64-unknown-openbsd7.5
$ gmake print-build
build=x86_64-unknown-openbsd7.5
  13. DrahtBot added the label CI failed on Sep 9, 2024
  14. DrahtBot removed the label CI failed on Sep 13, 2024
  15. DrahtBot added the label CI failed on Oct 13, 2024
  16. achow101 requested review from laanwj on Oct 15, 2024
  17. achow101 requested review from josibake on Oct 15, 2024
  18. maflcko commented at 3:26 PM on October 16, 2024: member

    Could rebase for fresh CI?

  19. depends: Make default `host` and `build` comparable
    To detect cross-compiling, the host and build platforms are compared.
The `build` variable is always an output of `config.sub`, but the `host`
is not. This can lead to false results. For example, on OpenBSD:
 - host=amd64-unknown-openbsd7.5
 - build=x86_64-unknown-openbsd7.5

This change sets the default value of the `host` variable to the value
of `build`, ensuring cross-compiling won't be triggered when the `HOST`
variable is not set.
    b28917be36
  20. hebasto force-pushed on Oct 16, 2024
  21. hebasto commented at 3:36 PM on October 16, 2024: member

    Could rebase for fresh CI?

    Done.

  22. DrahtBot removed the label CI failed on Oct 16, 2024
  23. hebasto commented at 9:43 AM on February 10, 2025: member

    Friendly ping @laanwj @josibake @theuni ;)

  24. laanwj approved
  25. laanwj commented at 11:19 AM on February 10, 2025: member

    Concept and code review ACK b28917be363fb5a82effffeadbe4ba27bb1c70ce

  26. laanwj commented at 9:49 AM on February 11, 2025: member

    Tested ACK b28917be363fb5a82effffeadbe4ba27bb1c70ce

    • Successfully tested depends build with gmake NO_QT=1 on OpenBSD 7.6
    • Differences in cmakelists.txt show it's no longer doing a cross-build by default (eg it does try_run()):

    <details> <summary>libevent</summary>

    --- cmake-libevent-base.txt	Tue Feb 11 10:23:06 2025
+++ cmake-libevent-patched.txt	Tue Feb 11 10:33:37 2025
@@ -1,5 +1,5 @@
 # This is the CMakeCache file.
-# For build in directory: /home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6/build
+# For build in directory: /home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41/build
 # It was generated by CMake: /usr/local/bin/cmake
 # You can edit this file to change values found and used by cmake.
 # If you do not want to change any of the values, simply exit the editor.
@@ -20,9 +20,8 @@
 //Path to a program.
 CMAKE_AR:FILEPATH=/usr/bin/ar
 
-//Choose the type of build, options are: None Debug Release RelWithDebInfo
-// MinSizeRel ...
-CMAKE_BUILD_TYPE:STRING=None
+//Set build type to Debug o Release (default Release)
+CMAKE_BUILD_TYPE:STRING=Release
 
 //Enable/Disable color output during build.
 CMAKE_COLOR_MAKEFILE:BOOL=ON
@@ -30,9 +29,6 @@
 //Limited configurations
 CMAKE_CONFIGURATION_TYPES:STRING=Debug;Release
 
-//No help, variable specified on the command line.
-CMAKE_CXX_COMPILER_TARGET:UNINITIALIZED=amd64-unknown-openbsd7.6
-
 //C compiler
 CMAKE_C_COMPILER:FILEPATH=/usr/bin/clang
 
@@ -48,11 +44,8 @@
 //Generate index for LLVM archive
 CMAKE_C_COMPILER_RANLIB:FILEPATH=CMAKE_C_COMPILER_RANLIB-NOTFOUND
 
-//No help, variable specified on the command line.
-CMAKE_C_COMPILER_TARGET:UNINITIALIZED=amd64-unknown-openbsd7.6
-
 //Flags used by the C compiler during all build types.
-CMAKE_C_FLAGS:STRING=-I/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/include -D_GNU_SOURCE -D_FORTIFY_SOURCE=3 -pipe -std=c11 -O2 -fdebug-prefix-map=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6=/usr -fmacro-prefix-map=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6=/usr
+CMAKE_C_FLAGS:STRING=-I/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/include -D_GNU_SOURCE -D_FORTIFY_SOURCE=3 -pipe -std=c11 -O2
 
 //Flags used by the C compiler during DEBUG builds.
 CMAKE_C_FLAGS_DEBUG:STRING=-g
@@ -60,9 +53,6 @@
 //Flags used by the C compiler during MINSIZEREL builds.
 CMAKE_C_FLAGS_MINSIZEREL:STRING=-Os -DNDEBUG
 
-//Flags used by the C compiler during NONE builds.
-CMAKE_C_FLAGS_NONE:STRING=
-
 //Flags used by the C compiler during RELEASE builds.
 CMAKE_C_FLAGS_RELEASE:STRING=-O3 -DNDEBUG
 
@@ -73,7 +63,7 @@
 CMAKE_DLLTOOL:FILEPATH=CMAKE_DLLTOOL-NOTFOUND
 
 //Flags used by the linker during all build types.
-CMAKE_EXE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/lib
+CMAKE_EXE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/lib
 
 //Flags used by the linker during DEBUG builds.
 CMAKE_EXE_LINKER_FLAGS_DEBUG:STRING=
@@ -81,9 +71,6 @@
 //Flags used by the linker during MINSIZEREL builds.
 CMAKE_EXE_LINKER_FLAGS_MINSIZEREL:STRING=
 
-//Flags used by the linker during NONE builds.
-CMAKE_EXE_LINKER_FLAGS_NONE:STRING=
-
 //Flags used by the linker during RELEASE builds.
 CMAKE_EXE_LINKER_FLAGS_RELEASE:STRING=
 
@@ -94,13 +81,13 @@
 CMAKE_EXPORT_COMPILE_COMMANDS:BOOL=
 
 //Value Computed by CMake.
-CMAKE_FIND_PACKAGE_REDIRECTS_DIR:STATIC=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6/build/CMakeFiles/pkgRedirects
+CMAKE_FIND_PACKAGE_REDIRECTS_DIR:STATIC=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41/build/CMakeFiles/pkgRedirects
 
 //No help, variable specified on the command line.
 CMAKE_INSTALL_LIBDIR:UNINITIALIZED=lib/
 
 //No help, variable specified on the command line.
-CMAKE_INSTALL_PREFIX:PATH=/home/user/bitcoin/depends/amd64-unknown-openbsd7.6
+CMAKE_INSTALL_PREFIX:PATH=/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6
 
 //Path to a program.
 CMAKE_LINKER:FILEPATH=/usr/bin/ld.lld
@@ -110,7 +97,7 @@
 
 //Flags used by the linker during the creation of modules during
 // all build types.
-CMAKE_MODULE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/lib
+CMAKE_MODULE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/lib
 
 //Flags used by the linker during the creation of modules during
 // DEBUG builds.
@@ -121,10 +108,6 @@
 CMAKE_MODULE_LINKER_FLAGS_MINSIZEREL:STRING=
 
 //Flags used by the linker during the creation of modules during
-// NONE builds.
-CMAKE_MODULE_LINKER_FLAGS_NONE:STRING=
-
-//Flags used by the linker during the creation of modules during
 // RELEASE builds.
 CMAKE_MODULE_LINKER_FLAGS_RELEASE:STRING=
 
@@ -161,7 +144,7 @@
 
 //Flags used by the linker during the creation of shared libraries
 // during all build types.
-CMAKE_SHARED_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/lib
+CMAKE_SHARED_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/lib
 
 //Flags used by the linker during the creation of shared libraries
 // during DEBUG builds.
@@ -172,10 +155,6 @@
 CMAKE_SHARED_LINKER_FLAGS_MINSIZEREL:STRING=
 
 //Flags used by the linker during the creation of shared libraries
-// during NONE builds.
-CMAKE_SHARED_LINKER_FLAGS_NONE:STRING=
-
-//Flags used by the linker during the creation of shared libraries
 // during RELEASE builds.
 CMAKE_SHARED_LINKER_FLAGS_RELEASE:STRING=
 
@@ -203,10 +182,6 @@
 CMAKE_STATIC_LINKER_FLAGS_MINSIZEREL:STRING=
 
 //Flags used by the linker during the creation of static libraries
-// during NONE builds.
-CMAKE_STATIC_LINKER_FLAGS_NONE:STRING=
-
-//Flags used by the linker during the creation of static libraries
 // during RELEASE builds.
 CMAKE_STATIC_LINKER_FLAGS_RELEASE:STRING=
 
@@ -217,9 +192,6 @@
 //Path to a program.
 CMAKE_STRIP:FILEPATH=/usr/bin/strip
 
-//No help, variable specified on the command line.
-CMAKE_SYSTEM_NAME:UNINITIALIZED=OpenBSD
-
 //Path to a program.
 CMAKE_TAPI:FILEPATH=CMAKE_TAPI-NOTFOUND
 
@@ -294,7 +266,7 @@
 GIT_EXECUTABLE:FILEPATH=/usr/local/bin/git
 
 //Libevent include directories
-LIBEVENT_INCLUDE_DIRS:PATH=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6/include;/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6/build/include
+LIBEVENT_INCLUDE_DIRS:PATH=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41/include;/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41/build/include
 
 //Dependencies for the target
 event_core_static_LIB_DEPENDS:STATIC=general;-lpthread;
@@ -309,13 +281,13 @@
 event_static_LIB_DEPENDS:STATIC=general;-lpthread;general;event_core_static;
 
 //Value Computed by CMake
-libevent_BINARY_DIR:STATIC=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6/build
+libevent_BINARY_DIR:STATIC=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41/build
 
 //Value Computed by CMake
 libevent_IS_TOP_LEVEL:STATIC=ON
 
 //Value Computed by CMake
-libevent_SOURCE_DIR:STATIC=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6
+libevent_SOURCE_DIR:STATIC=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41
 
 
 ########################
@@ -327,7 +299,7 @@
 //ADVANCED property for variable: CMAKE_AR
 CMAKE_AR-ADVANCED:INTERNAL=1
 //This is the directory where this CMakeCache.txt was created
-CMAKE_CACHEFILE_DIR:INTERNAL=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6/build
+CMAKE_CACHEFILE_DIR:INTERNAL=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41/build
 //Major version of cmake used to create the current loaded cache
 CMAKE_CACHE_MAJOR_VERSION:INTERNAL=3
 //Minor version of cmake used to create the current loaded cache
@@ -356,8 +328,6 @@
 CMAKE_C_FLAGS_DEBUG-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_C_FLAGS_MINSIZEREL
 CMAKE_C_FLAGS_MINSIZEREL-ADVANCED:INTERNAL=1
-//ADVANCED property for variable: CMAKE_C_FLAGS_NONE
-CMAKE_C_FLAGS_NONE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_C_FLAGS_RELEASE
 CMAKE_C_FLAGS_RELEASE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_C_FLAGS_RELWITHDEBINFO
@@ -374,8 +344,6 @@
 CMAKE_EXE_LINKER_FLAGS_DEBUG-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_EXE_LINKER_FLAGS_MINSIZEREL
 CMAKE_EXE_LINKER_FLAGS_MINSIZEREL-ADVANCED:INTERNAL=1
-//ADVANCED property for variable: CMAKE_EXE_LINKER_FLAGS_NONE
-CMAKE_EXE_LINKER_FLAGS_NONE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_EXE_LINKER_FLAGS_RELEASE
 CMAKE_EXE_LINKER_FLAGS_RELEASE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO
@@ -400,7 +368,7 @@
 CMAKE_HAVE_PTHREAD_CREATE:INTERNAL=1
 //Source directory with the top level CMakeLists.txt file for this
 // project
-CMAKE_HOME_DIRECTORY:INTERNAL=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/libevent/2.1.12-stable-b478553d3e6
+CMAKE_HOME_DIRECTORY:INTERNAL=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/libevent/2.1.12-stable-564aa0c2a41
 //ADVANCED property for variable: CMAKE_LINKER
 CMAKE_LINKER-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_MAKE_PROGRAM
@@ -411,8 +379,6 @@
 CMAKE_MODULE_LINKER_FLAGS_DEBUG-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_MODULE_LINKER_FLAGS_MINSIZEREL
 CMAKE_MODULE_LINKER_FLAGS_MINSIZEREL-ADVANCED:INTERNAL=1
-//ADVANCED property for variable: CMAKE_MODULE_LINKER_FLAGS_NONE
-CMAKE_MODULE_LINKER_FLAGS_NONE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_MODULE_LINKER_FLAGS_RELEASE
 CMAKE_MODULE_LINKER_FLAGS_RELEASE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_MODULE_LINKER_FLAGS_RELWITHDEBINFO
@@ -439,8 +405,6 @@
 CMAKE_SHARED_LINKER_FLAGS_DEBUG-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_SHARED_LINKER_FLAGS_MINSIZEREL
 CMAKE_SHARED_LINKER_FLAGS_MINSIZEREL-ADVANCED:INTERNAL=1
-//ADVANCED property for variable: CMAKE_SHARED_LINKER_FLAGS_NONE
-CMAKE_SHARED_LINKER_FLAGS_NONE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_SHARED_LINKER_FLAGS_RELEASE
 CMAKE_SHARED_LINKER_FLAGS_RELEASE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_SHARED_LINKER_FLAGS_RELWITHDEBINFO
@@ -455,8 +419,6 @@
 CMAKE_STATIC_LINKER_FLAGS_DEBUG-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_STATIC_LINKER_FLAGS_MINSIZEREL
 CMAKE_STATIC_LINKER_FLAGS_MINSIZEREL-ADVANCED:INTERNAL=1
-//ADVANCED property for variable: CMAKE_STATIC_LINKER_FLAGS_NONE
-CMAKE_STATIC_LINKER_FLAGS_NONE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_STATIC_LINKER_FLAGS_RELEASE
 CMAKE_STATIC_LINKER_FLAGS_RELEASE-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_STATIC_LINKER_FLAGS_RELWITHDEBINFO
@@ -707,6 +669,12 @@
 EVENT__HAVE_USLEEP:INTERNAL=1
 //Have symbol vasprintf
 EVENT__HAVE_VASPRINTF:INTERNAL=1
+//Test EVENT__HAVE_WORKING_KQUEUE
+EVENT__HAVE_WORKING_KQUEUE:INTERNAL=1
+//Result of TRY_COMPILE
+EVENT__HAVE_WORKING_KQUEUE_COMPILED:INTERNAL=TRUE
+//Result of try_run()
+EVENT__HAVE_WORKING_KQUEUE_EXITCODE:INTERNAL=0
 //Have symbol __FUNCTION__
 EVENT__HAVE___FUNCTION__:INTERNAL=1
 //Have symbol __func__

    </details> <details> <summary>zeromq</summary>

    --- cmake-zeromq-base.txt	Tue Feb 11 10:27:24 2025
+++ cmake-zeromq-patched.txt	Tue Feb 11 10:38:24 2025
@@ -1,5 +1,5 @@
 # This is the CMakeCache file.
-# For build in directory: /home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75/build
+# For build in directory: /home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/zeromq/4.3.5-1b22ee1386d/build
 # It was generated by CMake: /usr/local/bin/cmake
 # You can edit this file to change values found and used by cmake.
 # If you do not want to change any of the values, simply exit the editor.
@@ -61,11 +61,8 @@
 //Generate index for LLVM archive
 CMAKE_CXX_COMPILER_RANLIB:FILEPATH=CMAKE_CXX_COMPILER_RANLIB-NOTFOUND
 
-//No help, variable specified on the command line.
-CMAKE_CXX_COMPILER_TARGET:UNINITIALIZED=amd64-unknown-openbsd7.6
-
 //Flags used by the CXX compiler during all build types.
-CMAKE_CXX_FLAGS:STRING=-I/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/include -pipe -std=c++20 -O2 -fdebug-prefix-map=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75=/usr -fmacro-prefix-map=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75=/usr
+CMAKE_CXX_FLAGS:STRING=-I/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/include -pipe -std=c++20 -O2 -ffile-prefix-map=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/zeromq/4.3.5-1b22ee1386d=/usr
 
 //Flags used by the CXX compiler during DEBUG builds.
 CMAKE_CXX_FLAGS_DEBUG:STRING=-g
@@ -97,11 +94,8 @@
 //Generate index for LLVM archive
 CMAKE_C_COMPILER_RANLIB:FILEPATH=CMAKE_C_COMPILER_RANLIB-NOTFOUND
 
-//No help, variable specified on the command line.
-CMAKE_C_COMPILER_TARGET:UNINITIALIZED=amd64-unknown-openbsd7.6
-
 //Flags used by the C compiler during all build types.
-CMAKE_C_FLAGS:STRING=-I/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/include -pipe -std=c11 -O2
+CMAKE_C_FLAGS:STRING=-I/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/include -pipe -std=c11 -O2
 
 //Flags used by the C compiler during DEBUG builds.
 CMAKE_C_FLAGS_DEBUG:STRING=-g
@@ -122,7 +116,7 @@
 CMAKE_DLLTOOL:FILEPATH=CMAKE_DLLTOOL-NOTFOUND
 
 //Flags used by the linker during all build types.
-CMAKE_EXE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/lib
+CMAKE_EXE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/lib
 
 //Flags used by the linker during DEBUG builds.
 CMAKE_EXE_LINKER_FLAGS_DEBUG:STRING=
@@ -143,7 +137,7 @@
 CMAKE_EXPORT_COMPILE_COMMANDS:BOOL=
 
 //Value Computed by CMake.
-CMAKE_FIND_PACKAGE_REDIRECTS_DIR:STATIC=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75/build/CMakeFiles/pkgRedirects
+CMAKE_FIND_PACKAGE_REDIRECTS_DIR:STATIC=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/zeromq/4.3.5-1b22ee1386d/build/CMakeFiles/pkgRedirects
 
 //User executables (bin)
 CMAKE_INSTALL_BINDIR:PATH=bin
@@ -182,7 +176,7 @@
 CMAKE_INSTALL_OLDINCLUDEDIR:PATH=/usr/include
 
 //No help, variable specified on the command line.
-CMAKE_INSTALL_PREFIX:PATH=/home/user/bitcoin/depends/amd64-unknown-openbsd7.6
+CMAKE_INSTALL_PREFIX:PATH=/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6
 
 //Run-time variable data (LOCALSTATEDIR/run)
 CMAKE_INSTALL_RUNSTATEDIR:PATH=
@@ -204,7 +198,7 @@
 
 //Flags used by the linker during the creation of modules during
 // all build types.
-CMAKE_MODULE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/lib
+CMAKE_MODULE_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/lib
 
 //Flags used by the linker during the creation of modules during
 // DEBUG builds.
@@ -255,7 +249,7 @@
 
 //Flags used by the linker during the creation of shared libraries
 // during all build types.
-CMAKE_SHARED_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/amd64-unknown-openbsd7.6/lib
+CMAKE_SHARED_LINKER_FLAGS:STRING=-L/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6/lib
 
 //Flags used by the linker during the creation of shared libraries
 // during DEBUG builds.
@@ -311,9 +305,6 @@
 //Path to a program.
 CMAKE_STRIP:FILEPATH=/usr/bin/strip
 
-//No help, variable specified on the command line.
-CMAKE_SYSTEM_NAME:UNINITIALIZED=OpenBSD
-
 //Path to a program.
 CMAKE_TAPI:FILEPATH=CMAKE_TAPI-NOTFOUND
 
@@ -422,13 +413,13 @@
 ZMQ_OUTPUT_BASENAME:STRING=zmq
 
 //Value Computed by CMake
-ZeroMQ_BINARY_DIR:STATIC=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75/build
+ZeroMQ_BINARY_DIR:STATIC=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/zeromq/4.3.5-1b22ee1386d/build
 
 //Value Computed by CMake
 ZeroMQ_IS_TOP_LEVEL:STATIC=ON
 
 //Value Computed by CMake
-ZeroMQ_SOURCE_DIR:STATIC=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75
+ZeroMQ_SOURCE_DIR:STATIC=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/zeromq/4.3.5-1b22ee1386d
 
 
 ########################
@@ -446,7 +437,7 @@
 //ADVANCED property for variable: CMAKE_AR
 CMAKE_AR-ADVANCED:INTERNAL=1
 //This is the directory where this CMakeCache.txt was created
-CMAKE_CACHEFILE_DIR:INTERNAL=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75/build
+CMAKE_CACHEFILE_DIR:INTERNAL=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/zeromq/4.3.5-1b22ee1386d/build
 //Major version of cmake used to create the current loaded cache
 CMAKE_CACHE_MAJOR_VERSION:INTERNAL=3
 //Minor version of cmake used to create the current loaded cache
@@ -539,7 +530,7 @@
 CMAKE_HAVE_PTHREAD_CREATE:INTERNAL=1
 //Source directory with the top level CMakeLists.txt file for this
 // project
-CMAKE_HOME_DIRECTORY:INTERNAL=/home/user/bitcoin/depends/work/build/amd64-unknown-openbsd7.6/zeromq/4.3.5-39f0933fb75
+CMAKE_HOME_DIRECTORY:INTERNAL=/home/user/bitcoin/depends/work/build/x86_64-unknown-openbsd7.6/zeromq/4.3.5-1b22ee1386d
 //ADVANCED property for variable: CMAKE_INSTALL_BINDIR
 CMAKE_INSTALL_BINDIR-ADVANCED:INTERNAL=1
 //ADVANCED property for variable: CMAKE_INSTALL_DATADIR
@@ -684,12 +675,22 @@
 ZMQ_HAVE_BUSY_POLL:INTERNAL=
 //Have includes sys/eventfd.h
 ZMQ_HAVE_EVENTFD:INTERNAL=
+//Test ZMQ_HAVE_GETRANDOM
+ZMQ_HAVE_GETRANDOM:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_GETRANDOM_COMPILED:INTERNAL=FALSE
 //Have include ifaddrs.h
 ZMQ_HAVE_IFADDRS:INTERNAL=1
 //Have symbol LOCAL_PEERCRED
 ZMQ_HAVE_LOCAL_PEERCRED:INTERNAL=
 //Test ZMQ_HAVE_NOEXCEPT
 ZMQ_HAVE_NOEXCEPT:INTERNAL=1
+//Test ZMQ_HAVE_O_CLOEXEC
+ZMQ_HAVE_O_CLOEXEC:INTERNAL=1
+//Result of TRY_COMPILE
+ZMQ_HAVE_O_CLOEXEC_COMPILED:INTERNAL=TRUE
+//Result of try_run()
+ZMQ_HAVE_O_CLOEXEC_EXITCODE:INTERNAL=0
 //Test ZMQ_HAVE_PTHREAD_SETNAME_1
 ZMQ_HAVE_PTHREAD_SETNAME_1:INTERNAL=
 //Test ZMQ_HAVE_PTHREAD_SETNAME_2
@@ -700,12 +701,54 @@
 ZMQ_HAVE_PTHREAD_SET_AFFINITY:INTERNAL=
 //Test ZMQ_HAVE_PTHREAD_SET_NAME
 ZMQ_HAVE_PTHREAD_SET_NAME:INTERNAL=
+//Test ZMQ_HAVE_SOCK_CLOEXEC
+ZMQ_HAVE_SOCK_CLOEXEC:INTERNAL=1
+//Result of TRY_COMPILE
+ZMQ_HAVE_SOCK_CLOEXEC_COMPILED:INTERNAL=TRUE
+//Result of try_run()
+ZMQ_HAVE_SOCK_CLOEXEC_EXITCODE:INTERNAL=0
+//Test ZMQ_HAVE_SO_BINDTODEVICE
+ZMQ_HAVE_SO_BINDTODEVICE:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_SO_BINDTODEVICE_COMPILED:INTERNAL=TRUE
+//Result of try_run()
+ZMQ_HAVE_SO_BINDTODEVICE_EXITCODE:INTERNAL=1
+//Test ZMQ_HAVE_SO_KEEPALIVE
+ZMQ_HAVE_SO_KEEPALIVE:INTERNAL=1
+//Result of TRY_COMPILE
+ZMQ_HAVE_SO_KEEPALIVE_COMPILED:INTERNAL=TRUE
+//Result of try_run()
+ZMQ_HAVE_SO_KEEPALIVE_EXITCODE:INTERNAL=0
 //Have symbol SO_PEERCRED
 ZMQ_HAVE_SO_PEERCRED:INTERNAL=1
+//Test ZMQ_HAVE_SO_PRIORITY
+ZMQ_HAVE_SO_PRIORITY:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_SO_PRIORITY_COMPILED:INTERNAL=FALSE
 //Have include condition_variable
 ZMQ_HAVE_STL_CONDITION_VARIABLE:INTERNAL=1
 //Have symbol strlcpy
 ZMQ_HAVE_STRLCPY:INTERNAL=1
+//Test ZMQ_HAVE_TCP_KEEPALIVE
+ZMQ_HAVE_TCP_KEEPALIVE:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_TCP_KEEPALIVE_COMPILED:INTERNAL=FALSE
+//Test ZMQ_HAVE_TCP_KEEPCNT
+ZMQ_HAVE_TCP_KEEPCNT:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_TCP_KEEPCNT_COMPILED:INTERNAL=FALSE
+//Test ZMQ_HAVE_TCP_KEEPIDLE
+ZMQ_HAVE_TCP_KEEPIDLE:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_TCP_KEEPIDLE_COMPILED:INTERNAL=FALSE
+//Test ZMQ_HAVE_TCP_KEEPINTVL
+ZMQ_HAVE_TCP_KEEPINTVL:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_TCP_KEEPINTVL_COMPILED:INTERNAL=FALSE
+//Test ZMQ_HAVE_TIPC
+ZMQ_HAVE_TIPC:INTERNAL=
+//Result of TRY_COMPILE
+ZMQ_HAVE_TIPC_COMPILED:INTERNAL=FALSE
 //Have include sys/uio.h
 ZMQ_HAVE_UIO:INTERNAL=1
 //Have includes windows.h
@@ -713,5 +756,5 @@
 //linker supports push/pop state
 _CMAKE_LINKER_PUSHPOP_STATE_SUPPORTED:INTERNAL=TRUE
 //CMAKE_INSTALL_PREFIX during last run
-_GNUInstallDirs_LAST_CMAKE_INSTALL_PREFIX:INTERNAL=/home/user/bitcoin/depends/amd64-unknown-openbsd7.6
+_GNUInstallDirs_LAST_CMAKE_INSTALL_PREFIX:INTERNAL=/home/user/bitcoin/depends/x86_64-unknown-openbsd7.6

    </details>

    • Another difference i've noticed is that the output is now dropped into depends/x86_64-unknown-openbsd7.6/toolchain.cmake instead of depends/amd64-unknown-openbsd7.6/toolchain.cmake
  27. theuni approved
  28. theuni commented at 8:54 PM on February 11, 2025: member

    utACK b28917be363fb5a82effffeadbe4ba27bb1c70ce.

    Makes sense, thanks for fixing.

  29. theuni commented at 9:09 PM on February 11, 2025: member

    @laanwj Interesting! Looks like cross builds of libevent for kqueue platforms suffer because of the wonky check_c_source_runs that can only succeed for native builds. That's probably worth addressing itself.

  30. fanquake merged this on Feb 12, 2025
  31. fanquake closed this on Feb 12, 2025
  32. hebasto deleted the branch on Feb 12, 2025
  33. hebasto referenced this in commit c7ac5ed7cd on Feb 12, 2025
  34. hebasto referenced this in commit ac89c40888 on Feb 12, 2025
  35. hebasto referenced this in commit 8b00cb1ba5 on Feb 12, 2025
  36. sedited referenced this in commit f78a01a560 on Feb 22, 2025
  37. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  38. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  39. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  40. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  41. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  42. bug-castercv502 referenced this in commit d15545ffaa on Sep 28, 2025
  43. knst referenced this in commit 3c5565f85b on Oct 22, 2025
  44. kwvg referenced this in commit 6ca5e59d29 on Oct 24, 2025
  45. kwvg referenced this in commit 79d882cd39 on Oct 24, 2025
  46. kwvg referenced this in commit 55b4325a86 on Oct 24, 2025
  47. kwvg referenced this in commit 9075117058 on Oct 25, 2025
  48. kwvg referenced this in commit 166376b671 on Oct 25, 2025
  49. kwvg referenced this in commit c54bc57f05 on Nov 4, 2025
  50. kwvg referenced this in commit 5594857bd5 on Nov 8, 2025
  51. kwvg referenced this in commit ee687d1f2e on Nov 12, 2025
  52. kwvg referenced this in commit 86d0a27757 on Nov 14, 2025
  53. PastaPastaPasta referenced this in commit 9590d57aaf on Nov 14, 2025
  54. UdjinM6 referenced this in commit 3b41a910fa on Nov 18, 2025
  55. bitcoin locked this on Feb 12, 2026
Contributors
hebastoDrahtBotfanquaketheStackmaflckolaanwjtheuni


josibake

Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 21:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me