ci: Silent Homebrew's reinstall warnings #30591

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240805-ci-brew changing 1 files +2 −2

hebasto commented at 4:17 PM on August 5, 2024: member

Homebrew's warnings are quite noisy on the master branch:

This PR silents them to allow us to focus on other CI infra warnings once they happen.

Similar to https://github.com/bitcoin-core/secp256k1/pull/1578.
ci: Silent Homebrew's reinstall warnings 032ebe5be4
hebasto added the label Tests on Aug 5, 2024
DrahtBot commented at 4:17 PM on August 5, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK willcl-ark, tdb3

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
willcl-ark approved
willcl-ark commented at 3:10 PM on August 6, 2024: member

utACK 032ebe5be4dfc3eb3d3693f1284fac6458bacbf3
maflcko approved
maflcko commented at 8:15 AM on August 7, 2024: member

lgtm
tdb3 approved
tdb3 commented at 3:04 PM on August 7, 2024: contributor

cr ut ACK 032ebe5be4dfc3eb3d3693f1284fac6458bacbf3

Type	Reviewers
ACK	willcl-ark, tdb3

in .github/workflows/ci.yml:107 in 032ebe5be4

 103 | @@ -104,8 +104,8 @@ jobs:
 104 |            HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1
 105 |          run: |
 106 |            # A workaround for "The `brew link` step did not complete successfully" error.
 107 | -          brew install python@3 || brew link --overwrite python@3
 108 | -          brew install automake libtool pkg-config gnu-getopt ccache boost libevent miniupnpc libnatpmp zeromq qt@5 qrencode
 109 | +          brew install --quiet python@3 || brew link --overwrite python@3

fanquake commented at 10:28 AM on August 12, 2024:

Are these Qt workarounds still needed? Would be good if we could drop them, rather than adding more code to suppress warnings coming from workarounds that may no-longer be needed.

fanquake merged this on Aug 12, 2024
fanquake closed this on Aug 12, 2024
bitcoin locked this on Aug 12, 2025

Contributors

Labels

ci: Silent Homebrew's reinstall warnings #30591

Code Coverage

Reviews