doc: Drop no longer needed workaround for WSL #30597

1. 
   hebasto commented at 3:24 pm on August 6, 2024: member

   This PR effectively reverts commit 4f890ba6bc8caba5394c7a5388d7f07959ced78b from #11437, which fixed some build issues on WSL seven years ago.

   Testing the current master branch @ 31a3ff55154bf15fb35b157c3f67ec05408ecdf9 on Windows 11 + WSL using Ubuntu 24.04 or Debian images, I noticed that the workaround is no longer required. Moreover, it doesn’t affect the build process at all, which means the hashes of the built packages in depends remain the same and the configure log in the main build system remains the same as well.

2. doc: Drop no longer needed workaround for WSL

   This change effectively reverts 4f890ba6bc8caba5394c7a5388d7f07959ced78b.

   16d8261181
3. hebasto added the label Docs on Aug 6, 2024
4. hebasto added the label Windows on Aug 6, 2024
5. 
   DrahtBot commented at 3:24 pm on August 6, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipsorcery

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30454 (build: Introduce CMake-based build system by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   hebasto commented at 3:29 pm on August 6, 2024: member

   cc @sipsorcery @fanquake @m3dwards
7. 
   sipsorcery commented at 3:45 pm on August 6, 2024: member

   Testing the current master branch @ 31a3ff5 on Windows 11 + WSL using Ubuntu 24.04 or Debian images, I noticed that the workaround is no longer required.

   The command was originally added because some people had Windows environment variables that when carried across to WSL caused errors with the configure script.

   I suspect that condition still exists. Maybe it’s safer to leave the command there until the configure step is removed by cmake?

8. 
   hebasto commented at 3:50 pm on August 6, 2024: member

   I suspect that condition still exists. Maybe it’s safer to leave the command there until the configure step is removed by cmake?

   I would be great to document such a condition more explicitly.

   However, I’m okay with either outcome.

9. 
   hebasto commented at 3:55 pm on August 6, 2024: member

   Maybe it’s safer to leave the command there until the configure step is removed by cmake?

   I’ve read #10269 again, and it seems all complaints were about building a native package in depends, which is no longer the case.

10. 
    sipsorcery commented at 4:01 pm on August 6, 2024: member

    I’ve read #10269 again, and it seems all complaints were about building a native package in depends, which is no longer the case.

    That does ring a bell.

    utACK 16d82611812de4e91e7950fe6d31484cc7a9c937.

11. 
    fanquake commented at 4:03 pm on August 6, 2024: member

    were about building a native package in depends, which is no longer the case.

    Qt still builds a native package ?

12. 
    hebasto commented at 4:14 pm on August 6, 2024: member

    were about building a native package in depends, which is no longer the case.

    Qt still builds a native package ?

    Right. It’s a qmake itself. I meant the native_* packages that are handled by the depends build subsystem in its own way.

13. fanquake merged this on Aug 12, 2024
14. fanquake closed this on Aug 12, 2024

    ---

15. hebasto deleted the branch on Aug 12, 2024

Contributors
hebasto DrahtBot sipsorcery fanquake

Labels
Docs Windows