test: remove `ExtractDestination` false assertion for `ANCHOR` script #30616

pull ismaelsadeeq wants to merge 1 commits into bitcoin:master from ismaelsadeeq:08-2024-fix-TxTypeANCHOR-assertion changing 1 files +2 −4

ismaelsadeeq commented at 11:04 AM on August 9, 2024: member

This PR fixes #30615

ExtractDestination returns true when TxoutType is ANCHOR see #30615 (comment)
[test]: remove `ExtractDestination` false assertion for `ANCHOR` script a4f2b18573
DrahtBot commented at 11:04 AM on August 9, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, theStack, instagibbs, BrandonOdiwuor, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
maflcko commented at 11:27 AM on August 9, 2024: member

review ACK a4f2b185732649eeea4a042cebd90d0e0e12cc92

ANCHOR has a destination (it is basically a witness program version + witness program data), so the change looks correct.

(Nit: You can replace [test] with test: in the GitHub pull title to have DrahtBot assign the pull request label for you.)
ismaelsadeeq renamed this:
~~[test]: remove `ExtractDestination` false assertion for `ANCHOR` script~~
test: remove `ExtractDestination` false assertion for `ANCHOR` script
on Aug 9, 2024
DrahtBot added the label Tests on Aug 9, 2024
theStack approved
theStack commented at 11:38 AM on August 9, 2024: contributor

utACK a4f2b185732649eeea4a042cebd90d0e0e12cc92
maflcko added this to the milestone 28.0 on Aug 9, 2024
maflcko commented at 1:36 PM on August 9, 2024: member

(Could wait a day before merging this, to check if OSS-Fuzz also found it, because it should and so far has not)
fanquake requested review from instagibbs on Aug 9, 2024
instagibbs commented at 1:48 PM on August 9, 2024: member

ACK a4f2b185732649eeea4a042cebd90d0e0e12cc92

this was leftover from when anchor outputs were bare OP_TRUE, which don't have an address
BrandonOdiwuor approved
BrandonOdiwuor commented at 2:07 PM on August 9, 2024: contributor

Code Review ACK a4f2b185732649eeea4a042cebd90d0e0e12cc92
glozow commented at 3:18 PM on August 9, 2024: member

ACK a4f2b185732649eeea4a042cebd90d0e0e12cc92

Reproduced crash and fix, looks correct. Will plan to merge later.
maflcko commented at 10:31 AM on August 10, 2024: member

(Could wait a day before merging this, to check if OSS-Fuzz also found it, because it should and so far has not)

I guess it may just be non-trivial to find. Let's merge this here, and continue discussion in https://github.com/bitcoin/bitcoin/issues/30615
glozow merged this on Aug 12, 2024
glozow closed this on Aug 12, 2024
ismaelsadeeq deleted the branch on Aug 12, 2024
Theschorpioen approved
bitcoin locked this on Aug 12, 2025