A new clang version generally comes with bugfixes, new sanitizer features, deprecations, as well as new features.
Upgrade the memory sanitizer tasks to use the new version.
(Ref #30634)
ci: Use clang-19 in msan tasks #30639
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2408-ci-msan-19 changing 1 files +1 −1-
maflcko commented at 5:11 PM on August 12, 2024: member
-
DrahtBot commented at 5:11 PM on August 12, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Aug 12, 2024
- maflcko force-pushed on Aug 13, 2024
- maflcko force-pushed on Aug 20, 2024
-
fanquake commented at 10:12 AM on August 29, 2024: member
lgtm locally (on aarch64). There haven't been many changes since rc3, but do you want to wait for final, (which should be on the 3rd)?
- maflcko marked this as a draft on Aug 29, 2024
-
maflcko commented at 10:17 AM on August 29, 2024: member
Sure, let's wait another week.
- maflcko force-pushed on Aug 29, 2024
- maflcko force-pushed on Sep 5, 2024
-
fanquake commented at 9:36 AM on September 6, 2024: member
Given that final has been pushed back a bit, also happy to put this in at
rc4, and bump it again later (if needed). -
maflcko commented at 9:39 AM on September 6, 2024: member
I'd say to keep testing minimal my preference would be to just touch it once.
(The aarch64 build has to be done manually every time)
- DrahtBot added the label CI failed on Sep 7, 2024
- DrahtBot removed the label CI failed on Sep 13, 2024
-
fanquake commented at 12:24 PM on September 17, 2024: member
19.1.0 is now available: https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.0.
-
ci: Use clang-19 in msan tasks ccccb67851
- maflcko force-pushed on Sep 17, 2024
- maflcko marked this as ready for review on Sep 17, 2024
-
maflcko commented at 8:22 PM on September 17, 2024: member
Tested on aarch64 and both passed:
MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.shMAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_fuzz_with_msan.sh" ./ci/test_run_all.sh
- fanquake approved
-
fanquake commented at 5:38 PM on September 18, 2024: member
ACK ccccb67851b03a7042bbf62a5534607f174ec47b Tested both jobs on aarch64, and one on x86_64 with
mmap_rnd_bits. - fanquake merged this on Sep 18, 2024
- fanquake closed this on Sep 18, 2024
- maflcko deleted the branch on Sep 19, 2024
- TheCharlatan referenced this in commit 8bb47d4c2c on Nov 2, 2024
- bitcoin locked this on Sep 19, 2025
Labels