This was previously used to install hexdump (for the tests). However that isn't used by CMake. I'm not aware of any other tools from this package being used.
Remove bsdmainutils from doc/ci #30749
pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:no_bsd_main_utils changing 3 files +3 −3-
fanquake commented at 9:24 AM on August 29, 2024: member
-
DrahtBot commented at 9:24 AM on August 29, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- hebasto approved
-
hebasto commented at 9:38 AM on August 29, 2024: member
This was previously used to install
hexdump(for the tests).(via the
bsdextrautilspackage, at least on Ubuntu 24.04)ACK c462276e6eea70efb0dd3a486f50fb32a7934500.
-
ci: remove bsdmainutils 36ff336d2e
-
doc: remove bsdmainutils a2b1d2c5ec
-
maflcko commented at 10:02 AM on August 29, 2024: member
-- Checking for module 'libzmq>=4' -- Package 'libzmq', required by 'virtual:world', not found CMake Error at /usr/local/share/cmake-3.30/Modules/FindPkgConfig.cmake:645 (message): The following required packages were not found: - libzmq>=4 Call Stack (most recent call first): /usr/local/share/cmake-3.30/Modules/FindPkgConfig.cmake:873 (_pkg_check_modules_internal) CMakeLists.txt:150 (pkg_check_modules) -- Configuring incomplete, errors occurred! -
fanquake commented at 10:04 AM on August 29, 2024: member
Yea, see my comment here: https://github.com/bitcoin/bitcoin/pull/30740/files#r1735920877. I will just add the proper dependency.
-
ci: add libzmq3-dev to test-each-commit job 78358ce09d
- fanquake force-pushed on Aug 29, 2024
-
maflcko commented at 10:13 AM on August 29, 2024: member
ACK 78358ce09d2a62a469a544249e02e02f9f7b94cd
- DrahtBot requested review from hebasto on Aug 29, 2024
- maflcko added the label Bug on Aug 29, 2024
- maflcko removed the label Bug on Aug 29, 2024
- hebasto approved
-
hebasto commented at 11:01 AM on August 29, 2024: member
ACK 78358ce09d2a62a469a544249e02e02f9f7b94cd.
-
fanquake commented at 11:29 AM on August 29, 2024: member
Going to merge this now, to prevent any further unrelated CI failures in other PRs.
- fanquake merged this on Aug 29, 2024
- fanquake closed this on Aug 29, 2024
- fanquake deleted the branch on Aug 29, 2024
-
Sjors commented at 11:44 AM on August 29, 2024: member
Just ran into this as well, thanks for the fix.
- bitcoin locked this on Aug 29, 2025
