build: Drop no longer needed workaround #30753

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240829-zmg-mingw changing 1 files +0 −5

hebasto commented at 1:16 pm on August 29, 2024: member

This PR deletes a workaround that is no longer needed since #30508 was merged.
build: Drop no longer needed workaround 66dd1b4e58
hebasto added the label Build system on Aug 29, 2024
DrahtBot commented at 1:16 pm on August 29, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers

ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
maflcko added the label DrahtBot Guix build requested on Aug 29, 2024

Type	Reviewers
ACK	fanquake

hebasto commented at 1:46 pm on August 29, 2024: member

My Guix build:

0x86_64
1465550d1ff8230f46def1caec67295f6d9604f83d4d1fe64ba59c32385f6cc0f  guix-build-66dd1b4e5834/output/dist-archive/bitcoin-66dd1b4e5834.tar.gz
29d3ab6eca8eaec266029ce28d7d569f1c6d08d21bf0a21ddaf37978cbd54b138  guix-build-66dd1b4e5834/output/x86_64-w64-mingw32/SHA256SUMS.part
313c8a25e3312ecdf4d3a7ba0ddc0eadc3efcbe215406a4cd354aecc3ac4d069c  guix-build-66dd1b4e5834/output/x86_64-w64-mingw32/bitcoin-66dd1b4e5834-win64-debug.zip
41b304115f30f8ade2599e1e26de17a0d576e4a6f2f5914f79f358a380655c90a  guix-build-66dd1b4e5834/output/x86_64-w64-mingw32/bitcoin-66dd1b4e5834-win64-setup-unsigned.exe
57e67c63c34d7305f881634669a59d326e9d3244cf42c2ef82a3b6c69f1da4f8d  guix-build-66dd1b4e5834/output/x86_64-w64-mingw32/bitcoin-66dd1b4e5834-win64-unsigned.tar.gz
68f9c6970179304ac94941df3066ab670234b67c59dcbfcd7f9af0e22392eeba4  guix-build-66dd1b4e5834/output/x86_64-w64-mingw32/bitcoin-66dd1b4e5834-win64.zip

hebasto added the label Windows on Aug 29, 2024

DrahtBot commented at 7:05 am on August 30, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit ffdc3d6060f6e65e69cf115a13b83e6eb4a0a0a8(master)	commit 1ae72f7aad7cdaeafbf92f03bc17a8545ff0b73b(master and this pull)
SHA256SUMS.part	`71ed50b6d289b238...`	`51d6b7333f1d6387...`
*-aarch64-linux-gnu-debug.tar.gz	`00bab5cca7aaae4c...`	`eecb0ff07a5352b6...`
*-aarch64-linux-gnu.tar.gz	`8a111f767273af1c...`	`6366bccda8d7517d...`
*-arm-linux-gnueabihf-debug.tar.gz	`585fef7dc96c1a9a...`	`db7daf2f01244133...`
*-arm-linux-gnueabihf.tar.gz	`7fae40f023a8f904...`	`1aa290de71507ab6...`
*-arm64-apple-darwin-unsigned.tar.gz	`99c76b6bf2e9c5a7...`	`b3426e1d45c1434e...`
*-arm64-apple-darwin-unsigned.zip	`73c88c0615a1bda7...`	`1d0f399919782e71...`
*-arm64-apple-darwin.tar.gz	`2a91253882bebf88...`	`d4a66e6ad565db5b...`
*-powerpc64-linux-gnu-debug.tar.gz	`fe12479f272a2b67...`	`af5f284d0ed3b91a...`
*-powerpc64-linux-gnu.tar.gz	`e55c68784ddcbed3...`	`7911ac7555e1e5f0...`
*-riscv64-linux-gnu-debug.tar.gz	`b62b1441bcfc5c7d...`	`e7daec4cfc9302ce...`
*-riscv64-linux-gnu.tar.gz	`9aa7155b01d40f3c...`	`b0a576eeb84dbed6...`
*-x86_64-apple-darwin-unsigned.tar.gz	`6e44823ed65f7439...`	`3389dba353c2b1db...`
*-x86_64-apple-darwin-unsigned.zip	`22c5869489901e80...`	`fdd0765138607569...`
*-x86_64-apple-darwin.tar.gz	`218adb38cfc86e01...`	`21f79e652b1867c0...`
*-x86_64-linux-gnu-debug.tar.gz	`a3a0573f1194e574...`	`eda905721690b1d0...`
*-x86_64-linux-gnu.tar.gz	`a38bde55da9dda9b...`	`dfef716a5f81ce7d...`
*.tar.gz	`48a5b331bd860618...`	`ba7feef672f11abf...`
guix_build.log	`53a3ba01918c80db...`	`f32cffbb24827782...`
guix_build.log.diff		`6251e5a6b5d91fcc...`

DrahtBot removed the label DrahtBot Guix build requested on Aug 30, 2024
fanquake approved
fanquake commented at 1:04 pm on August 30, 2024: member

ACK 66dd1b4e58347327c14e5d9a26ce41592b07113f
fanquake merged this on Aug 30, 2024
fanquake closed this on Aug 30, 2024
hebasto deleted the branch on Aug 30, 2024

Contributors
hebasto DrahtBot fanquake

Labels
Windows Build system

build: Drop no longer needed workaround #30753

Code Coverage

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]