These don't seem to be included in, i.e #30664.
misc: Autotools -> CMake changes #30754
pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:deps_now_cmake changing 3 files +3 −5-
fanquake commented at 2:51 PM on August 29, 2024: member
-
DrahtBot commented at 2:51 PM on August 29, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
maflcko commented at 3:02 PM on August 29, 2024: member
I think a three line diff can be squashed into one commit, as the changes here are related. Otherwise lgtm.
lgtm ACK 4188c2a11241ece8774e62b0f585adb91aa44cb9
-
fanquake commented at 3:03 PM on August 29, 2024: member
Given the lint change actually changes behaviour, I don't think squashing that into "doc" changes is correct. But will squash the other two.
-
theuni commented at 3:05 PM on August 29, 2024: member
LGTM ACK after squash
- hebasto approved
-
hebasto commented at 3:05 PM on August 29, 2024: member
ACK 4188c2a11241ece8774e62b0f585adb91aa44cb9.
- DrahtBot requested review from theuni on Aug 29, 2024
-
doc: replace Autotools with CMake b02f29e7ef
-
lint: remove autotools packages a865494dee
- fanquake force-pushed on Aug 29, 2024
-
maflcko commented at 3:09 PM on August 29, 2024: member
lgtm ACK a865494deeff7dedcad7140299aee00ab3cdd62c
- DrahtBot requested review from hebasto on Aug 29, 2024
- hebasto approved
-
hebasto commented at 3:16 PM on August 29, 2024: member
re-ACK a865494deeff7dedcad7140299aee00ab3cdd62c.
- fanquake merged this on Aug 29, 2024
- fanquake closed this on Aug 29, 2024
- fanquake deleted the branch on Aug 29, 2024
- bitcoin locked this on Aug 29, 2025