misc: Autotools -> CMake changes #30754

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:deps_now_cmake changing 3 files +3 −5
  1. fanquake commented at 2:51 pm on August 29, 2024: member
    These don’t seem to be included in, i.e #30664.
  2. DrahtBot commented at 2:51 pm on August 29, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, hebasto
    Concept ACK theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. maflcko commented at 3:02 pm on August 29, 2024: member

    I think a three line diff can be squashed into one commit, as the changes here are related. Otherwise lgtm.

    lgtm ACK 4188c2a11241ece8774e62b0f585adb91aa44cb9

  4. fanquake commented at 3:03 pm on August 29, 2024: member
    Given the lint change actually changes behaviour, I don’t think squashing that into “doc” changes is correct. But will squash the other two.
  5. theuni commented at 3:05 pm on August 29, 2024: member
    LGTM ACK after squash
  6. hebasto approved
  7. hebasto commented at 3:05 pm on August 29, 2024: member
    ACK 4188c2a11241ece8774e62b0f585adb91aa44cb9.
  8. DrahtBot requested review from theuni on Aug 29, 2024
  9. doc: replace Autotools with CMake b02f29e7ef
  10. lint: remove autotools packages a865494dee
  11. fanquake force-pushed on Aug 29, 2024
  12. maflcko commented at 3:09 pm on August 29, 2024: member
    lgtm ACK a865494deeff7dedcad7140299aee00ab3cdd62c
  13. DrahtBot requested review from hebasto on Aug 29, 2024
  14. hebasto approved
  15. hebasto commented at 3:16 pm on August 29, 2024: member
    re-ACK a865494deeff7dedcad7140299aee00ab3cdd62c.
  16. fanquake merged this on Aug 29, 2024
  17. fanquake closed this on Aug 29, 2024

  18. fanquake deleted the branch on Aug 29, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-20 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me