fuzz: Rename fuzz_seed_corpus to fuzz_corpora #30804

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2409-fuzz-rename changing 5 files +11 −11
  1. maflcko commented at 6:46 pm on September 3, 2024: member

    Now that cmake was a breaking change for all fuzz scripts, it seems fine to bundle it with another breaking change to rename the fuzz corpora directory, as discussed and approved in https://github.com/bitcoin-core/qa-assets/issues/200:

    • The word “seed” in the old name doesn’t really apply. In reality it is a collection of fuzz input seeds, as well as fuzz inputs.
    • The rename will also allow in the future (when there is a need and desire) to provide a minimal set of possibly hand-crafted or otherwise non-fuzz-generated fuzz seed inputs to some fuzz targets (and possibly store them in a separate folder and validate that their format is still accurate and matches the fuzz target code).
    • Finally, “corpus” is renamed to corpora, to clarify that the folder holds the fuzz inputs for several fuzz targets.
  2. scripted-diff: fuzz: Rename fuzz_seed_corpus to fuzz_corpora
    -BEGIN VERIFY SCRIPT-
     ren() { sed -i "s:\<$1\>:$2:g" $( git grep -l "$1" ) ; }
     ren fuzz_seed_corpus     fuzz_corpora
     ren FUZZ_SEED_CORPUS_DIR FUZZ_CORPORA_DIR
    -END VERIFY SCRIPT-
    8888beea8d
  3. DrahtBot commented at 6:46 pm on September 3, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK brunoerg, marcofleon

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30772 (build: Fix / improve coverage scripts by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Refactoring on Sep 3, 2024
  5. maflcko renamed this:
    scripted-diff: fuzz: Rename fuzz_seed_corpus to fuzz_corpora
    fuzz: Rename fuzz_seed_corpus to fuzz_corpora
    on Sep 3, 2024
  6. maflcko removed the label Refactoring on Sep 3, 2024
  7. DrahtBot added the label Tests on Sep 3, 2024
  8. brunoerg approved
  9. brunoerg commented at 8:20 pm on September 3, 2024: contributor
    ACK 8888beea8d477b1d4a2dfd2a0bb5f686de62f3ff
  10. fanquake commented at 9:01 am on September 4, 2024: member
  11. marcofleon approved
  12. marcofleon commented at 11:05 am on September 4, 2024: contributor
    ACK 8888beea8d477b1d4a2dfd2a0bb5f686de62f3ff
  13. fanquake merged this on Sep 4, 2024
  14. fanquake closed this on Sep 4, 2024

  15. maflcko deleted the branch on Sep 4, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me